The patch fixes a few casts used where an lvalue is required. Moreover, a substitution have been removed from the Makefile and incorporated into ${FILESDIR}/patch-holyshout.c where other substitutions for the same file exist. Last, a substitution have been added to the port's Makefile, to change the occurrences of "gcc" with "${CC}" in the distribution's Makefiles in order to allow to specify a different compiler e.g. in make.conf Fix: The patch is at: http://www.gahr.ch/FreeBSD/patches/<this_PR_number>_holyshout.diff How-To-Repeat: cd /usr/ports/audio/holyshout && make
Responsible Changed From-To: freebsd-ports-bugs->miwi I'll take it.
Please find the last patch here: http://www.gahr.ch/FreeBSD/patches/117778_holyshout.diff - fix build with GCC 4.2 - move from internal liblame to liblame from ports - move from libshout1 to libshout2 Test + feedback highly welcome! -- Pietro Cerutti PGP Public Key: http://gahr.ch/pgp
State Changed From-To: open->closed Committed. Thanks!
miwi 2007-11-14 08:23:24 UTC FreeBSD ports repository Modified files: audio/holyshout Makefile Added files: audio/holyshout/files patch-Makefile patch-holyshout.c patch-holyshout.h Log: - Fix build with gcc 4.2 - Pass maintainership to submitter PR: 117778 Submitted by: Pietro Cerutti <gahr@gahr.ch> Approved by: portmgr (linimon) Revision Changes Path 1.16 +4 -11 ports/audio/holyshout/Makefile 1.1 +34 -0 ports/audio/holyshout/files/patch-Makefile (new) 1.1 +273 -0 ports/audio/holyshout/files/patch-holyshout.c (new) 1.1 +31 -0 ports/audio/holyshout/files/patch-holyshout.h (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"