Bug 117801 - [patch] editors/dedit unbreak fix build with GCC 4.2 + general cleanup
Summary: [patch] editors/dedit unbreak fix build with GCC 4.2 + general cleanup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-04 00:50 UTC by Pietro Cerutti
Modified: 2007-11-05 10:20 UTC (History)
0 users

See Also:

Attachments
file.diff (3.98 KB, patch)
2007-11-04 00:50 UTC, Pietro Cerutti 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pietro Cerutti 2007-11-04 00:50:02 UTC 

A "static declaration following non-static declaration" problem existed in editors/dedit's source.
I took the chance to do some cleanup. Now the code compiles without warnings ;-)

How-To-Repeat: 

cd /usr/ports/editors/dedit && make
Comment 1 Pietro Cerutti 2007-11-04 01:05:28 UTC 
Ok, I see that gtk-send-pr 0.4.8 is not better than www-3.1 at keeping
tabs and spaces in order...

Here's the patch:

http://www.gahr.ch/FreeBSD/patches/117801_dedit.diff

-- 
Pietro Cerutti

PGP Public Key:
http://gahr.ch/pgp
Comment 2 Martin Wilke freebsd_committer freebsd_triage 2007-11-04 13:16:26 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->miwi

I'll take it.
Comment 3 Martin Wilke freebsd_committer freebsd_triage 2007-11-05 10:15:38 UTC 
State Changed
From-To: open->closed

Committed. Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2007-11-05 10:15:53 UTC 
miwi        2007-11-05 10:15:49 UTC

  FreeBSD ports repository

  Modified files:
    editors/lfhex        Makefile 
  Added files:
    editors/lfhex/files  patch-src-mappings.h 
  Log:
  - Fix build with gcc 4.2
  
  PR:             117801
  Submitted by:   Pietro Cerutti <gahr@gahr.ch>
  Approved by:    portmgr (pav)
  
  Revision  Changes    Path
  1.23      +3 -3      ports/editors/lfhex/Makefile
  1.1       +29 -0     ports/editors/lfhex/files/patch-src-mappings.h (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 dfilter service freebsd_committer freebsd_triage 2007-11-05 10:16:14 UTC 
miwi        2007-11-05 10:16:11 UTC

  FreeBSD ports repository

  Modified files:
    editors/dedit        Makefile 
  Added files:
    editors/dedit/files  patch-src-dedit.h patch-src-file.c 
                         patch-src-jcode.c patch-src-print.c 
  Log:
  - Fix build with gcc 4.2
  
  PR:             117801
  Submitted by:   Pietro Cerutti <gahr@gahr.ch>
  Approved by:    portmgr (pav)
  
  Revision  Changes    Path
  1.33      +2 -8      ports/editors/dedit/Makefile
  1.1       +10 -0     ports/editors/dedit/files/patch-src-dedit.h (new)
  1.1       +46 -0     ports/editors/dedit/files/patch-src-file.c (new)
  1.1       +46 -0     ports/editors/dedit/files/patch-src-jcode.c (new)
  1.1       +11 -0     ports/editors/dedit/files/patch-src-print.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"