This is the VTK MPEG2 encoder library, which has been removed from the main VTK distribution due to MPEG patent issues. This port is an optional dependency for the new vtk5 port.
On Fri 28 dec 07 at 11:57:31 +0100, thierry@FreeBSD.org wrote: > Excepted a minor patch to fix plist and build-depends (see hereunder), > I'd like to be sure that this soft can be packaged and put on a CD-ROM. Oops, I missed another point: don't you think that multimedia would be a better primary category? -- Th. Thomas.
On Fri 28 dec 07 at 15:55:53 +0100, Jason Bacon <bacon@smithers.neuro.mcw.edu> wrote: > >Excepted a minor patch to fix plist and build-depends (see hereunder), > > > Looks good, thanks. > >I'd like to be sure that this soft can be packaged and put on a CD-ROM. > > > Ah, yes... those annoying restrictions. I'll have to update my commit > checklist again now that we're getting into these. The Caret and FSL > ports are going to have restrictions as well. > > My impression based on these: > > http://www.mpegla.com/m2/m2-agreement.cfm > http://www.vtk.org/pipermail/vtkusers/2006-December/088818.html > http://www.techliberation.com/archives/038768.php > > is that it shouldn't be packaged. I think NO_CDROM and NO_PACKAGE will > suffice, and we probably don't need to use RESTRICTED. Kitware allows > unrestricted download of the code anyway. > > I think we should add the following message to pkg-message: > > =========== > The MPEG2 format and all software that uses it is subject to patent > restrictions. Please see > http://www.mpegla.com/m2/m2-agreement.cfm for more information. > =========== > > This probably also means the VTKMPEG2 OPTION in the vtk5 port should > default to off. Having it on could arguably make the FreeBSD project a > distributor, and responsible for collecting royalties. > > As for the category, I think placing it in multimedia is fine, but it > should still be cross-listed under math along with the rest of the vtk > ports. OK, thanks for your quick feedback! Since I'm there, I have passed CMAKE_DEFS to the configure step, in order to respect the user's CFLAGS, and to build the shared library. Hereunder is the cumulatice patch, with NO_CDROM / NO_PACKAGE and pkg-message; let me know if this is OK. --- vtkmpeg2encode.diff begins here --- diff -urN math/vtkmpeg2encode.orig/Makefile multimedia/vtkmpeg2encode/Makefile --- math/vtkmpeg2encode.orig/Makefile 2007-12-28 10:12:56.000000000 +0100 +++ multimedia/vtkmpeg2encode/Makefile 2007-12-28 16:38:36.000000000 +0100 @@ -7,7 +7,7 @@ PORTNAME= vtkmpeg2encode PORTVERSION= 5.0.3 -CATEGORIES= math +CATEGORIES= multimedia math MASTER_SITES= http://www.vtk.org/files/support/ \ http://www.neuro.mcw.edu/Ports/distfiles/VTK5/ DISTNAME= vtkmpeg2encode @@ -15,8 +15,15 @@ MAINTAINER= bacon@smithers.neuro.mcw.edu COMMENT= VTK MPEG2 encoding library +BUILD_DEPENDS= cmake>=2.2:${PORTSDIR}/devel/cmake + +NO_CDROM= the MPEG2 format and all software that uses it is subject to patent restrictions +NO_PACKAGE= ${NO_CDROM} + CMAKE?= ${LOCALBASE}/bin/cmake -CMAKE_DEFS+= -DCMAKE_INSTALL_PREFIX:PATH=${PREFIX} +CMAKE_DEFS+= -DCMAKE_INSTALL_PREFIX:PATH=${PREFIX} \ + -DCMAKE_C_FLAGS:STRING="${CFLAGS}" \ + -DBUILD_SHARED_LIBS:BOOL=ON USE_LDCONFIG= yes @@ -26,6 +33,7 @@ MPEGLIB= libvtkMPEG2Encode +PLIST_DIRS= include/vtk-5.0 PLIST_FILES= lib/${MPEGLIB}.so.${PORTVERSION} \ lib/${MPEGLIB}.so.5.0 \ lib/${MPEGLIB}.so.5 \ @@ -37,12 +45,10 @@ include/vtk-5.0/vlc.h do-configure: - cd ${WRKSRC} && ${CMAKE} . + cd ${WRKSRC} && ${CMAKE} . ${CMAKE_DEFS} -# The CMAKE config doesn't have an option for shared libs, so we'll do -# it manually. post-build: - (cd ${WRKSRC}; ${CC} -o ${MPEGLIB}.so.${PORTVERSION} -shared CMakeFiles/vtkMPEG2Encode.dir/*.o) + ${MV} ${WRKSRC}/${MPEGLIB}.so ${WRKSRC}/${MPEGLIB}.so.${PORTVERSION} do-install: ${MKDIR} ${PREFIX}/include/vtk-5.0 @@ -61,4 +67,9 @@ ${PREFIX}/include/vtk-5.0 ${INSTALL_MAN} ${WRKDIR}/vtkmpeg2encode.3 ${MANPREFIX}/man/man3 +post-install: + @${ECHO_MSG} + @${CAT} ${PKGMESSAGE} + @${ECHO_MSG} + .include <bsd.port.mk> diff -urN math/vtkmpeg2encode.orig/pkg-message multimedia/vtkmpeg2encode/pkg-message --- math/vtkmpeg2encode.orig/pkg-message 1970-01-01 01:00:00.000000000 +0100 +++ multimedia/vtkmpeg2encode/pkg-message 2007-12-28 16:37:16.000000000 +0100 @@ -0,0 +1,3 @@ +The MPEG2 format and all software that uses it is subject to patent +restrictions. Please see http://www.mpegla.com/m2/m2-agreement.cfm +for more information. --- vtkmpeg2encode.diff ends here --- Best regards, -- Th. Thomas.
It all *looks* good, but does -DBUILD_SHARED_LIBS:BOOL=ON work for you? I tried that initially, and it produced a static lib anyway, hence the workaround. Thanks, -J Thierry Thomas wrote: > On Fri 28 dec 07 at 15:55:53 +0100, Jason Bacon <bacon@smithers.neuro.mcw.edu> > wrote: > > >>> Excepted a minor patch to fix plist and build-depends (see hereunder), >>> >>> >> Looks good, thanks. >> >>> I'd like to be sure that this soft can be packaged and put on a CD-ROM. >>> >>> >> Ah, yes... those annoying restrictions. I'll have to update my commit >> checklist again now that we're getting into these. The Caret and FSL >> ports are going to have restrictions as well. >> >> My impression based on these: >> >> http://www.mpegla.com/m2/m2-agreement.cfm >> http://www.vtk.org/pipermail/vtkusers/2006-December/088818.html >> http://www.techliberation.com/archives/038768.php >> >> is that it shouldn't be packaged. I think NO_CDROM and NO_PACKAGE will >> suffice, and we probably don't need to use RESTRICTED. Kitware allows >> unrestricted download of the code anyway. >> >> I think we should add the following message to pkg-message: >> >> =========== >> The MPEG2 format and all software that uses it is subject to patent >> restrictions. Please see >> http://www.mpegla.com/m2/m2-agreement.cfm for more information. >> =========== >> >> This probably also means the VTKMPEG2 OPTION in the vtk5 port should >> default to off. Having it on could arguably make the FreeBSD project a >> distributor, and responsible for collecting royalties. >> >> As for the category, I think placing it in multimedia is fine, but it >> should still be cross-listed under math along with the rest of the vtk >> ports. >> > > OK, thanks for your quick feedback! > > Since I'm there, I have passed CMAKE_DEFS to the configure step, in > order to respect the user's CFLAGS, and to build the shared library. > > Hereunder is the cumulatice patch, with NO_CDROM / NO_PACKAGE and > pkg-message; let me know if this is OK. > > --- vtkmpeg2encode.diff begins here --- > diff -urN math/vtkmpeg2encode.orig/Makefile multimedia/vtkmpeg2encode/Makefile > --- math/vtkmpeg2encode.orig/Makefile 2007-12-28 10:12:56.000000000 +0100 > +++ multimedia/vtkmpeg2encode/Makefile 2007-12-28 16:38:36.000000000 +0100 > @@ -7,7 +7,7 @@ > > PORTNAME= vtkmpeg2encode > PORTVERSION= 5.0.3 > -CATEGORIES= math > +CATEGORIES= multimedia math > MASTER_SITES= http://www.vtk.org/files/support/ \ > http://www.neuro.mcw.edu/Ports/distfiles/VTK5/ > DISTNAME= vtkmpeg2encode > @@ -15,8 +15,15 @@ > MAINTAINER= bacon@smithers.neuro.mcw.edu > COMMENT= VTK MPEG2 encoding library > > +BUILD_DEPENDS= cmake>=2.2:${PORTSDIR}/devel/cmake > + > +NO_CDROM= the MPEG2 format and all software that uses it is subject to patent restrictions > +NO_PACKAGE= ${NO_CDROM} > + > CMAKE?= ${LOCALBASE}/bin/cmake > -CMAKE_DEFS+= -DCMAKE_INSTALL_PREFIX:PATH=${PREFIX} > +CMAKE_DEFS+= -DCMAKE_INSTALL_PREFIX:PATH=${PREFIX} \ > + -DCMAKE_C_FLAGS:STRING="${CFLAGS}" \ > + -DBUILD_SHARED_LIBS:BOOL=ON > > USE_LDCONFIG= yes > > @@ -26,6 +33,7 @@ > > MPEGLIB= libvtkMPEG2Encode > > +PLIST_DIRS= include/vtk-5.0 > PLIST_FILES= lib/${MPEGLIB}.so.${PORTVERSION} \ > lib/${MPEGLIB}.so.5.0 \ > lib/${MPEGLIB}.so.5 \ > @@ -37,12 +45,10 @@ > include/vtk-5.0/vlc.h > > do-configure: > - cd ${WRKSRC} && ${CMAKE} . > + cd ${WRKSRC} && ${CMAKE} . ${CMAKE_DEFS} > > -# The CMAKE config doesn't have an option for shared libs, so we'll do > -# it manually. > post-build: > - (cd ${WRKSRC}; ${CC} -o ${MPEGLIB}.so.${PORTVERSION} -shared CMakeFiles/vtkMPEG2Encode.dir/*.o) > + ${MV} ${WRKSRC}/${MPEGLIB}.so ${WRKSRC}/${MPEGLIB}.so.${PORTVERSION} > > do-install: > ${MKDIR} ${PREFIX}/include/vtk-5.0 > @@ -61,4 +67,9 @@ > ${PREFIX}/include/vtk-5.0 > ${INSTALL_MAN} ${WRKDIR}/vtkmpeg2encode.3 ${MANPREFIX}/man/man3 > > +post-install: > + @${ECHO_MSG} > + @${CAT} ${PKGMESSAGE} > + @${ECHO_MSG} > + > .include <bsd.port.mk> > diff -urN math/vtkmpeg2encode.orig/pkg-message multimedia/vtkmpeg2encode/pkg-message > --- math/vtkmpeg2encode.orig/pkg-message 1970-01-01 01:00:00.000000000 +0100 > +++ multimedia/vtkmpeg2encode/pkg-message 2007-12-28 16:37:16.000000000 +0100 > @@ -0,0 +1,3 @@ > +The MPEG2 format and all software that uses it is subject to patent > +restrictions. Please see http://www.mpegla.com/m2/m2-agreement.cfm > +for more information. > --- vtkmpeg2encode.diff ends here --- > > Best regards, >
On Fri 28 dec 07 at 19:30:02 +0100, Jason Bacon <bacon@smithers.neuro.mcw.edu> wrote: > It all *looks* good, but does > > -DBUILD_SHARED_LIBS:BOOL=ON > > work for you? I tried that initially, and it produced a static lib > anyway, hence the workaround. Yes, it works for me, but it produces a library named libvtkMPEG2Encode.so, it's why I have added a post-build target. But if you think that it might not work under some circumstances, let's forget it... -- Th. Thomas.
No, this is the way it should be. I didn't like the workaround I had in there, but I didn't think it was worth being too idealistic about. I'm a little perplexed as to why setting BUILD_SHARED_LIBS didn't work for me when I first tried it. Maybe I left the 'S' off BUILD_SHARED_LIBS or something stupid like that. I applied your cumulative patch and built it on PC-BSD 1.3 and FreeBSD 5.4. Everything looks good. Thanks much, -J Thierry Thomas wrote: > On Fri 28 dec 07 at 19:30:02 +0100, Jason Bacon <bacon@smithers.neuro.mcw.edu> > wrote: > > >> It all *looks* good, but does >> >> -DBUILD_SHARED_LIBS:BOOL=ON >> >> work for you? I tried that initially, and it produced a static lib >> anyway, hence the workaround. >> > > Yes, it works for me, but it produces a library named > libvtkMPEG2Encode.so, it's why I have added a post-build target. > > But if you think that it might not work under some circumstances, let's > forget it... >
thierry 2008-01-09 20:08:58 UTC FreeBSD ports repository Modified files: multimedia Makefile Added files: multimedia/vtkmpeg2encode Makefile distinfo pkg-descr pkg-message multimedia/vtkmpeg2encode/files vtkmpeg2encode.3.in Log: This is the VTK MPEG2 encoder library, which has been removed from the main VTK distribution due to MPEG patent issues. This port is an optional dependency for the new vtk5 port. PR: ports/119082 Submitted by: Jason W. Bacon <bacon (at) smithers.neuro.mcw.edu> Revision Changes Path 1.249 +1 -0 ports/multimedia/Makefile 1.1 +75 -0 ports/multimedia/vtkmpeg2encode/Makefile (new) 1.1 +3 -0 ports/multimedia/vtkmpeg2encode/distinfo (new) 1.1 +50 -0 ports/multimedia/vtkmpeg2encode/files/vtkmpeg2encode.3.in (new) 1.1 +3 -0 ports/multimedia/vtkmpeg2encode/pkg-descr (new) 1.1 +3 -0 ports/multimedia/vtkmpeg2encode/pkg-message (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
thierry 2008-01-09 20:12:41 UTC FreeBSD ports repository Modified files: . LEGAL Log: Add en entry for multimedia/vtkmpeg2encode. PR: ports/119082 Submitted by: Jason Bacon <bacon (at) smithers.neuro.mcw.edu> Revision Changes Path 1.564 +4 -1 ports/LEGAL _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed New port added, thanks!
Responsible Changed From-To: freebsd-ports-bugs->thierry Take it: it is requested by PR ports/119075.
State Changed From-To: open->feedback Excepted a minor patch to fix plist and build-depends (see hereunder), I'd like to be sure that this soft can be packaged and put on a CD-ROM. Please check <http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-restrictions.html> --- vtkmpeg2encode.diff begins here --- diff -urN math/vtkmpeg2encode.orig/Makefile math/vtkmpeg2encode/Makefile --- math/vtkmpeg2encode.orig/Makefile 2007-12-28 10:12:56.000000000 +0100 +++ math/vtkmpeg2encode/Makefile 2007-12-28 11:37:50.000000000 +0100 @@ -15,6 +15,8 @@ MAINTAINER= bacon@smithers.neuro.mcw.edu COMMENT= VTK MPEG2 encoding library +BUILD_DEPENDS= cmake>=2.2:${PORTSDIR}/devel/cmake + CMAKE?= ${LOCALBASE}/bin/cmake CMAKE_DEFS+= -DCMAKE_INSTALL_PREFIX:PATH=${PREFIX} @@ -26,6 +28,7 @@ MPEGLIB= libvtkMPEG2Encode +PLIST_DIRS= include/vtk-5.0 PLIST_FILES= lib/${MPEGLIB}.so.${PORTVERSION} lib/${MPEGLIB}.so.5.0 lib/${MPEGLIB}.so.5 --- vtkmpeg2encode.diff ends here --- Best regards, -- Th. Thomas.
State Changed From-To: feedback->open Feedback received, thanks! Note: it is ready to be committed, but I shall do it together with VTK5 don't forget to answer me about Python.