Bug 119741 - mail/perdition: rc scripts have a mistype in a variable name
Summary: mail/perdition: rc scripts have a mistype in a variable name
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wesley Shields
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-17 10:40 UTC by Aleksandr Stankevic
Modified: 2008-01-25 14:40 UTC (History)
0 users

See Also:

Attachments
file.diff (2.51 KB, patch)
2008-01-17 10:40 UTC, Aleksandr Stankevic 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aleksandr Stankevic 2008-01-17 10:40:00 UTC 
mail/perdition has a mistype in rc scripts (perditon_*_flags -> perdition_*_flags). 
This makes the rc scripts not use the ${name}_flags when run on boot, but work fine when run manualy.
On boot, rc.conf is sourced first, and then variable is overwritten by perdition rc script, and when run manually - rc.conf is sources by load_rc_config.

Fix: Patch attached with submission follows:
How-To-Repeat: cd /usr/ports/mail/perdition && make install
echo 'perdition_pop3_flags="-d"' >> /etc/rc.conf
echo 'perdition_pop3_enable="YES"' >> /etc/rc.conf
reboot

After reboot the daemon will start with default flags (none), and if run manually - with -d.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-01-17 10:40:07 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 thomas 2008-01-17 12:35:52 UTC 
Looks good. Please commit it.

Regards,
Thomas Vogt

Edwin Groothuis schrieb:
> Maintainer of mail/perdition,
> 
> Please note that PR ports/119741 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> 
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/119741
>
Comment 3 Wesley Shields freebsd_committer freebsd_triage 2008-01-24 14:46:44 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->wxs

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2008-01-25 14:38:18 UTC 
wxs         2008-01-25 14:38:12 UTC

  FreeBSD ports repository

  Modified files:
    mail/perdition       Makefile 
    mail/perdition/files perdition.imap4.in perdition.imap4s.in 
                         perdition.imaps.in perdition.pop3.in 
                         perdition.pop3s.in 
  Log:
  Fix typos in RC scripts and bump PORTREVISION.
  
  PR:             ports/119741
  Submitted by:   Aleksandr Stankevic <alex@braske.net>
  Approved by:    Thomas Vogt (maintainer), garga (mentor)
  
  Revision  Changes    Path
  1.35      +1 -1      ports/mail/perdition/Makefile
  1.2       +2 -2      ports/mail/perdition/files/perdition.imap4.in
  1.2       +2 -2      ports/mail/perdition/files/perdition.imap4s.in
  1.2       +2 -2      ports/mail/perdition/files/perdition.imaps.in
  1.2       +2 -2      ports/mail/perdition/files/perdition.pop3.in
  1.2       +2 -2      ports/mail/perdition/files/perdition.pop3s.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Wesley Shields freebsd_committer freebsd_triage 2008-01-25 14:38:29 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!