Bug 120149 - [PATCH] sysutils/gkrellm2 ACPI battery support on amd64 patch
Summary: [PATCH] sysutils/gkrellm2 ACPI battery support on amd64 patch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Hajimu UMEMOTO
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-30 12:40 UTC by Sven Berkvens-Matthijsse
Modified: 2008-01-31 17:40 UTC (History)
0 users

See Also:


Attachments
file.diff (3.48 KB, patch)
2008-01-30 12:40 UTC, Sven Berkvens-Matthijsse
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Berkvens-Matthijsse 2008-01-30 12:40:03 UTC
The sysutils/gkrellm2 port works fine on amd64 machines, but has no support for the battery state on my laptop. This is because the battery code is only compiled if __i386__ is defined. But on __amd64__, the ACPI code for the battery is usable. I've modified the existing patch for freebsd.c so that it will compile a part of the battery code for __amd64__, which actually yields the correct results on my laptop.

Fix: Patch attached which is intended to replace the existing /usr/ports/sysutils/gkrellm2/files/patch-src::sysdeps::freebsd.c file.

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-01-30 12:40:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ume

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2008-01-31 17:32:23 UTC
ume         2008-01-31 17:32:17 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/gkrellm2    Makefile 
    sysutils/gkrellm2/files patch-src::sysdeps::freebsd.c 
  Log:
  - Enable battery support on amd64 using ACPI. [1]
  - Suppress compile time warnings.
  
  PR:             ports/120149 [1]
  Submitted by:   Sven Berkvens-Matthijsse <sven__at__berkvens.net> [1]
  
  Revision  Changes    Path
  1.130     +1 -1      ports/sysutils/gkrellm2/Makefile
  1.10      +121 -7    ports/sysutils/gkrellm2/files/patch-src::sysdeps::freebsd.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Hajimu UMEMOTO freebsd_committer freebsd_triage 2008-01-31 17:38:37 UTC
State Changed
From-To: open->closed

Thanks!  Committed with some modification.