- Updated to 0.12 - Fix WWW in pkg-descr Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->gabor gabor@ wants his PRs (via the GNATS Auto Assign Tool)
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
God love is hard to find. You got lucky, Edwin! will fix on this week. 2008/02/23 20:01:03 +0000 Edwin Groothuis <edwin@FreeBSD.org> => To peter@vereshagin.org : EG> Maintainer of www/p5-FCGI-Spawn, EG> Please note that PR ports/121012 has just been submitted. 73! Peter -- http://vereshagin.org
pyotr@pisem.net wrote: > Doubt on > === > -MASTER_SITE_SUBDIR= FCGI > === > but works for me. Smiley added cause clients' base is still small > enough and the production people wants more stuff about logging and > memory leaks defense in ProcManager which is the 'use base'. > > Apply please the attached 121012.diff. Thanks. Hello pyotr, MASTER_SITES= CPAN is the same that: MASTER_SITES= ${MASTER_SITE_PERL_CPAN} MASTER_SITE_SUBDIR= FCGI or: MASTER_SITES= CPAN MASTER_SITE_SUBDIR= FCGI Because this, is that line unnecessary. You want to apply your patch ONLY to insert a smile on pkg-descr? I don't see this need! :-) -- Regards, Felippe de Meirelles Motta lippemail@gmail.com
God love is hard to find. You got lucky, Felippe! 2008/02/25 13:54:13 -0300 Felippe de Meirelles Motta <lippemail@gmail.com> => To pyotr@pisem.net : FdMM> pyotr@pisem.net wrote: FdMM> >Doubt on FdMM> >=== FdMM> >-MASTER_SITE_SUBDIR= FCGI FdMM> >=== FdMM> >but works for me. Smiley added cause clients' base is still small FdMM> >enough and the production people wants more stuff about logging and FdMM> >memory leaks defense in ProcManager which is the 'use base'. FdMM> > FdMM> >Apply please the attached 121012.diff. Thanks. FdMM> Hello pyotr, FdMM> FdMM> MASTER_SITES= CPAN FdMM> FdMM> is the same that: FdMM> FdMM> MASTER_SITES= ${MASTER_SITE_PERL_CPAN} FdMM> MASTER_SITE_SUBDIR= FCGI FdMM> FdMM> or: FdMM> FdMM> MASTER_SITES= CPAN FdMM> MASTER_SITE_SUBDIR= FCGI FdMM> FdMM> Because this, is that line unnecessary. FdMM> FdMM> You want to apply your patch ONLY to insert a smile on pkg-descr? I FdMM> don't see this need! :-) ok, YMMV. But... The inspiration and the template for p5-FCGI-Spawn was the p5-FCGI-ProcManager namely, particularly concerning Makefile. So the origin of === MASTER_SITE_SUBDIR= FCGI === was the deprecated p5-FastCGI-ProcManager. Probably the old-school deprecated fashion? I conclude therefore: "You want to apply '-MASTER_SITE_SUBDIR' ONLY to save a some on p5-FCGI-Spawn? I don't see this need! :-)" We should distribute this on BOTH, the p5-FCGI-ProcManager too... I use to maintain that another stuff too, should I submit the separate PR for this? Just newbie to ports maintenance. Thanks for additional spelling on bsd.port.mk :) 73! Peter -- http://vereshagin.org
Peter Vereshagin wrote: > God love is hard to find. You got lucky, Felippe! > 2008/02/25 13:54:13 -0300 Felippe de Meirelles Motta <lippemail@gmail.com> => To pyotr@pisem.net : > FdMM> pyotr@pisem.net wrote: > FdMM> >Doubt on > FdMM> >=== > FdMM> >-MASTER_SITE_SUBDIR= FCGI > FdMM> >=== > FdMM> >but works for me. Smiley added cause clients' base is still small > FdMM> >enough and the production people wants more stuff about logging and > FdMM> >memory leaks defense in ProcManager which is the 'use base'. > FdMM> > > FdMM> >Apply please the attached 121012.diff. Thanks. > FdMM> Hello pyotr, > FdMM> > FdMM> MASTER_SITES= CPAN > FdMM> > FdMM> is the same that: > FdMM> > FdMM> MASTER_SITES= ${MASTER_SITE_PERL_CPAN} > FdMM> MASTER_SITE_SUBDIR= FCGI > FdMM> > FdMM> or: > FdMM> > FdMM> MASTER_SITES= CPAN > FdMM> MASTER_SITE_SUBDIR= FCGI > FdMM> > FdMM> Because this, is that line unnecessary. > FdMM> > FdMM> You want to apply your patch ONLY to insert a smile on pkg-descr? I > FdMM> don't see this need! :-) > > ok, YMMV. But... > The inspiration and the template for p5-FCGI-Spawn was the p5-FCGI-ProcManager namely, particularly concerning Makefile. > So the origin of > === > MASTER_SITE_SUBDIR= FCGI > === > was the deprecated p5-FastCGI-ProcManager. Probably the old-school deprecated fashion? I conclude therefore: > > "You want to apply '-MASTER_SITE_SUBDIR' ONLY to save a some on p5-FCGI-Spawn? I don't see this need! :-)" We should distribute this on BOTH, the p5-FCGI-ProcManager too... I use to maintain that another stuff too, should I submit the separate PR for this? > > Just newbie to ports maintenance. Thanks for additional spelling on bsd.port.mk :) > > 73! Peter > Okay and yes, another PR for this. But wait an new version for p5-FastCGI-ProcManager to apply these changes. If needed to help, i'm avaiable. :-) -- Regards, Felippe de Meirelles Motta lippemail@gmail.com
gabor 2008-02-26 20:04:31 UTC FreeBSD ports repository Modified files: www/p5-FCGI-Spawn Makefile distinfo pkg-descr Log: - Update to 0.12 - Fix WWW PR: ports/121012 Submitted by: Felippe de Meirelles Motta <lippemail@gmail.com> Approved by: maintainer Revision Changes Path 1.2 +1 -2 ports/www/p5-FCGI-Spawn/Makefile 1.2 +3 -3 ports/www/p5-FCGI-Spawn/distinfo 1.2 +1 -1 ports/www/p5-FCGI-Spawn/pkg-descr _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, thanks!