I have been tracking a problem with ushare when run on amd64/FreeBSD 7.0-RELEASE. Namely, when it is started with -D, it never listens on the upnp port/socket, and appears to hang in a pthread call. I filed a PR against libthr, but it turns out the solution is simply to compile ushare with -lpthread (or -pthread). This is done for other FreeBSD releases, so I am requesting that: .if ${OSVERSION} < 700042 CFLAGS+= ${PTHREAD_LIBS} .endif Be removed, so that all versions include -pthread: CFLAGS+= ${PTHREAD_LIBS} I have tested this and recompiling with the above changes fixes ushare when it is run as a daemon. Thanks! Josh Fix: The attached patch file just comments out the Patch attached with submission follows: How-To-Repeat: - build and install ushare on amd64/FreeBSD 7.0 - run ushare -D - note the lack of listening socket in sockstat -4l output
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Hello, the submitted ushare patch seems to be OK. Because of this i give it a GO. Regards Volker -------- Original-Nachricht -------- > Datum: Wed, 5 Mar 2008 05:09:02 UT > Von: Edwin Groothuis <edwin@FreeBSD.org> > An: votdev@gmx.de > Betreff: Re: ports/121378: net/ushare should link to pthread in FreeBSD 7.0+ > Maintainer of net/ushare, > > Please note that PR ports/121378 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/121378 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org -- GMX startet ShortView.de. Hier findest Du Leute mit Deinen Interessen! Jetzt dabei sein: http://www.shortview.de/?mc=sv_ext_mf@gmx
State Changed From-To: feedback->open Maintainer approved.
rafan 2008-03-08 18:35:55 UTC FreeBSD ports repository Modified files: net/ushare Makefile Log: - Link to pthread for all OS versions to fix listening socket with -D PR: ports/121378 Submitted by: Josh Carroll <josh.carroll at gmail.com> Approved by: Volker Theile" <votdev at gmx.de> (maintainer) Revision Changes Path 1.11 +1 -3 ports/net/ushare/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!