Bug 122354 - Make irc/eggdrop compile with Tcl versions other than 8.4
Summary: Make irc/eggdrop compile with Tcl versions other than 8.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Beech Rintoul
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-01 20:50 UTC by Frank
Modified: 2008-04-02 03:00 UTC (History)
0 users

See Also:

Attachments
file.diff (713 bytes, patch)
2008-04-01 20:50 UTC, Frank 		no flags Details | Diff
irc-eggdrop-systemtcl.patch (715 bytes, patch)
2008-04-01 21:19 UTC, Frank 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frank 2008-04-01 20:50:03 UTC 
Currently irc/eggdrop requires Tcl 8.4 which is wrong because eggdrop works just as good with other Tcl versions. If your system has (for example) Tcl 8.5 only, irc/eggdrop will install 8.4 instead of using 8.5. The attached patch changes the Makefile to use the bsd.tcl.mk functions to determine the newest installed Tcl version and point the eggdrop configure script to the appropriate files. I set the minimum required Tcl version to 8.0 (the smallest possible value) since the configure only requires 7.0.

I also removed the manual setting of the build target because it results in exactly the same as compared to having the ports system automatically set it. I assume, it's better to use the provided value in case of future changes.
If this was set on purpose to circumvent a problem in other environments, you should not include this change.

Fix: cd /usr/ports/irc/eggdrop && patch -p1 < patch.txt

Patch attached with submission follows:
How-To-Repeat: pkg_delete tcl84
cd /usr/ports/irc/eggdrop
make clean && make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-04-01 20:50:13 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->beech

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Frank 2008-04-01 21:19:15 UTC 
I meant to put USE_TCL=80+ into the patchfile, by accident I left the 84+ in 
it. Sorry.
Comment 3 dfilter service freebsd_committer freebsd_triage 2008-04-02 02:55:42 UTC 
beech       2008-04-02 01:55:36 UTC

  FreeBSD ports repository

  Modified files:
    irc/eggdrop          Makefile 
  Log:
  - Fix compile with Tcl versions other than 8.4
  - Bump portrevision
  
  PR:             ports/122354
  Submitted by:   Frank Fenor <frank@fenor.de>
  
  Revision  Changes    Path
  1.17      +4 -4      ports/irc/eggdrop/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Beech Rintoul freebsd_committer freebsd_triage 2008-04-02 02:55:57 UTC 
State Changed
From-To: open->closed

Committed, Thanks!