When building vim with WITH_VIM_OPTIONS and not adding *any* gui, the GNOME1 gui is added regardless. There is also no option in the vim options to set the equivalent of WITHOUT_X11. Fix: The hack below implements the correct logic. Really what's needed is 'NO_GUI' or 'WITHOUT_X11' option in the vim options. How-To-Repeat: Set WITH_VIM_OPTIONS in /etc/make.conf, type make config in /usr/ports/editors/vim, do not check any GUI, including the one advertized as GNOME1, then type make -V LIB_DEPENDS to see that gtk-1 dep has been added. Here's the current /var/db/ports/vim/options that demonstrates the case: # This file is auto-generated by 'make config'. # No user-servicable parts inside! # Options for vim-7.1.242 _OPTIONS_READ=vim-7.1.242 WITH_PERL=true WITHOUT_PYTHON=true WITHOUT_RUBY=true WITH_CSCOPE=true WITHOUT_EXUBERANT_CTAGS=true WITHOUT_ATHENA=true WITHOUT_GTK2=true WITHOUT_GNOME=true WITHOUT_MOTIF=true WITHOUT_XTERM_SAVE=true
Responsible Changed From-To: freebsd-ports-bugs->obrien Over to maintainer (via the GNATS Auto Assign Tool)
State Changed From-To: open->feedback sent counter-patch
Counter patch works as expected. Of course, it requires people to read and not just "check GTK2", but that's perfectly fine with me ;) -- Mel
State Changed From-To: feedback->open From misfiled PR ports/123272: Date: Wed, 30 Apr 2008 10:45:25 -0700
On Wed, Apr 30, 2008 at 09:33:59PM +0200, Mel wrote: > Counter patch works as expected. Of course, it requires people to read > and not just "check GTK2", but that's perfectly fine with me ;) If you think it should default on "ON" that would be OK with me.
obrien 2008-05-01 15:37:57 UTC FreeBSD ports repository Modified files: editors/vim options Log: If one wanted to build a GUI-less, one got stuck with GNOME1 anyway. So add the "X11" knob so 'WITHOUT_X11' will properly get set. PR: 123257, 123272 Reported by: Mel <mel@rachie.is-a-geek.net> Revision Changes Path 1.2 +1 -0 ports/editors/vim/options _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed committed