Bug 123406 - [PATCH] x11-wm/kompmgr depends on various xorg libs
Summary: [PATCH] x11-wm/kompmgr depends on various xorg libs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-04 21:10 UTC by Mel
Modified: 2008-08-01 13:30 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (275 bytes, patch)
2008-05-04 21:10 UTC, Mel
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mel 2008-05-04 21:10:03 UTC
Xorg deps are not recorded for mentioned port, failing mostly on Xcomposite, since that's
the one that's not available by the time it gets compiled.

Fix: The patch for rev 1.19 of the port's Makefile suggest use of USE_XORG but since I find
no mention of that var in the port's Makefile, Makefile.kde or bsd.kde.mk, I patched
it in the port's makefile.
How-To-Repeat: Build kompmgr or something that depends on it, in x/kde free environment
Below is a condensed log of installing audio/amarok in a mostly clean environment, with:
make -DBATCH -DUSE_PACKAGE_DEPENDS install

Mostly clean means:
shells/bash
devel/cscope
ftp/curl
devel/gettext
converters/libiconv
devel/libtool15
lang/perl5.8
editors/vim
ports-mgmt/portaudit
devel/gmake

were the only ports installed before starting this.

===>  Found saved configuration for amarok-1.4.8_3
===>  Extracting for amarok-1.4.8_3
=> MD5 Checksum OK for amarok-1.4.8.tar.bz2.
=> SHA256 Checksum OK for amarok-1.4.8.tar.bz2.
===>   amarok-1.4.8_3 depends on file: /usr/local/bin/ruby18 - not found

<cut to end of kdebase build>

/bin/sh /usr/local/bin/libtool --silent --tag=CC   --mode=link cc  -DNDEBUG -O2  -O2 -fno-strict-aliasing -pipe  -D_GNU_SOURCE  -rpath=/usr/lib:/usr/local/lib -o kdmctl kdmctl.o  -Wl,-export-dynamic -L/usr/local/lib -ljpeg  -L/usr/local/lib
gmake[4]: Leaving directory `/usr/obj/usr/ports/x11/kdebase3/work/kdebase-3.5.8/kdm/kfrontend'
gmake[3]: Leaving directory `/usr/obj/usr/ports/x11/kdebase3/work/kdebase-3.5.8/kdm/kfrontend'
gmake[2]: Leaving directory `/usr/obj/usr/ports/x11/kdebase3/work/kdebase-3.5.8/kdm'
gmake[2]: Entering directory `/usr/obj/usr/ports/x11/kdebase3/work/kdebase-3.5.8'
gmake[2]: Nothing to be done for `all-am'.
gmake[2]: Leaving directory `/usr/obj/usr/ports/x11/kdebase3/work/kdebase-3.5.8'
gmake[1]: Leaving directory `/usr/obj/usr/ports/x11/kdebase3/work/kdebase-3.5.8'
===>  Installing for kdebase-3.5.8_1
===>   kdebase-3.5.8_1 depends on file: /usr/local/env/xdg-env.sh - not found
===>    Verifying install for /usr/local/env/xdg-env.sh in /usr/ports/misc/kde-xdg-env
===>  Extracting for kde-xdg-env-1.0_3,1
===>  Patching for kde-xdg-env-1.0_3,1
===>  Configuring for kde-xdg-env-1.0_3,1
===>  Installing for kde-xdg-env-1.0_3,1
===>   Generating temporary packing list
===>  Checking if misc/kde-xdg-env already installed
/bin/mkdir -p /usr/local/env
install  -o root -g wheel -m 555 /usr/obj/usr/ports/misc/kde-xdg-env/work/xdg-env.sh /usr/local/env
===>   Registering installation for kde-xdg-env-1.0_3,1
===>   Returning to build of kdebase-3.5.8_1
===>   kdebase-3.5.8_1 depends on file: /usr/local/bin/moc - found
===>   kdebase-3.5.8_1 depends on executable: kompmgr - not found
===>    Verifying install for kompmgr in /usr/ports/x11-wm/kompmgr
===>  Extracting for kdebase-kompmgr-3.5.8
=> MD5 Checksum OK for KDE/kdebase-3.5.8.tar.bz2.
=> SHA256 Checksum OK for KDE/kdebase-3.5.8.tar.bz2.
===>  Patching for kdebase-kompmgr-3.5.8
===>   kdebase-kompmgr-3.5.8 depends on file: /usr/local/bin/moc - found
===>   kdebase-kompmgr-3.5.8 depends on shared library: kimproxy - found
===>  Configuring for kdebase-kompmgr-3.5.8
===>  Building for kdebase-kompmgr-3.5.8
cd /usr/obj/usr/ports/x11-wm/kompmgr/work/kdebase-3.5.8/kwin/kompmgr &&  cc -O2 -fno-strict-aliasing -pipe  -I/usr/local/include -L/usr/local/lib -lX11 -lXdamage -lXfixes -lXrender -lXcomposite -lm -o kompmgr kompmgr.c
kompmgr.c:48:39: error: X11/extensions/Xcomposite.h: No such file or directory
kompmgr.c: In function 'error':
kompmgr.c:2168: error: 'X_CompositeRedirectSubwindows' undeclared (first use in this function)
kompmgr.c:2168: error: (Each undeclared identifier is reported only once
kompmgr.c:2168: error: for each function it appears in.)
kompmgr.c: In function 'main':
kompmgr.c:2629: error: 'COMPOSITE_NAME' undeclared (first use in this function)
kompmgr.c:2697: error: 'CompositeRedirectAutomatic' undeclared (first use in this function)
kompmgr.c:2701: error: 'CompositeRedirectManual' undeclared (first use in this function)
*** Error code 1

Stop in /usr/ports/x11-wm/kompmgr.
*** Error code 1

Stop in /usr/ports/x11/kdebase3.
*** Error code 1

Stop in /usr/ports/audio/amarok.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-05-04 21:10:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->kde

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Mel 2008-05-04 22:03:22 UTC
Just found a similar one in kdebase, after this got patched and I saw that the 
package for kdebase had tar errors.

x11/kdebase3 needs xkb or kxkb will not be built, leading to plist problems.

Seperate PR or merge with this?
-- 
Mel
Comment 3 Mel 2008-05-08 20:08:01 UTC
Just finished a full kde3 metaport build, with exception of kdeaccessibility.

The following patches were needed to finish the build:
# cat /root/patches/ports/patch-*\:\:k*
--- net/kdenetwork3/Makefile.orig       2008-02-22 01:22:52.000000000 -0900
+++ net/kdenetwork3/Makefile    2008-05-08 00:40:34.000000000 -0800
@@ -30,6 +30,7 @@

 USE_AUTOTOOLS=  libtool:15
 USE_LDCONFIG=  yes
+USE_XORG=      xtst
 LDCONFIG_DIRS+=        %%PREFIX%%/lib %%PREFIX%%/lib/kde3
 DO_NOT_COMPILE+=kopete lanbrowsing filesharing

--- x11-wm/kompmgr/Makefile.orig        2008-04-28 15:31:30.000000000 -0800
+++ x11-wm/kompmgr/Makefile     2008-05-04 11:32:01.000000000 -0800
@@ -19,6 +19,7 @@

 USE_KDELIBS_VER=3
 PREFIX=                ${KDE_PREFIX}
+USE_XORG=      x11 xdamage xrender xcomposite xfixes

 USE_BZIP2=     yes
 WRKSRC=                ${WRKDIR}/kdebase-${PORTVERSION}
--- x11/kdebase3/Makefile.orig  2008-04-28 15:31:20.000000000 -0800
+++ x11/kdebase3/Makefile       2008-05-05 01:19:14.000000000 -0800
@@ -33,7 +33,7 @@

 USE_BZIP2=     yes
 USE_GMAKE=     yes
-USE_XORG=      xpm
+USE_XORG=      xpm xkbfile xrandr xcursor
 SUB_FILES=     kdm pkg-deinstall pkg-install pkg-message
 PKGMESSAGE=    ${WRKDIR}/pkg-message
 PKGINSTALL=    ${WRKDIR}/pkg-install


-- 
Mel
Comment 4 Martin Wilke freebsd_committer freebsd_triage 2008-08-01 10:06:27 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 5 Tilman Keskinoz freebsd_committer freebsd_triage 2008-08-01 11:08:36 UTC
State Changed
From-To: closed->patched

reopen, the follow up contains patches against kdebase3 and kdenetwork3 
that have not been committed. (See also 126130)
Comment 6 dfilter service freebsd_committer freebsd_triage 2008-08-01 13:07:31 UTC
arved       2008-08-01 12:07:10 UTC

  FreeBSD ports repository

  Modified files:
    x11/kdebase3         Makefile 
  Log:
  Add missing dependencies on xorg libraries
  
  PR:             123406, 126130
  Submitted by:   Mel <mel@rachie.is-a-.geek.net>
  Reported by:    Gergely Czuczy
  
  Revision  Changes    Path
  1.207     +2 -2      ports/x11/kdebase3/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 dfilter service freebsd_committer freebsd_triage 2008-08-01 13:28:19 UTC
arved       2008-08-01 12:28:05 UTC

  FreeBSD ports repository

  Modified files:
    net/kdenetwork3      Makefile 
  Log:
  Add missing dependency on libXtst
  
  PR:             123406
  Submitted by:   Mel <mel.zyzzy@rachie.is-a-geek.net>
  Reported by:    Gergely Czuczy
  
  Revision  Changes    Path
  1.131     +2 -0      ports/net/kdenetwork3/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Tilman Keskinoz freebsd_committer freebsd_triage 2008-08-01 13:29:01 UTC
State Changed
From-To: patched->closed

Now everything is committed, thanks