The options dialog lets you ask for iconv support to be disabled, but just adding --disable-iconv isn't enough. That simply disables rsync's --iconv flag but still allows libiconv to be linked into the binary... Fix: Set the appropriate autoconf cache variables so that rsync's configure script completely skips iconv detection, even if it's present on the system. As a bonus, no post-configure fixup is needed: How-To-Repeat: Install libiconv, uncheck "Add iconv support" in the rsync options screen, build rsync. The link stage will fail with: rsync.o(.text+0xffe): In function `iconvbufs': : undefined reference to `libiconv' rsync.o(.text+0x1132): In function `iconvbufs': : undefined reference to `libiconv' rsync.o(.text+0x11b8): In function `setup_iconv': : undefined reference to `locale_charset' rsync.o(.text+0x11de): In function `setup_iconv': : undefined reference to `libiconv_open' *** Error code 1
Responsible Changed From-To: freebsd-ports-bugs->ehaupt Over to maintainer (via the GNATS Auto Assign Tool)
ehaupt 2008-05-07 12:32:17 UTC FreeBSD ports repository Modified files: net/rsync Makefile Log: Rework WITHOUT_ICONV build option PR: 123469 Submitted by: Dan Nelson <dnelson@allantgroup.com> Revision Changes Path 1.132 +3 -6 ports/net/rsync/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Even though I wasn't able to reproduce the linker error this is a much nicer approach to work arround the w/o iconv issue. Committed, thanks!