It seems, bsd.port.mk have problems with USE_OPENLDAP=yes when openldap 2.4 is installed ;-) Because of many USE_XXX auto-detect installed version and the associated port, USE_OPENLDAP with this patch is one of them ;) Fix: Patch attached with submission follows: How-To-Repeat: Install openldap-client-2.4 Install Samba or PHP with LDAP
Hi all, I clicked in the web-interface to the wrong category - i meant ports@. Maybe someone (portmgr@?) may correct it? Thanks, Jens
Responsible Changed From-To: freebsd-bugs->freebsd-ports-bugs reassign to ports team
Responsible Changed From-To: freebsd-ports-bugs->delphij Over to maintainer.
Responsible Changed From-To: delphij->portmgr Looks good in principal. To portmgr@, I think we should apply this patch for an experimental build and see if anything would show up, I will get back with Internet access on Jun 16th PDT and handle new "event"s.
Hi, I tried a little around with the submitted patch and detected 2 issues: 1) I had a typo in line 37 of bsd.ldap.mk -DEFAULT_OPENLDPAP_VER?= 23 +DEFAULT_OPENLDAP_VER?= 23 It's quite easy to fix it ;) 2) A port (security/seahorse) checks in line 72 for ${WANT_OPENLDAP_VER}, which is deprecated. By the way - it doesn't want to check for WANT_OPENLDAP_VER, it wants to check for ${OPENLDAP_VER}. Doing this would require to split the "code" in bsd.ldap.mk into a pre- and post-part, not handle everything in the post-part. What do you think? /Jens
On Sun, 2008-06-22 at 15:24 +0000, Jens Rehsack wrote: > Hi, > > I tried a little around with the submitted patch and detected 2 issues: > 1) I had a typo in line 37 of bsd.ldap.mk > -DEFAULT_OPENLDPAP_VER?= 23 > +DEFAULT_OPENLDAP_VER?= 23 > It's quite easy to fix it ;) > > 2) A port (security/seahorse) checks in line 72 for ${WANT_OPENLDAP_VER}, > which is deprecated. By the way - it doesn't want to check for > WANT_OPENLDAP_VER, it wants to check for ${OPENLDAP_VER}. > Doing this would require to split the "code" in bsd.ldap.mk into a > pre- and post-part, not handle everything in the post-part. > > What do you think? I've been away for a week and a half. Has anything come of this? I have no objection to making seahorse more flexible in terms of LDAP support if the underlying code supports it. Joe -- PGP Key : http://www.marcuscom.com/pgp.asc
I used a little spare time and fixed up the typo and the issue with security/seahorse (full patch attached) because the new commit of delphij@ brokes my patch of bsd.port.mk ;) Because no openldap-2.2 is supported anymore by ports/, I removed the version comparisation from security/seahorse/Makefile. @Joe: I searched in Seahorse-Bugzilla for ldap related entries but couldn't find anything. Maybe someone who has this running may try without setting this compile-option to see, if it's really necessary. As far as I understood, this define enables deprecated ldap functions and has been added to the port with seahorse 1.0.1 - now we have 2.22 or similar ... /Jens
pav 2008-07-21 22:29:22 UTC FreeBSD ports repository Modified files: Mk bsd.port.mk dns/bind9-dlz Makefile mail/postfix1 Makefile security/seahorse Makefile Added files: Mk bsd.ldap.mk Log: - Separate OpenLDAP related code into bsd.ldap.mk - Change default OpenLDAP version to 2.4 - Remove OpenLDAP 2.2 support, the port has been gone for some time now - Add -DDEPRECATED to CFLAGS for all OpenLDAP using ports PR: ports/123602, ports/124115, ports/125605 Submitted by: delphij, Jens Rehsack <rehsack@web.de>, Yuri Pankov <yuri.pankov@gmail.com> - Remove USE_GTK, it's no longer used PR: ports/123528 Submitted by: mezz - Use PATCH_WRKSRC instead of WRKSRC in do-patch target PR: ports/124169 Submitted by: Max Brazhnikov <makc@issp.ac.ru> - Remove USE_XPM, it's been replaced by USE_XORG+=xpm PR: ports/124506 Submitted by: Alex Kozlov <spam@rm-rf.kiev.ua> - Minor fixups for bsd.port.mk PR: ports/122675 Submitted by: linimon - Remove stale comment about USE_GETOPT_LONG PR: ports/124521 Submitted by: Alex Kozlov <spam@rm-rf.kiev.ua> - Correct comment about default fetch arguments PR: ports/125334 Submitted by: Gary Palmer <freebsd-gnats@in-addr.com> Revision Changes Path 1.1 +95 -0 ports/Mk/bsd.ldap.mk (new) 1.598 +15 -39 ports/Mk/bsd.port.mk 1.46 +1 -1 ports/dns/bind9-dlz/Makefile 1.93 +0 -3 ports/mail/postfix1/Makefile 1.71 +0 -3 ports/security/seahorse/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, thanks!