Bug 124122 - [PATCH] security/barnyard: [SUMMARIZE CHANGES]
Summary: [PATCH] security/barnyard: [SUMMARIZE CHANGES]
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-30 08:10 UTC by shuyaan
Modified: 2008-06-21 13:40 UTC (History)
1 user (show)

See Also:


Attachments
file.dat (3.74 KB, application/pkcs7-signature)
2008-06-03 04:38 UTC, pauls
no flags Details
patch-Makefile (237 bytes, application/octet-stream)
2008-06-03 04:58 UTC, pauls
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description shuyaan 2008-05-30 08:10:01 UTC
[DESCRIBE CHANGES]

Port maintainer (pauls@utdallas.edu) is cc'd.

Generated with FreeBSD Port Tools 0.77

Fix: 

-- 
Akiko Narita <shuyaan@gmail.com>--xHG1dOg9ZpulqOb0yFpPhF1t069IgiobN5P1ZtXNvTopnhBo
Content-Type: text/plain; name="barnyard-0.2.0_4.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="barnyard-0.2.0_4.patch"

diff -ruN --exclude=CVS /usr/ports/security/barnyard/files/barnyard.sh.in /home/autsumi/ports/security/barnyard/files/barnyard.sh.in
--- /usr/ports/security/barnyard/files/barnyard.sh.in	2008-05-26 13:24:20.000000000 +0900
+++ /home/autsumi/ports/security/barnyard/files/barnyard.sh.in	2008-05-30 14:25:58.000000000 +0900
@@ -50,6 +50,6 @@
 : ${barnyard_flags="-D"}
 
 command="%%PREFIX%%/bin/barnyard"
-command_args="-c ${barnyard_conf} ${barnyard_flags}"
+command_args="-c ${barnyard_conf}"
 
 run_rc_command "$1"
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-05-30 08:10:08 UTC
Maintainer of security/barnyard,

Please note that PR ports/124122 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124122

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-05-30 08:10:09 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 pauls 2008-05-30 16:15:13 UTC
--On Friday, May 30, 2008 07:10:08 +0000 Edwin Groothuis <edwin@FreeBSD.org> 
wrote:

> Maintainer of security/barnyard,
>
> Please note that PR ports/124122 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124122

I don't know what the desire is for the submission of this patch, but barnyard 
won't even run without the correct flags, so the patch doesn't make any sense 
to me.

If the original submitter (whom I'm ccing) can describe what he's trying to 
accomplish or what problem he's trying to solve, I can work with him to figure 
out a solution.

-- 
Paul Schmehl (pauls@utdallas.edu)
Senior Information Security Analyst
The University of Texas at Dallas
http://www.utdallas.edu/ir/security/
Comment 4 shuyaan 2008-05-31 13:35:31 UTC
> I don't know what the desire is for the submission of this patch, but barnyard won't even run without the correct flags, so the patch doesn't make any sense to me.

Hello Paul,

Sorry, I forgot to describe the problem I'm trying to solve.

I've used barnyard-sguil-0.2.0_4.
When I started up barnyard-sguil, barnyard loaded 'barnyard_flags'
redundantly(/usr/local/etc/rc.d/barnyard and /etc/rc.conf) and it
couldn't start up.
I think that you don't need to specify 'barnyard_flags' in
rc.d/barnyard. '*_flags' is usually set in /etc/rc.conf, isn't it?

Best regards,

Akiko Narita <shuyaan@gmail.com>
Comment 5 pauls 2008-05-31 14:43:27 UTC
--On May 31, 2008 9:35:31 PM +0900 Akiko Narita <shuyaan@gmail.com> wrote:

>> I don't know what the desire is for the submission of this patch, but
>> barnyard won't even run without the correct flags, so the patch doesn't
>> make any sense to me.
>
> Hello Paul,
>
> Sorry, I forgot to describe the problem I'm trying to solve.
>
> I've used barnyard-sguil-0.2.0_4.
> When I started up barnyard-sguil, barnyard loaded 'barnyard_flags'
> redundantly(/usr/local/etc/rc.d/barnyard and /etc/rc.conf) and it
> couldn't start up.
> I think that you don't need to specify 'barnyard_flags' in
> rc.d/barnyard. '*_flags' is usually set in /etc/rc.conf, isn't it?
>

Barnyard_flags must be defined in the startup script or its values in 
rc.conf will be ignored.  However, I may have made a mistake in the 
startup file that is causing the inclusion of both.  I'll investigate.

Paul Schmehl (pauls@utdallas.edu)
Senior Information Security Analyst
The University of Texas at Dallas
http://www.utdallas.edu/ir/security/
Comment 6 pauls 2008-06-03 04:58:57 UTC
--On May 31, 2008 9:35:31 PM +0900 Akiko Narita <shuyaan@gmail.com> wrote:

Attaching the patch without my digital sig screwing things up.

Paul Schmehl (pauls@utdallas.edu)
Senior Information Security Analyst
The University of Texas at Dallas
http://www.utdallas.edu/ir/security/
Comment 7 Felippe de Meirelles Motta freebsd_committer freebsd_triage 2008-06-19 06:51:43 UTC
Hi Paul,

Can you resend the full patch ?

Thanks!

-- 
lippe@FreeBSD.org
Felippe de Meirelles Motta
Comment 8 pauls 2008-06-21 04:15:04 UTC
--On June 19, 2008 2:51:43 AM -0300 Felippe de Meirelles Motta 
<lippe@FreeBSD.org> wrote:

> Hi Paul,
>
> Can you resend the full patch ?
>
> Thanks!

Sure.

--- patch-Makefile begins here ---
--- Makefile.orig       2008-06-02 22:20:57.000000000 -0500
+++ Makefile    2008-06-02 22:21:11.000000000 -0500
@@ -7,7 +7,7 @@

 PORTNAME=      barnyard
 PORTVERSION=   0.2.0
-PORTREVISION=  4
+PORTREVISION=  5
 CATEGORIES=    security
 MASTER_SITES=  SF

--- patch-Makefile ends here ---

--- patch-files-barnyard.sh.in begins here ---
--- files/barnyard.sh.in.orig   2008-06-02 20:40:16.000000000 -0500
+++ files/barnyard.sh.in        2008-06-02 22:16:37.000000000 -0500
@@ -50,6 +50,6 @@
 : ${barnyard_flags="-D"}

 command="%%PREFIX%%/bin/barnyard"
-command_args="-c ${barnyard_conf} ${barnyard_flags}"
+command_args="-c ${barnyard_conf}"

 run_rc_command "$1"
--- patch-files-barnyard.sh.in ends here ---

Paul Schmehl (pauls@utdallas.edu)
Senior Information Security Analyst
The University of Texas at Dallas
http://www.utdallas.edu/ir/security/
Comment 9 dfilter service freebsd_committer freebsd_triage 2008-06-21 13:30:39 UTC
miwi        2008-06-21 12:30:35 UTC

  FreeBSD ports repository

  Modified files:
    security/barnyard    Makefile 
    security/barnyard/files barnyard.sh.in 
  Log:
  - Fix start script
  
  PR:             124122
  Submitted by:   shuyaan@gmail.com
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.12      +1 -1      ports/security/barnyard/Makefile
  1.4       +1 -1      ports/security/barnyard/files/barnyard.sh.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 10 Martin Wilke freebsd_committer freebsd_triage 2008-06-21 13:30:48 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!