Bug 124834 - editors/leafpad works with GCC 4.2.1 on 7-STABLE
Summary: editors/leafpad works with GCC 4.2.1 on 7-STABLE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rong-En Fan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-21 16:00 UTC by Jan Sebosik
Modified: 2008-06-22 12:10 UTC (History)
0 users

See Also:


Attachments
file.diff (347 bytes, patch)
2008-06-21 16:00 UTC, Jan Sebosik
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Sebosik 2008-06-21 16:00:11 UTC
Today I`ve succesfully compiled editors/leafpad with gcc 4.2.1 which is
in base system. But in Makefile is forced USE_GCC=3.4, which is not required.

So I think we should remove this line from /usr/ports/editor/leafpad/Makefile.

How-To-Repeat: just compile leafpad with commented (or removed) USE_GCC flag on FreeBSD 7
and newer (FreeBSD 6 uses GCC 3 by default)
Comment 1 Felippe de Meirelles Motta freebsd_committer freebsd_triage 2008-06-21 17:56:44 UTC
State Changed
From-To: open->feedback

Ask for maintainer approval.
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-06-22 00:46:50 UTC
Maintainer of editors/leafpad,

Please note that PR ports/124834 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124834

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2008-06-22 00:55:34 UTC
Maintainer of editors/leafpad,

Please note that PR ports/124834 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124834

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 4 Rong-En Fan freebsd_committer freebsd_triage 2008-06-22 07:15:19 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rafan

I'll take it.
Comment 5 Radek Kozlowski 2008-06-22 11:21:48 UTC
On Jun 22, 2008, at 1:55 AM, Edwin Groothuis wrote:

> Maintainer of editors/leafpad,
>
> Please note that PR ports/124834 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124834

Approved.

Radek
Comment 6 dfilter service freebsd_committer freebsd_triage 2008-06-22 12:02:10 UTC
rafan       2008-06-22 11:02:03 UTC

  FreeBSD ports repository

  Modified files:
    editors/leafpad      Makefile 
  Log:
  - This port builds fine with gcc 3 and 4. Remove USE_GCC line.
  - Bump PORTREVISION
  
  PR:             ports/124834
  Submitted by:   Jan Sebosik <sebosik at demax.sk>
  Approved by:    RadosÅaw KozÅowski <radek at raadradd.com> (maintainer)
  
  Revision  Changes    Path
  1.31      +1 -2      ports/editors/leafpad/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Rong-En Fan freebsd_committer freebsd_triage 2008-06-22 12:02:12 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!