This is an update of multimedia/avidemux2 port to the 2.4.2 version. Almost whole Makefile is rewritten, base on the work of Yar Odin <yarodin@gmail.com>.
Maintainer of multimedia/avidemux2, Please note that PR ports/125508 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/125508 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Responsible Changed From-To: freebsd-ports-bugs->timur I'll take it
I've tweaked the changes a bit. http://am-productions.biz/docs/avidemux2-2.4.2.tgz http://am-productions.biz/docs/avidemux2-2.4.2.patch -- Anish Mistry amistry@am-productions.biz AM Productions http://am-productions.biz/
Hi, Anish! I've looked at the changes and have couple of questions. What's the reason for bringing: QString appdir = QCoreApplication::applicationDirPath() + "/i18n/"; back in avidemux/ADM_userInterfaces/ADM_QT4/ui_support.cpp? appdir doesn't appear anywhere else, and was used solely in two lines below, which are tweaked to contain string constants instead. Seems, for the rest of the patches you just removed ^M at the end of the strings, which isn't a good option, unless you do the same for the whole files in post-patch. Mixing \xa and \xa\xd terminated strings in one file together is asking for troubles. That's why I left ^M in the patches. In general, I assume that you approve the update with minor modifications from your side? Please, clarify last two questions and I'll commit the port then. With best regards, Timur. On Mon, Jul 14, 2008 at 5:38 AM, Anish Mistry <amistry@am-productions.biz> wrote: > I've tweaked the changes a bit. > > http://am-productions.biz/docs/avidemux2-2.4.2.tgz > http://am-productions.biz/docs/avidemux2-2.4.2.patch > > -- > Anish Mistry > amistry@am-productions.biz > AM Productions http://am-productions.biz/ >
On Monday 14 July 2008, you wrote: > Hi, Anish! > > I've looked at the changes and have couple of questions. > > What's the reason for bringing: > > QString appdir = QCoreApplication::applicationDirPath() + "/i18n/"; > > back in avidemux/ADM_userInterfaces/ADM_QT4/ui_support.cpp? appdir > doesn't appear anywhere else, and was used solely in two lines > below, which are tweaked to contain string constants instead. Not sure, I was just trying to get it to patch up correctly. Removing that patch seems fine. > > Seems, for the rest of the patches you just removed ^M at the end > of the strings, which isn't a good option, unless you do the same > for the whole files in post-patch. Mixing \xa and \xa\xd terminated > strings in one file together is asking for troubles. That's why I > left ^M in the patches. I was getting failures during patching. > > In general, I assume that you approve the update with minor > modifications from your side? Yes. > > Please, clarify last two questions and I'll commit the port then. Thanks. > > With best regards, > Timur. > On Mon, Jul 14, 2008 at 5:38 AM, Anish Mistry > > <amistry@am-productions.biz> wrote: > > I've tweaked the changes a bit. > > > > http://am-productions.biz/docs/avidemux2-2.4.2.tgz > > http://am-productions.biz/docs/avidemux2-2.4.2.patch > > > > -- > > Anish Mistry > > amistry@am-productions.biz > > AM Productions http://am-productions.biz/ -- Anish Mistry amistry@am-productions.biz AM Productions http://am-productions.biz/
timur 2008-07-15 02:53:29 UTC FreeBSD ports repository Modified files: multimedia/avidemux2 Makefile distinfo pkg-descr pkg-plist Added files: multimedia/avidemux2/files avidemux2.desktop.in execinfo.cpp patch-CMakeLists.txt patch-ConfigureChecks.cmake patch-avidemux__ADM_encoder__adm_encx264.cpp patch-avidemux__ADM_libraries__ADM_lavformat__ADM_lavformat.cpp patch-avidemux__ADM_userInterfaces__ADM_QT4__ui_support.cpp patch-cmake__Ts.cmake patch-cmake__conf_summary.cmake patch-po__CMakeLists.txt Removed files: multimedia/avidemux2/files patch-avidemux_ADM_lavformat_ADM_lavformat.cpp Log: Upgrade avidemux2 to the 2.4.2 version and switch to CMake PR: ports/125508 Submitted by: timur@FreeBSD.org Approved by: amistry@am-productions.biz (maintainer) Revision Changes Path 1.52 +179 -67 ports/multimedia/avidemux2/Makefile 1.18 +3 -3 ports/multimedia/avidemux2/distinfo 1.1 +12 -0 ports/multimedia/avidemux2/files/avidemux2.desktop.in (new) 1.1 +37 -0 ports/multimedia/avidemux2/files/execinfo.cpp (new) 1.1 +27 -0 ports/multimedia/avidemux2/files/patch-CMakeLists.txt (new) 1.1 +79 -0 ports/multimedia/avidemux2/files/patch-ConfigureChecks.cmake (new) 1.2 +0 -28 ports/multimedia/avidemux2/files/patch-avidemux_ADM_lavformat_ADM_lavformat.cpp (dead) 1.1 +10 -0 ports/multimedia/avidemux2/files/patch-avidemux__ADM_encoder__adm_encx264.cpp (new) 1.1 +14 -0 ports/multimedia/avidemux2/files/patch-avidemux__ADM_libraries__ADM_lavformat__ADM_lavformat.cpp (new) 1.1 +15 -0 ports/multimedia/avidemux2/files/patch-avidemux__ADM_userInterfaces__ADM_QT4__ui_support.cpp (new) 1.1 +29 -0 ports/multimedia/avidemux2/files/patch-cmake__Ts.cmake (new) 1.1 +27 -0 ports/multimedia/avidemux2/files/patch-cmake__conf_summary.cmake (new) 1.1 +15 -0 ports/multimedia/avidemux2/files/patch-po__CMakeLists.txt (new) 1.4 +4 -4 ports/multimedia/avidemux2/pkg-descr 1.8 +31 -8 ports/multimedia/avidemux2/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, with minor changes. Thanks!