This port fails its compilation on 8-current. To solve the problem, it is necessary to include sys/priv.h (see suser(9)). The same warning is also generated on 7.0-RELEASE, though the compilation is completed. So we have to include the header file on RELENG_7 and the later branch. This port has been marked as BROKEN on 8-current for 6 months. If that decision was done with this problem, the mark should be removed. Fix: I've tested the patch on 8-current and 7.0-RELEASE with my lucent winmodem, and it works well. How-To-Repeat: capricorn# cd /opt/ports/comms/ltmdm capricorn# make TRYBROKEN=yes WRKDIRPREFIX=/tmp ===> Vulnerability check disabled, database not found Trying build of ltmdm-1.4_19 even though it is marked BROKEN. ************************************************* If your ISP supports K56flex protocol only and doesn't support V90, define WITH_595_OBJ. Otheriwse your modem will not connect ************************************************* ===> Extracting for ltmdm-1.4_19 => MD5 Checksum OK for ltmdm-1.4.tgz. => SHA256 Checksum OK for ltmdm-1.4.tgz. ===> Patching for ltmdm-1.4_19 ===> Applying FreeBSD patches for ltmdm-1.4_19 ===> Configuring for ltmdm-1.4_19 ===> Building for ltmdm-1.4_19 Warning: Object directory not changed from original /tmp/opt/ports/comms/ltmdm/work/sys/modules/ltmdm @ -> /FreeBSD/HEAD/src/sys machine -> /FreeBSD/HEAD/src/sys/i386/include awk -f @/tools/makeobjops.awk @/kern/bus_if.m -h awk -f @/tools/makeobjops.awk @/dev/pci/pci_if.m -h awk -f @/tools/makeobjops.awk @/kern/device_if.m -h uudecode -p </tmp/opt/ports/comms/ltmdm/work/sys/modules/ltmdm/../../dev/ltmdm/ltmdmobj-600.o.uu >ltmdmobj.o cc -O2 -pipe -fno-strict-aliasing -DLTMDMOBJ_VERSION=600 -DCDEV_MAJOR=228 -Werror -D_KERNEL -DKLD_MODULE -std=c99 -nostdinc -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -fstack-protector -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -c /tmp/opt/ports/comms/ltmdm/work/sys/modules/ltmdm/../../dev/ltmdm/ltmdmsio.c cc1: warnings being treated as errors /tmp/opt/ports/comms/ltmdm/work/sys/modules/ltmdm/../../dev/ltmdm/ltmdmsio.c: In function 'sioopen': /tmp/opt/ports/comms/ltmdm/work/sys/modules/ltmdm/../../dev/ltmdm/ltmdmsio.c:1621: warning: implicit declaration of function 'suser' /tmp/opt/ports/comms/ltmdm/work/sys/modules/ltmdm/../../dev/ltmdm/ltmdmsio.c:1621: warning: nested extern declaration of 'suser' *** Error code 1 Stop in /tmp/opt/ports/comms/ltmdm/work/sys/modules/ltmdm. *** Error code 1 Stop in /opt/ports/comms/ltmdm. capricorn#
State Changed From-To: open->closed Committed, thanks!
pav 2008-07-24 13:21:30 UTC FreeBSD ports repository Modified files: comms/ltmdm Makefile comms/ltmdm/files patch-sys-dev-ltmdm-ltmdmsio.c Log: - Unbreak on -CURRENT PR: ports/125863 Submitted by: WATANABE Kazuhiro <CQG00620@nifty.ne.jp> Revision Changes Path 1.37 +1 -7 ports/comms/ltmdm/Makefile 1.11 +54 -46 ports/comms/ltmdm/files/patch-sys-dev-ltmdm-ltmdmsio.c _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"