Bug 126081 - lang/squeak port fetch cleanup
Summary: lang/squeak port fetch cleanup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-29 23:00 UTC by Pedro F. Giffuni
Modified: 2008-08-01 13:40 UTC (History)
0 users

See Also:


Attachments
file.diff (2.20 KB, patch)
2008-07-29 23:00 UTC, Pedro F. Giffuni
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro F. Giffuni 2008-07-29 23:00:09 UTC
- Move around some DISTFILES+= according to the knobs to avoid downloading unneeded files.
- specify a bit better the MASTERSITES to avoid some searches.
- Update URL for UNIX port.

How-To-Repeat: off-topic: This builds but doesn't run on amd64, I think that we should be able to crosscompile it and use it under 32 bits just fine. Also see http://www.squeakvm.org/squeak64/
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-07-29 23:00:17 UTC
Maintainer of lang/squeak,

Please note that PR ports/126081 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/126081

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-07-29 23:00:19 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Takeshi MUTOH 2008-07-30 07:12:31 UTC
I'm a maintainer of lang/squeak

Thanks for useful patch > Pedro


On 2008/07/30, at 7:00, Edwin Groothuis wrote:

> Maintainer of lang/squeak,
>
> Please note that PR ports/126081 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.

I check this patch. It's no problem to update.


But other libffi version up issue remains.
So please update patch for Makefile below:

fuji% diff -u Makefile.orig Makefile
--- Makefile.orig	2008-07-30 14:05:15.000000000 +0900
+++ Makefile	2008-07-30 14:17:54.000000000 +0900
@@ -17,17 +17,15 @@
  			ftp://st.cs.uiuc.edu/Smalltalk/Squeak/${PORTVERSION}/unix-linux/ \
  			ftp://ftp.cs.uni-magdeburg.de/pub/Smalltalk/Smalltalk/Squeak/$ 
{PORTVERSION}/ \
  			ftp://ftp.cs.uni-magdeburg.de/pub/Smalltalk/Smalltalk/Squeak/$ 
{PORTVERSION}/unix-linux/ \
-			http://www.squeakland.org/installers/ \
-			http://www.squeakland.jp/plugin/installers/ \
-			http://squeak.610t.org/patches/
-DISTFILES=		Squeak-${VMVERSION}.src.tar.gz \
+			http://www.squeakland.org/installers/:plugin \
+			http://www.squeakland.jp/plugin/installers/:jpplugin \
+			http://squeak.610t.org/patches/:ximpatch
+DISTFILES=		Squeak-${VMVERSION}.src${EXTRACT_SUFX} \
  			Squeak${IMAGEVERSION}-${PATCHNUMBER}-basic.zip \
  			Squeak${IMAGEVERSION}-${PATCHNUMBER}-full.zip \
-			SqueakPlugin.zip \
  			SqueakV3.sources.gz \
-			${XIM_PATCH} \
-			${JAPANESE_PLUGIN_IMAGE}
-EXTRACT_ONLY=		Squeak-${VMVERSION}.src.tar.gz
+			${JAPANESE_PLUGIN_IMAGE}:jpplugin
+EXTRACT_ONLY=		Squeak-${VMVERSION}.src${EXTRACT_SUFX}

  ##################################################
  MAINTAINER=		mutoh@openedu.org
@@ -53,7 +51,7 @@
  .include <bsd.port.pre.mk>

  ##################################################
-XIM_PATCH=		SqueakImmX11Plugin3a.tar.gz
+XIM_PATCH=		SqueakImmX11Plugin3a${EXTRACT_SUFX}
  PLUGIN_IMAGE=		SqueakPlugin.zip
  JAPANESE_PLUGIN_IMAGE=		SqueakPlugin2005J.zip

@@ -101,6 +99,7 @@
  CONFIGURE_ARGS+=	--without-npsqueak
  PLIST_NPSQUEAK=		"@comment feature not wanted - "
  .else
+DISTFILES+=		SqueakPlugin.zip:plugin
  WITH_NPSQUEAK=		yes
  PLIST_NPSQUEAK=
  FILES_TO_GZIP+=		SqueakPlugin.image
@@ -122,7 +121,7 @@
  .endif

  .if defined(WITH_FFI)
-LIB_DEPENDS+=		ffi.2:${PORTSDIR}/devel/libffi
+LIB_DEPENDS+=		ffi:${PORTSDIR}/devel/libffi
  PLIST_FFI=
  EXT_PLUGINS+=		SqueakFFIPrims
  .else
@@ -131,6 +130,7 @@
  .endif

  .if defined(WITH_XIM)
+DISTFILES+=		${XIM_PATCH}:ximpatch
  PLIST_XIM=
  WITH_X=			yes
  USE_ICONV=		yes



 > How-To-Repeat:
 > off-topic: This builds but doesn't run on amd64, I think that we  
should be able to crosscompile it and use it under 32 bits just fine.  
Also
 > seehttp://www.squeakvm.org/squeak64/

I want to run squeak other platforms too.
Now I prepare VM upgrade to 3.9-7, and after then try to remove  
ONLY_FOR_ARCHS.

If you have some idea and offcourse patches;-), please send me.

Thanks, again.
--
Takeshi MUTOH <mutoh@openedu.org>
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2008-07-30 07:41:12 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 5 Pav Lucistnik freebsd_committer freebsd_triage 2008-08-01 13:32:24 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2008-08-01 13:32:45 UTC
pav         2008-08-01 12:32:35 UTC

  FreeBSD ports repository

  Modified files:
    lang/squeak          Makefile pkg-descr 
  Log:
  - Reorganize Makefile to only download distfiles relevant to enabled OPTIONS
  - Update WWW
  
  PR:             ports/126081
  Submitted by:   Pedro F. Giffuni <pfgshield-freebsd@yahoo.com>
  Approved by:    Takeshi MUTOH <mutoh@openedu.org> (maintainer)
  
  Revision  Changes    Path
  1.18      +9 -9      ports/lang/squeak/Makefile
  1.2       +1 -1      ports/lang/squeak/pkg-descr
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"