Bug 126337 - [maintainer-update] sysutils/logrotate: olddir option fix
Summary: [maintainer-update] sysutils/logrotate: olddir option fix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-07 15:40 UTC by js
Modified: 2008-08-15 20:30 UTC (History)
0 users

See Also:

Attachments
file.txt (2.25 KB, text/plain)
2008-08-07 15:40 UTC, js 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description js 2008-08-07 15:40:01 UTC 
logrotate's path-type options (eg. compress, olddir, just to name a few) fail because FreeBSD's libc implements mbtrowc(3) differently, and returns -2 on empty string.  Linux version, however, returns 0.

A simple zero-length check added to path check function, which hides this.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-08-07 15:40:28 UTC 
Class Changed
From-To: sw-bug->maintainer-update

Fix category (submitter is maintainer) (via the GNATS Auto Assign Tool)
Comment 2 js 2008-08-14 08:42:25 UTC 
Committers?
Comment 3 Martin Wilke freebsd_committer freebsd_triage 2008-08-14 09:49:28 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->miwi

I'll take it.
Comment 4 Martin Wilke freebsd_committer freebsd_triage 2008-08-15 20:19:44 UTC 
State Changed
From-To: open->closed

Committed. Thanks!
Comment 5 dfilter service freebsd_committer freebsd_triage 2008-08-15 20:19:58 UTC 
miwi        2008-08-15 19:19:35 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/logrotate   Makefile 
    sysutils/logrotate/files patch-aa 
  Log:
  - Olddir options fix
  
       logrotate's path-type options (eg. compress, olddir,
       just to name a few) fail because FreeBSD's libc
       implements mbtrowc(3) differently, and returns -2 on
       empty string. Linux version, however, returns 0.
  
       A simple zero-length check added to path check function,
       which hides this.
  
  PR:             126337
  Submitted by:   Balazs NAGY <js@iksz.hu> (maintainer)
  
  Revision  Changes    Path
  1.26      +1 -0      ports/sysutils/logrotate/Makefile
  1.7       +15 -6     ports/sysutils/logrotate/files/patch-aa
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"