Bug 126726 - Removes the .sh extension from the rc file for net/openslp
Summary: Removes the .sh extension from the rc file for net/openslp
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-22 04:00 UTC by Joseph S. Atkinson
Modified: 2008-10-22 01:50 UTC (History)
0 users

See Also:


Attachments
file.txt (1.51 KB, text/plain)
2008-08-22 04:00 UTC, Joseph S. Atkinson
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph S. Atkinson 2008-08-22 04:00:10 UTC
net/openslp has some oddness from before ports handled USE_RC_SUBR the way it does now. This patch removes the method used to "manually" install the script which also resuled in it being installed as 001slpd.sh in etc/rc.d. It will now use the built in functions within the ports/Mk structure instead and install as etc/rc.d/slpd.

To work properly, it will require that ports/net/openslp/files/slpd.sh.example be moved to ports/net/openslp/files/slpd.in in cvs.

Fix: mv/cp files/slpd.sh.example to files/slpd.in

Apply included patch.

OpenSLP should now install following current ports logic.

Patch attached with submission follows:
How-To-Repeat: cd /usr/ports/net/openslp/ && make install
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-08-22 04:00:21 UTC
Responsible Changed
From-To: freebsd-ports-bugs->marcus

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Rong-En Fan 2008-08-22 04:18:05 UTC
The rc script can be improved a little bit:

1. use the preferred default assignment per Porter's Handbook
2. move the pid file argument out of slpd_flags. put it in command_args
   so it will *always* be added to the command

=====

. %%RC_SUBR%%
 
name=slpd
rcvar=`set_rcvar`
 
command=%%PREFIX%%/sbin/slpd
pidfile="/var/run/${name}.pid"
 
load_rc_config ${name}
 
: ${slpd_enable="NO"}
 
command_args="-p $pidfile"
 
run_rc_command "$1"
Comment 3 Joe Marcus Clarke freebsd_committer freebsd_triage 2008-10-22 01:47:23 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2008-10-22 01:47:25 UTC
marcus      2008-10-22 00:47:12 UTC

  FreeBSD ports repository

  Modified files:
    net/openslp          Makefile pkg-plist 
  Removed files:
    net/openslp/files    slpd.sh.sample 
  Log:
  Make use of the new old world rc order, and install the slpd rc.d script
  properly.
  
  PR:             126726
  Submitted by:   "Joseph S. Atkinson" <jsa@dmz.wickedmachine.net>
  
  Revision  Changes    Path
  1.21      +2 -6      ports/net/openslp/Makefile
  1.6       +0 -26     ports/net/openslp/files/slpd.sh.sample (dead)
  1.6       +0 -1      ports/net/openslp/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"