Bug 127668 - New port: multimedia/libtuner Driver framework for TV/radio tuner ICs
Summary: New port: multimedia/libtuner Driver framework for TV/radio tuner ICs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-27 01:30 UTC by jason.harmening
Modified: 2008-10-01 11:10 UTC (History)
0 users

See Also:


Attachments
file.shar (2.63 KB, text/plain)
2008-09-27 01:30 UTC, jason.harmening
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description jason.harmening 2008-09-27 01:30:08 UTC
libtuner provides userspace drivers and support routines for
a variety of TV and radio tuner ICs.  These ICs are usually
attached to a peripheral bus (such as an I2C bus) embedded
on a tuner card, and "stub" device nodes for the ICs will
be exported by a card-specific driver.

Fix: Patch attached with submission follows:
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2008-09-30 10:40:12 UTC
Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.
Comment 2 Dmitry Marakasov 2008-09-30 11:09:58 UTC
> Synopsis: New port: multimedia/libtuner  Driver framework for TV/radio tuner ICs
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=127668

- Please use tabs, not spaces in the makefile (install ports-mgmt/portlint and see output of `portlint -A` in port directory)
- Port should respect ${CXX} and ${CXXFLAGS}. May be done like this:

post-patch:
       @${REINPLACE_CMD} -e 's|g++|${CXX}|; s|-O2|${CXXFLAGS}|' ${WRKSRC}/Makefile

but since you're the author, I'd recommend modifying Makefile like that:

---
CXX?=	g++
CXXFLAGS?=	-O2
CXXFLAGS+=	-Wall -fPIC

...
---

and changing g++ to ${CXX} when linking (btw, compile flags `-Wall -O2
-fPIC' are not needed there)

Thus it'll be conveniently useful both from ports and standalonde.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2008-09-30 11:20:23 UTC
State Changed
From-To: open->feedback

Awaiting submitter's feedback.
Comment 4 jason.harmening 2008-10-01 01:47:27 UTC
Recommended changes have been made:

# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#	libtuner
#	libtuner/Makefile
#	libtuner/pkg-descr
#	libtuner/pkg-plist
#	libtuner/distinfo
#
echo c - libtuner
mkdir -p libtuner > /dev/null 2>&1
echo x - libtuner/Makefile
sed 's/^X//' >libtuner/Makefile << '529bc993816b7d546e4dff4f6b0988d4'
X# New ports collection makefile for:   libtuner
X# Date created:        7 September 2008
X# Whom:                jah
X#
X# $FreeBSD$
X#
X
XPORTNAME=	libtuner
XPORTVERSION=	1.0.1
XCATEGORIES=	multimedia
XMASTER_SITES=	ftp://corona.homeunix.net/ports/libtuner/
XEXTRACT_ONLY=	libtuner-${PORTVERSION}.tar.gz
X
XMAINTAINER=	jason.harmening@gmail.com
XCOMMENT=	Userspace drivers for various TV/radio tuner ICs
X
XMAKE_ARGS+=	LIBTUNER_MAJOR=1 LIBTUNER_MINOR=0 LIBTUNER_REV=1 
INSTALLDIR=${PREFIX}
XUSE_LDCONFIG=	${PREFIX}/lib/libtuner
X
X.include <bsd.port.mk>
529bc993816b7d546e4dff4f6b0988d4
echo x - libtuner/pkg-descr
sed 's/^X//' >libtuner/pkg-descr << '5beeedb1bc2cf7a59b3b281b520f983c'
Xlibtuner provides userspace drivers and support routines for
Xa variety of TV and radio tuner ICs.  These ICs are usually
Xattached to a peripheral bus (such as an I2C bus) embedded 
Xon a tuner card, and "stub" device nodes for the ICs will
Xbe exported by a card-specific driver.
5beeedb1bc2cf7a59b3b281b520f983c
echo x - libtuner/pkg-plist
sed 's/^X//' >libtuner/pkg-plist << '802be702c263f03bec74906c942297c2'
Xlib/libtuner/libtuner.so
Xlib/libtuner/libtuner.so.1
Xlib/libtuner/libtuner.so.1.0
Xlib/libtuner/libtuner.so.1.0.1
Xinclude/libtuner/avb_driver.h
Xinclude/libtuner/cx22702.h
Xinclude/libtuner/dtt75105.h
Xinclude/libtuner/dtt7579.h
Xinclude/libtuner/dtt7612.h
Xinclude/libtuner/dvb_driver.h
Xinclude/libtuner/fmd1216me.h
Xinclude/libtuner/lg3303.h
Xinclude/libtuner/lgh064f.h
Xinclude/libtuner/or51132.h
Xinclude/libtuner/pll_driver.h
Xinclude/libtuner/tda9887.h
Xinclude/libtuner/tuner_config.h
Xinclude/libtuner/tuner_device.h
Xinclude/libtuner/tuner_devnode_device.h
Xinclude/libtuner/tuner_driver.h
Xinclude/libtuner/tuner_firmware.h
X@dirrm lib/libtuner
X@dirrm include/libtuner
802be702c263f03bec74906c942297c2
echo x - libtuner/distinfo
sed 's/^X//' >libtuner/distinfo << '173e11c8951eda286b41ce57cc048658'
XMD5 (libtuner-1.0.1.tar.gz) = 39ca0ddc39bddfe30fd4065cf9526c83
XSHA256 (libtuner-1.0.1.tar.gz) = 
c40e20e1df1c65bc75cffec30525dec7768feaaa767123f2990ac41aa9d663ae
XSIZE (libtuner-1.0.1.tar.gz) = 14987
173e11c8951eda286b41ce57cc048658
exit
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2008-10-01 11:06:46 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2008-10-01 11:06:52 UTC
amdmi3      2008-10-01 10:06:38 UTC

  FreeBSD ports repository

  Modified files:
    multimedia           Makefile 
  Added files:
    multimedia/libtuner  Makefile distinfo pkg-descr pkg-plist 
  Log:
  libtuner provides userspace drivers and support routines for
  a variety of TV and radio tuner ICs.  These ICs are usually
  attached to a peripheral bus (such as an I2C bus) embedded
  on a tuner card, and "stub" device nodes for the ICs will
  be exported by a card-specific driver.
  
  PR:             127668
  Submitted by:   Jason Harmening <jason dot harmening at gmail dot com>
  
  Revision  Changes    Path
  1.274     +1 -0      ports/multimedia/Makefile
  1.1       +20 -0     ports/multimedia/libtuner/Makefile (new)
  1.1       +3 -0      ports/multimedia/libtuner/distinfo (new)
  1.1       +5 -0      ports/multimedia/libtuner/pkg-descr (new)
  1.1       +23 -0     ports/multimedia/libtuner/pkg-plist (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"