Bug 127978 - ftp/jftpgw - 'pidfile=/var/run/jftpgw.pid' interferes in rc script
Summary: ftp/jftpgw - 'pidfile=/var/run/jftpgw.pid' interferes in rc script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-09 12:40 UTC by Helmut Schneider
Modified: 2009-01-02 19:21 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Helmut Schneider 2008-10-09 12:40:00 UTC
/usr/local/etc/rc.d/jftpgw states:

pidfile=/var/run/jftpgw.pid

When the pid file is changed via jftpgw.conf the change is ignored and restart fails.

Fix: 

Remove line

pidfile=/var/run/jftpgw.pid

from /usr/local/etc/rc.d/jftpgw as 'pidfile=/var/run/jftpgw.pid' is default anyway.
How-To-Repeat: [root@proxy ~]# cat /usr/local/etc/jftpgw.conf | grep pid$
        pidfile                 /var/run/jftpgw/jftpgw.pid
[root@proxy ~]# ps -p `cat /var/run/jftpgw/jftpgw.pid`
  PID  TT  STAT      TIME COMMAND
49108  ??  Ss     0:00.00 /usr/local/sbin/jftpgw -f /usr/local/etc/jftpgw.conf
[root@proxy ~]# /usr/local/etc/rc.d/jftpgw restart
jftpgw not running? (check /var/run/jftpgw.pid).
Starting jftpgw.
Error binding: Address already in use
[root@proxy ~]#
Comment 1 Mark Linimon 2008-10-09 21:46:40 UTC
To which port does this PR apply?

mcl
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-10-09 22:29:44 UTC
Responsible Changed
From-To: freebsd-ports-bugs->se

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2008-12-18 02:34:19 UTC
Responsible Changed
From-To: se->freebsd-ports-bugs

Maintainer was reset.
Comment 4 dfilter service freebsd_committer freebsd_triage 2009-01-02 19:18:19 UTC
lippe       2009-01-02 19:18:02 UTC

  FreeBSD ports repository

  Modified files:
    ftp/jftpgw           Makefile 
    ftp/jftpgw/files     jftpgw.sh.in 
  Log:
  - Fix rc script when setting pidfile in the main config file.
  - PORTREVISION bumped.
  
  PR:             ports/127978
  Submitted by:   Helmut Schneider <jumper99@gmx.de>
  
  Revision  Changes    Path
  1.16      +1 -1      ports/ftp/jftpgw/Makefile
  1.8       +0 -1      ports/ftp/jftpgw/files/jftpgw.sh.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Felippe de Meirelles Motta freebsd_committer freebsd_triage 2009-01-02 19:21:15 UTC
State Changed
From-To: open->closed

Committed. Thanks!