Bug 128080 - www/opera - operapluginwrapper has a syntax error.
Summary: www/opera - operapluginwrapper has a syntax error.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ion-Mihai "IOnut" Tetcu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-14 04:30 UTC by KOIE Hidetaka
Modified: 2008-10-16 11:30 UTC (History)
0 users

See Also:


Attachments
operapluginwrapper (265 bytes, application/octet-stream)
2008-10-14 09:04 UTC, Arjan van Leeuwen
no flags Details
opera.diff.txt (624 bytes, text/plain)
2008-10-14 09:10 UTC, Arjan van Leeuwen
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description KOIE Hidetaka 2008-10-14 04:30:01 UTC
I installed opera-9.60.20081004.
When start opera, an error dialog pops up.
It seems a bug in the script operapluginwrapper.

BTW, if linux-opera is installed,
ln -s /usr/local/share/linux-opera/bin/operapluginwrapper /usr/local/share/opera/bin/operapluginwrapper.linux.

Fix: koie@guriandgura% diff -u /usr/local/share/opera/bin/operapluginwrapper{.orig,}


-if [ brandelf $3 | grep "FreeBSD" ]; then
+if brandelf $3 | grep "FreeBSD"; then
        exec $0.freebsd $@
 else
        exec $0.linux $@--dlEgrLiP4nQnjJCrtlk5p1UMd1GoAAp819sdsBSyAD42a0pB
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- /usr/local/share/opera/bin/operapluginwrapper.orig  2008-10-14 11:52:00.261409096 +0900
+++ /usr/local/share/opera/bin/operapluginwrapper       2008-10-14 11:54:44.635606439 +0900
@@ -1,6 +1,6 @@
 #!/bin/sh
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-10-14 04:53:06 UTC
Responsible Changed
From-To: freebsd-ports-bugs->itetcu

itetcu@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-10-14 04:53:08 UTC
Maintainer of www/opera,

Please note that PR ports/128080 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/128080

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2008-10-14 04:53:09 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Arjan van Leeuwen 2008-10-14 09:04:39 UTC
My apologies, that script didn't work. Attached is a version that works,  
to be placed in www/opera/files/.

Arjan

-- 
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
Comment 5 Arjan van Leeuwen 2008-10-14 09:10:12 UTC
That last mail got lost I think, here's just the diff with the fix  
attached.

Arjan

-- 
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
Comment 6 KOIE Hidetaka 2008-10-14 10:29:30 UTC
I applied your patch, it works fine and no warning message are displayed.
how about the following?

#!/bin/sh

if [ -n "$4" ]; then
	ELFTYPE=`brandelf $4`
elif [ -n "$3" ]; then
	ELFTYPE=`brandelf $3`
fi

WRAPPER="freebsd"
case "${ELFTYPE}" in
*SVR4*|*Linux*)
	if [ -x "$0.linux" ]; then
		WRAPPER="linux"
	fi
	;;
esac

exec $0.$WRAPPER $@

--
KOIE Hidetaka <hide@koie.org>
Comment 7 Arjan van Leeuwen 2008-10-14 11:22:49 UTC
That looks even better to me :).

Arjan

-- 
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
Comment 8 dfilter service freebsd_committer freebsd_triage 2008-10-16 11:25:15 UTC
itetcu      2008-10-16 10:25:06 UTC

  FreeBSD ports repository

  Modified files:
    www/opera            Makefile 
    www/opera/files      operapluginwrapper 
  Log:
  Fix opera plugin wrapper and bump PORTREVISION.
  
  PR:             ports/128080
  Submitted by:   KOIE Hidetaka
  Approved by:    maintainer
  Committed from: EuroBSDCon2008 Dev Summit :)
  
  Revision  Changes    Path
  1.80      +1 -0      ports/www/opera/Makefile
  1.2       +16 -4     ports/www/opera/files/operapluginwrapper
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 9 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2008-10-16 11:25:19 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!