Bug 128104 - net/isc-dhcp30-server LDAP support broken [regression]
Summary: net/isc-dhcp30-server LDAP support broken [regression]
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Stefan Walter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-14 23:50 UTC by Andrew Daugherity
Modified: 2008-10-18 18:30 UTC (History)
0 users

See Also:


Attachments
net_isc-dhcp30-server.diff (1.60 KB, patch)
2008-10-15 12:53 UTC, Joerg Pulz
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Daugherity 2008-10-14 23:50:00 UTC
After upgrading dhcpd to reflect the new version and the port name change ( from isc-dhcp3-server-3.0.5_2 to isc-dhcp30-server-3.0.7_2), dhcpd failed to restart, complaining about syntax errors:
====
/usr/local/etc/dhcpd.conf line 19: semicolon expected.
ldap-ssl start_tls;
         ^
Configuration file errors encountered -- exiting
====

After commenting out that line, it still failed, generating many errors like this:
====
LDAP line 34: expecting a declaration
}
^
LDAP line 41: string constant larger than internal buffer
option pxelinux.reboottime code 211 = unsigned integer 32;
                             ^
LDAP line 49: expecting a declaration
(binary garbage printed here)
 ^
LDAP line 59: expecting a declaration
(binary garbage printed here)
    ^
LDAP line 59: expecting a declaration
(binary garbage printed here)
^
LDAP line 65: expecting a declaration
(binary garbage printed here)
^
====

Of course, this makes dhcpd completely broken for LDAP use.

Fix: 

I discovered that the port Makefile has two sites defined for the LDAP patch:
1. http://www.newwave.net/~masneyb/
2. ftp://ftp.frm2.tum.de/pub/jpulz/FreeBSD/

It attempts to fetch dhcp-$VERSION-ldap-patch. Site 1 only has version 3.0.5, while site 2 has many versions.  However, version 3.0.5 of the patch ('dhcp-3.0.5-ldap-patch') is not identical between the sites even (the version on site 2 is missing large sections of the patch).

The real bug is that the patches from site 2 are broken, and this behavior is a side-effect of the upgrade: due to there not being a dhcp-3.0.7-ldap-patch on site 1, it fetches it from site 2.  When the portversion was 3.0.5 it fetched from site 1 and all was well.


Workaround: use the patch from site 1, which still works with 3.0.7.
# ftp http://www.newwave.net/~masneyb/dhcp-3.0.5-ldap-patch
# cp dhcp-3.0.5-ldap-patch /usr/ports/distfiles/dhcp-3.0.7-ldap-patch
# cd /usr/ports/net/isc-dhcp30-server; make makesum
# make install   (or make deinstall reinstall)

After doing this dhcpd works properly once more.
How-To-Repeat: Install isc-dhcp30-server-3.0.7_2 from ports, and enable LDAP support in the options screen.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-10-14 23:52:54 UTC
Maintainer of net/isc-dhcp30-server,

Please note that PR ports/128104 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/128104

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-10-14 23:52:56 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Joerg Pulz 2008-10-15 12:53:13 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Hi,

sorry, i've uploaded the wrong patchfile to the FTP server.
Attached is a patch for the port to tell distinfo the new size and 
checksums for the LDAP patchfile.
PORTREVISION gets bumped for the -server port.

Kind regards
Joerg

- -- 
The beginning is the most important part of the work.
 				-Plato
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (FreeBSD)

iD8DBQFI9dmsSPOsGF+KA+MRAq4uAKCj4i6Ll7mFyDfviDE5oe/tH4e/7ACgiUbL
OBqcACsK9EdctErFpSEiBOE=
=nJCV
-----END PGP SIGNATURE-----
Comment 4 Stefan Walter freebsd_committer freebsd_triage 2008-10-18 18:23:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->stefan

Take.
Comment 5 Stefan Walter freebsd_committer freebsd_triage 2008-10-18 18:25:22 UTC
State Changed
From-To: feedback->closed

Patch committed, thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2008-10-18 18:25:26 UTC
stefan      2008-10-18 17:25:17 UTC

  FreeBSD ports repository

  Modified files:
    net/isc-dhcp30-server Makefile distinfo 
  Log:
  Fix distinfo for LDAP patch.
  
  PR:             128104
  Submitted by:   Andrew Daugherity <adaugherity@tamu.edu>
  Patch by:       maintainer
  
  Revision  Changes    Path
  1.126     +1 -1      ports/net/isc-dhcp30-server/Makefile
  1.62      +3 -3      ports/net/isc-dhcp30-server/distinfo
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"