Bug 128476 - update biology/molden port
Summary: update biology/molden port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wesley Shields
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-30 10:40 UTC by fulvio ciriaco
Modified: 2008-11-04 22:00 UTC (History)
0 users

See Also:


Attachments
file.shar (28.26 KB, text/plain)
2008-10-30 10:40 UTC, fulvio ciriaco
no flags Details
molden.shar.txt (28.20 KB, text/plain; charset=US-ASCII)
2008-11-01 21:06 UTC, fulvio ciriaco
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description fulvio ciriaco 2008-10-30 10:40:01 UTC
molden in ports is 2 years old.
Attached find a port updated to 4.7
Fulvio

Fix: Patch attached with submission follows:
Comment 1 Wesley Shields freebsd_committer freebsd_triage 2008-10-30 12:23:31 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wxs

I'll take it.
Comment 2 Wesley Shields freebsd_committer freebsd_triage 2008-10-30 18:01:22 UTC
On Thu, Oct 30, 2008 at 06:24:13PM +0100, Fulvio Ciriaco wrote:
> Hallo,
> shortly after submitting the port, I discovered that
> it does not work well.
> molden 4.7 compiled by me segmentation faults in many 
> situations when trying to read input files, apparently
> in libgfortran
> after
> molden.f: 3010
>       read(iun1,'(a)',end=2828,err=2828) line
> 
> Fulvio

Are you working on a fix or should I close this PR?

-- WXS
Comment 3 fulvio ciriaco 2008-10-30 18:27:28 UTC
At Thu, 30 Oct 2008 14:01:22 -0400,
Wesley Shields wrote:
> 
> On Thu, Oct 30, 2008 at 06:24:13PM +0100, Fulvio Ciriaco wrote:
> > Hallo,
> > shortly after submitting the port, I discovered that
> > it does not work well.
> > molden 4.7 compiled by me segmentation faults in many 
> > situations when trying to read input files, apparently
> > in libgfortran
> > after
> > molden.f: 3010
> >       read(iun1,'(a)',end=2828,err=2828) line
> > 
> > Fulvio
> 
> Are you working on a fix or should I close this PR?
> 
> -- WXS
I spent an hour without arriving at the problem.
read() should not give segmentation fault.
Seems a problem with libgfortran.
Any idea?
Fulvio
Comment 4 Wesley Shields freebsd_committer freebsd_triage 2008-10-30 18:40:46 UTC
On Thu, Oct 30, 2008 at 07:27:28PM +0100, Fulvio Ciriaco wrote:
> At Thu, 30 Oct 2008 14:01:22 -0400,
> Wesley Shields wrote:
> > 
> > On Thu, Oct 30, 2008 at 06:24:13PM +0100, Fulvio Ciriaco wrote:
> > > Hallo,
> > > shortly after submitting the port, I discovered that
> > > it does not work well.
> > > molden 4.7 compiled by me segmentation faults in many 
> > > situations when trying to read input files, apparently
> > > in libgfortran
> > > after
> > > molden.f: 3010
> > >       read(iun1,'(a)',end=2828,err=2828) line
> > > 
> > > Fulvio
> > 
> > Are you working on a fix or should I close this PR?
> > 
> > -- WXS
> I spent an hour without arriving at the problem.
> read() should not give segmentation fault.
> Seems a problem with libgfortran.

Unfortunately, no I'm not able to come up with a fix.

-- WXS
Comment 5 fulvio ciriaco 2008-11-01 21:06:40 UTC
At Thu, 30 Oct 2008 14:40:46 -0400,
Wesley Shields wrote:
> 
> On Thu, Oct 30, 2008 at 07:27:28PM +0100, Fulvio Ciriaco wrote:
> > At Thu, 30 Oct 2008 14:01:22 -0400,
> > Wesley Shields wrote:
> > > 
> > > On Thu, Oct 30, 2008 at 06:24:13PM +0100, Fulvio Ciriaco wrote:
> > > > Hallo,
> > > > shortly after submitting the port, I discovered that
> > > > it does not work well.
> > > > molden 4.7 compiled by me segmentation faults in many 
> > > > situations when trying to read input files, apparently
> > > > in libgfortran
> > > > after
> > > > molden.f: 3010
> > > >       read(iun1,'(a)',end=2828,err=2828) line
> > > > 
> > > > Fulvio
> > > 
> > > Are you working on a fix or should I close this PR?
> > > 
> > > -- WXS
> > I spent an hour without arriving at the problem.
> > read() should not give segmentation fault.
> > Seems a problem with libgfortran.
> 
> Unfortunately, no I'm not able to come up with a fix.
> 
> -- WXS
I fixed it.
Damned libgfortran.
Find it enclosed.
Fulvio
Comment 6 Wesley Shields freebsd_committer freebsd_triage 2008-11-03 20:59:33 UTC
Thanks for the update.  I've cleaned it up a bit and intend to commit it
soon.  Would you like to be the maintainer of this port?

-- WXS
Comment 7 fulvio ciriaco 2008-11-04 07:01:23 UTC
At Mon, 3 Nov 2008 15:59:33 -0500,
Wesley Shields wrote:
> 
> Thanks for the update.  I've cleaned it up a bit and intend to commit it
> soon.  Would you like to be the maintainer of this port?
> 
> -- WXS
ok
fulvio
Comment 8 dfilter service freebsd_committer freebsd_triage 2008-11-04 21:55:47 UTC
wxs         2008-11-04 21:55:39 UTC

  FreeBSD ports repository

  Modified files:
    biology/molden       Makefile distinfo pkg-plist 
    biology/molden/files patch-xwin.c 
  Added files:
    biology/molden/files patch-ambfor-makefile patch-makefile 
                         patch-surf-makefile 
  Removed files:
    biology/molden/files patch-aa patch-molden.f 
  Log:
  Update to 4.7
  
  PR:             ports/128476
  Submitted by:   fulvio ciriaco <oivulf@gmail.com>
  
  Revision  Changes    Path
  1.38      +8 -12     ports/biology/molden/Makefile
  1.17      +3 -3      ports/biology/molden/distinfo
  1.9       +0 -67     ports/biology/molden/files/patch-aa (dead)
  1.1       +17 -0     ports/biology/molden/files/patch-ambfor-makefile (new)
  1.1       +63 -0     ports/biology/molden/files/patch-makefile (new)
  1.2       +0 -10     ports/biology/molden/files/patch-molden.f (dead)
  1.1       +165 -0    ports/biology/molden/files/patch-surf-makefile (new)
  1.2       +41 -41    ports/biology/molden/files/patch-xwin.c
  1.10      +60 -55    ports/biology/molden/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 9 Wesley Shields freebsd_committer freebsd_triage 2008-11-04 21:55:53 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!