Bug 129270 - graphics/xfig installs pdf file in place of doc directory
Summary: graphics/xfig installs pdf file in place of doc directory
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Beech Rintoul
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-29 01:50 UTC by G. Paul Ziemba
Modified: 2008-11-30 00:40 UTC (History)
0 users

See Also:


Attachments
file.diff (2.01 KB, patch)
2008-11-29 01:50 UTC, G. Paul Ziemba
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description G. Paul Ziemba 2008-11-29 01:50:02 UTC
"make install" fails because:

    1. port makefile invokes install.html target,
       which calls install.rhtml target

    2. install.rhtml, install.jhtml targets assume
       existence of $(DESTDIR)$(XFIGDOCDIR)
       (/usr/local/share/doc/xfig) and call, e.g.,
       "install xfig-howto.pdf $(DESTDIR)$(XFIGDOCDIR)"
       which causes $(DESTDIR)$(XFIGDOCDIR) to be a copy
       of the file.

    3. subsequent "mkdirhier /usr/local/share/doc/xfig/html"
       exits with error because /usr/local/share/doc/xfig is a file.

# cd /usr/ports/graphics/xfig
# make showconfig
===> The following configuration options are available for xfig-3.2.5_1:
     GHOSTSCRIPT=on "Ghostscript support"
     I18N=off "I18N support and Japanese docs"
===> Use 'make config' to modify these settings
# make install
..
Copying Fig Object Libraries
+ /usr/local/bin/mkdirhier /usr/local/lib/X11/xfig/Libraries
+ set +x
Copying pdf and html files to /usr/local/share/doc/xfig
+ /usr/local/bin/mkdirhier /usr/local/share/doc/xfig/html
mkdir: //usr/local/share/doc/xfig: File exists
mkdir: //usr/local/share/doc/xfig: No such file or directory
*** Error code 1

Stop in /usr/ports/graphics/xfig/work/xfig.3.2.5.
*** Error code 1

Fix: A few changes to Imakefile seems to correct the problem. Since there is already a files/patch-Imakefile, I herewith submit a patch to that patch.

Patch attached with submission follows:
How-To-Repeat: cd /usr/ports/graphics/xfig
make deinstall
make install
Comment 1 Beech Rintoul freebsd_committer freebsd_triage 2008-11-29 04:36:06 UTC
Responsible Changed
From-To: freebsd-ports-bugs->beech

I'll take it
Comment 2 dfilter service freebsd_committer freebsd_triage 2008-11-30 00:39:18 UTC
beech       2008-11-30 00:39:09 UTC

  FreeBSD ports repository

  Modified files:
    graphics/xfig        Makefile 
    graphics/xfig/files  patch-Imakefile 
  Log:
  - Fix install
  - Bump portrevision
  
  PR:             ports/129270
  Submitted by:   "G. Paul Ziemba" <p-fbsd-bugs@ziemba.us>
  
  Revision  Changes    Path
  1.62      +1 -1      ports/graphics/xfig/Makefile
  1.5       +28 -5     ports/graphics/xfig/files/patch-Imakefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Beech Rintoul freebsd_committer freebsd_triage 2008-11-30 00:39:37 UTC
State Changed
From-To: open->closed

Committed, Thanks!