Bug 129375 - build devel/libdisasm on amd64
Summary: build devel/libdisasm on amd64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wesley Shields
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-02 20:40 UTC by Diego Ongaro
Modified: 2008-12-16 16:10 UTC (History)
0 users

See Also:


Attachments
file.diff (304 bytes, patch)
2008-12-02 20:40 UTC, Diego Ongaro
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Ongaro 2008-12-02 20:40:01 UTC
Port devel/libdisasm does not attempt to build on amd64, but works fine.


The upstream changelog shows for v0.22: "made types 64bit-safe".
http://bastard.svn.sourceforge.net/viewvc/bastard/trunk/libdisasm/ChangeLog?view=markup&pathrev=820

<wxs> the build is going well on all supported versions on amd64
<wxs> it was marked as ONLY_FOR_ARCHS=i386 in 1.3 of Makefile
<wxs> http://portsmon.freebsd.org/portoverview.py?category=devel&portname=libdisasm&wildcard=
<wxs> no logs available as to why it was broken on pointyhat
<wxs> it could be that the new version fixes whatever the problem was

Fix: See patch.

Patch attached with submission follows:
How-To-Repeat: Try to install the port. It won't even try.

Apply the patch, install the port, verify functionality with /usr/bin/x86dis. It seems OK to me.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-12-02 20:40:08 UTC
Maintainer of devel/libdisasm,

Please note that PR ports/129375 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/129375

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-12-02 20:40:10 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Wesley Shields freebsd_committer freebsd_triage 2008-12-02 21:04:43 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wxs

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2008-12-16 16:07:16 UTC
wxs         2008-12-16 16:07:02 UTC

  FreeBSD ports repository

  Modified files:
    devel/libdisasm      Makefile 
  Log:
  - This builds and words on AMD64
  
  PR:             ports/129375
  Submitted by:   Diego Ongaro <ongardie@gmail.com>
  Approved by:    maintainer timeout
  
  Revision  Changes    Path
  1.6       +1 -1      ports/devel/libdisasm/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Wesley Shields freebsd_committer freebsd_triage 2008-12-16 16:07:34 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!