Bug 130613 - [patch] lang/fpc-units: build all packages by default
Summary: [patch] lang/fpc-units: build all packages by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jose Alonso Cardenas Marquez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-16 09:40 UTC by Boris Samorodov
Modified: 2009-01-16 12:50 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Samorodov freebsd_committer freebsd_triage 2009-01-16 09:40:00 UTC
	1. The logic at lang/fpc-units/Makefile seems to be faulted: all options
	are "on" by default, but when no options file exists (i.e. for automatic
	batch building) none of packages are build.
	2. The unit numlib should be defined at _FPC_ALL_UNITS (ports/Mk/bsd.fpc.mk).

Fix: % cd /usr/ports
	% patch -p0 < _the_following_patch_



WBR
-- 
bsam--eBDnOLyk6vHGXETQciACI3wLINMeToy2RLn3X8jT6vGJivAu
Content-Type: text/plain; name="ports.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="ports.diff"

Index: Mk/bsd.fpc.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.fpc.mk,v
retrieving revision 1.4
diff -u -r1.4 bsd.fpc.mk
--- Mk/bsd.fpc.mk	14 Jan 2009 15:58:10 -0000	1.4
+++ Mk/bsd.fpc.mk	16 Jan 2009 09:24:05 -0000
@@ -58,7 +58,7 @@
 _FPC_ALL_UNITS=	aspell bfd cairo chm fcl-async fcl-base fcl-db fcl-fpcunit fcl-image \
 		fcl-json fcl-net fcl-passrc fcl-process fcl-registry fcl-web fcl-xml fftw \
 		fpmkunit fpgtk fv gdbint gdbm ggi gnome1 graph gtk1 gtk2 hash httpd \
-		ibase imagemagick imlib libcurl libgd libpng mysql ncurses \
+		ibase imagemagick imlib libcurl libgd libpng mysql ncurses numlib \
 		odbc opengl openssl oracle pasjpeg paszlib pcap postgres pthreads pxlib \
 		regexpr sdl sqlite svgalib symbolic syslog tcl unzip users utmp x11 xforms \
 		zlib
Index: lang/fpc-units/Makefile
===================================================================
RCS file: /home/pcvs/ports/lang/fpc-units/Makefile,v
retrieving revision 1.12
diff -u -r1.12 Makefile
--- lang/fpc-units/Makefile	14 Jan 2009 06:12:13 -0000	1.12
+++ lang/fpc-units/Makefile	16 Jan 2009 09:24:05 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	units
 PORTVERSION=	2.2.2
+PORTREVISION=	1
 CATEGORIES=	lang
 MASTER_SITES=	# none
 PKGNAMEPREFIX=	fpc-
@@ -85,7 +86,7 @@
 
 UNITS_SELECTED=		#
 .for OPT in ${ALL_OPTIONS}
-.	if defined(WITH_${OPT})  && !defined(WITHOUT_${OPT})
+.	if defined(WITH_${OPT})  || !defined(WITHOUT_${OPT})
 UNITS_SELECTED+=	${OPT:L}
 .	endif
 .endfor
How-To-Repeat: 	-----
	% cd /usr/ports/lang/fpc-units
	% ls -l `make -V OPTIONSFILE`
	-rw-r--r--  1 root  wheel  943 16 ### 12:06 /var/db/ports/fpc-units/options
	bb% make -V UNITS_SELECTED
	 aspell bfd cairo chm fftw fpmkunit fpgtk fv gdbm ggi gtk2 imagemagick imlib libcurl libgd libpng ncurses numlib opengl openssl pcap pxlib sdl svgalib symbolic syslog tcl unzip users utmp x11 xforms zlib
	bb% sudo rm `make -V OPTIONSFILE`
	bb% make -V UNITS_SELECTED
	
	bb%
	-----
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-01-16 09:40:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->acm

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2009-01-16 12:41:59 UTC
acm         2009-01-16 12:41:45 UTC

  FreeBSD ports repository

  Modified files:
    lang/fpc-units       Makefile 
  Log:
  - Fix the logic with the options selected
  - Bump PORTREVISION
  
  PR:             130613
  Submitted by:   bsam
  
  Revision  Changes    Path
  1.13      +2 -1      ports/lang/fpc-units/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2009-01-16 12:44:36 UTC
State Changed
From-To: open->closed

Committed thanks :)
Comment 4 dfilter service freebsd_committer freebsd_triage 2009-01-16 12:45:06 UTC
acm         2009-01-16 12:44:23 UTC

  FreeBSD ports repository

  Modified files:
    Mk                   bsd.fpc.mk 
  Log:
  - Add numlib unit to _FPC_ALL_UNITS.
  
  PR:             130613
  Submitted by:   bsam
  
  Revision  Changes    Path
  1.5       +2 -2      ports/Mk/bsd.fpc.mk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"