Bug 130673 - [patch] - update sysutils/phplogcon
Summary: [patch] - update sysutils/phplogcon
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Philippe Audeoud
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-18 03:00 UTC by Cristiano Rolim Pereira
Modified: 2009-01-21 15:20 UTC (History)
0 users

See Also:


Attachments
file.diff (1.42 KB, patch)
2009-01-18 03:00 UTC, Cristiano Rolim Pereira
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cristiano Rolim Pereira 2009-01-18 03:00:08 UTC
-Added necessary PHP dependencies:
    session
    gd
    xml
    pdo

-Added PHP version check
-Included pkg-message

Fix: Patch attached with submission follows:
Comment 1 Philippe Audeoud freebsd_committer freebsd_triage 2009-01-19 16:02:21 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jadawin

I'll take it.
Comment 2 Philippe Audeoud freebsd_committer freebsd_triage 2009-01-19 16:02:34 UTC
State Changed
From-To: open->feedback

Why don't using OPTIONS for additional php function instead pkg-message?
Comment 3 Cristiano Rolim Pereira 2009-01-19 20:03:58 UTC
This patch replaces the previous pkg-message with OPTIONS in the Makefile:

diff -ruN ../phplogcon.ori/Makefile ./Makefile
--- ../phplogcon.ori/Makefile	2008-12-28 09:42:28.000000000 -0200
+++ ./Makefile	2009-01-19 15:37:56.000000000 -0200
@@ -7,6 +7,7 @@

 PORTNAME=	phplogcon
 PORTVERSION=	2.5.23
+PORTREVISION=	1
 CATEGORIES=	sysutils www
 MASTER_SITES=	http://download.adiscon.com/phplogcon/

@@ -14,8 +15,10 @@
 COMMENT=	Web Based Syslog Review

 .if !defined(WITHOUT_PHP_DEPENDS)
-USE_PHP=	YES
+USE_PHP=	session pdo gd xml
 WANT_PHP_WEB=	YES
+IGNORE_WITH_PHP=4
+DEFAULT_PHP_VER=5
 .endif
 NO_BUILD=	YES
 LOGCONDIR?=	www/phplogcon
@@ -25,8 +28,51 @@
 	@${ECHO_CMD} "# you can customize the installation directory"
 	@${ECHO_CMD} "# by setting LOGCON in /etc/make.conf"

+OPTIONS=	PHP_MYSQL "MySQL database support (PHP extension)" Off \
+		PDO_DBLIB "Microsoft SQL Server and Sybase PDO driver" Off \
+		PDO_FIREBIRD "Firebird/Interbase PDO driver" Off \
+		PDO_MYSQL "MySQL Server PDO driver" Off \
+		PDO_OCI "Oracle PDO driver (i386 onnly)" Off \
+		PDO_ODBC "ODBC and DB2 PDO driver" Off \
+		PDO_PGSQL "PostgreSQL PDO driver" Off \
+		PDO_SQLITE "SQLite PDO driver" Off
+
 .include <bsd.port.pre.mk>

+.if !defined(WITHOUT_PHP_DEPENDS)
+.if defined(WITH_PHP_MYSQL)
+USE_PHP+=	mysql
+.endif
+
+.if defined(WITH_PDO_DBLIB)
+RUN_DEPENDS+=${PHPBASE}/lib/php/${PHP_EXT_DIR}/pdo_dblib.so:${PORTSDIR}/databases/php5-pdo_dblib+.endif
+
+.if defined(WITH_PDO_FIREBIRD)
+RUN_DEPENDS+=${PHPBASE}/lib/php/${PHP_EXT_DIR}/pdo_firebird.so:${PORTSDIR}/databases/php5-pdo_firebird+.endif
+
+.if defined(WITH_PDO_MYSQL)
+USE_PHP+=	pdo_mysql
+.endif
+
+.if defined(WITH_PDO_OCI) && ${ARCH} == "i386"
+RUN_DEPENDS+=${PHPBASE}/lib/php/${PHP_EXT_DIR}/pdo_oci.so:${PORTSDIR}/databases/php5-pdo_oci+.endif
+
+.if defined(WITH_PDO_ODBC)
+RUN_DEPENDS+=${PHPBASE}/lib/php/${PHP_EXT_DIR}/pdo_odbc.so:${PORTSDIR}/databases/php5-pdo_odbc+.endif
+
+.if defined(WITH_PDO_PGSQL)
+RUN_DEPENDS+=${PHPBASE}/lib/php/${PHP_EXT_DIR}/pdo_pgsql.so:${PORTSDIR}/databases/php5-pdo_pgsql+.endif
+
+.if defined(WITH_PDO_SQLITE)
+USE_PHP+=	pdo_sqlite
+.endif
+.endif
+
 do-install:
 	${MKDIR} ${PREFIX}/${LOGCONDIR}
 	${CP} -Rp ${WRKSRC}/src/ ${PREFIX}/${LOGCONDIR}/
Comment 4 dfilter service freebsd_committer freebsd_triage 2009-01-21 15:17:37 UTC
jadawin     2009-01-21 15:17:21 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/phplogcon   Makefile 
  Log:
  - Add PHP dependencies
  - Add OPTIONS
  - Bump PORTREVISION
  
  PR:             ports/130673
  Submitted by:   Cristiano Rolim Pereira <cristianorolim _AT_ hotmail _DOT_ com> (maintainer)
  
  Revision  Changes    Path
  1.2       +49 -4     ports/sysutils/phplogcon/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Philippe Audeoud freebsd_committer freebsd_triage 2009-01-21 15:18:12 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!