Bug 130903 - misc/kdeedu4 does not build libsbigudrv.so during upgrade
Summary: misc/kdeedu4 does not build libsbigudrv.so during upgrade
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-23 00:20 UTC by me
Modified: 2009-01-23 14:20 UTC (History)
0 users

See Also:


Attachments
file.diff (1.03 KB, patch)
2009-01-23 00:20 UTC, me
no flags Details | Diff
kdeedu414.patch (789 bytes, patch)
2009-01-23 09:14 UTC, Max Brazhnikov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description me 2009-01-23 00:20:01 UTC
If libsbigudrv.so is already installed, for example from a previous version of the same port during a portupgrade, misc/kdeedu4 links against the old version of libsbigudrv.so and consequently does not build a new one. As a result, the old version is removed with the old package and the library is missing for the new install.

This has happened to me during an upgrade from kdeedu-4.1.1_1 to kdeedu-4.1.4, but it probably applies for other upgrades, too, since the configure reported the same for the upgrade to kdeedu-4.1.4_1.

With a previous version installed:
  -- Found SBIG: /usr/local/kde4/lib/libsbigudrv.so
  ...
  + libsbigudrv
  ...
  Congratulations! All external packages have been found.
Without a previous version installed:
  -- Could not find OPTIONAL package SBIG
  ..
  -- The following OPTIONAL packages could NOT be located on your system.
  -- Consider installing them to enable more features from this software.
  + libsbigudrv, 1.00: SBIG Universal Driver <http://indi.sourceforge.net/>
  Needed by KStars.

Fix: mkdir misc/kdeedu4/files
patch < kdeedu4-always-libsbigudrv.txt

This will remove all non-comment lines from cmake/modules/FindSBIG.cmake. The configure process will not find libsbigudrv.so from the previous version anymore and it is build and installed.

Patch attached with submission follows:
How-To-Repeat: - Have kdeedu-4.1.1_1 installed and portupgrade to kdeedu-4.1.4.
- Try to 'pkg_create -b kdeedu-4.1.4' and observe that lib/libsbigudrv.so* is missing.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-01-23 00:20:11 UTC
Responsible Changed
From-To: freebsd-ports-bugs->kde

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Max Brazhnikov freebsd_committer freebsd_triage 2009-01-23 09:14:51 UTC
Hi Jan,

Could you test this patch?

Cheers,
Max
Comment 3 me 2009-01-23 13:15:10 UTC
Using the patch, I did a portupgrade to kdeedu-4.1.4_2 and was able to 
produce a complete package.

I have not tested with the version I originally had the problem with, 
but since the configure output looks fine, I think the patch solves the 
problem.

If you insist on it, I could build again with kdeedu-4.1.4_1 installed 
but without the patch to see, if the library is really missing. I would 
rely on the configure output being the same as for the other upgrade.

Cheers,
Jan Henrik
Comment 4 Max Brazhnikov freebsd_committer freebsd_triage 2009-01-23 13:51:35 UTC
On Fri, 23 Jan 2009 14:15:10 +0100, Jan Henrik Sylvester wrote:
> Using the patch, I did a portupgrade to kdeedu-4.1.4_2 and was able to
> produce a complete package.
>
> I have not tested with the version I originally had the problem with,
> but since the configure output looks fine, I think the patch solves the
> problem.
>
> If you insist on it, I could build again with kdeedu-4.1.4_1 installed
> but without the patch to see, if the library is really missing. I would
> rely on the configure output being the same as for the other upgrade.

Thanks, I'll commit the patch then. Don't think extra testing is needed here.

Max
Comment 5 dfilter service freebsd_committer freebsd_triage 2009-01-23 14:11:14 UTC
makc        2009-01-23 14:11:02 UTC

  FreeBSD ports repository

  Modified files:
    misc/kdeedu4         Makefile 
  Log:
  Always build internal libsbigudrv. This fixes plist problem when rebuilding port.
  
  PR:             ports/130903
  Reported by:    Jan Henrik Sylvester <me at janh.de>
  Approved by:    miwi (implicit)
  
  Revision  Changes    Path
  1.47      +3 -2      ports/misc/kdeedu4/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Max Brazhnikov freebsd_committer freebsd_triage 2009-01-23 14:11:50 UTC
State Changed
From-To: open->closed

Committed. Thanks!