Bug 132571 - [patch] x11-wm/fvwm
Summary: [patch] x11-wm/fvwm
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-12 09:50 UTC by Bjoern A. Zeeb
Modified: 2009-03-14 21:04 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (33.42 KB, patch)
2009-03-12 09:50 UTC, Bjoern A. Zeeb
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bjoern A. Zeeb 2009-03-12 09:50:01 UTC
	FvwmWinList from fvwm1 regularly dumped core and
	on a latest 7-stable/amd64 and thus ended up being
	unusable.

Fix: The following patch made fvw, compile without any but one
	warning for me and also made FvwmWinList working again.
	Also see comments at the beginning of the patch.

	You can temporarily fetch the patch from:
	http://people.freebsd.org/~bz/x11-wm-fvwm-20090311.diff

	Note: lots of new patches in files/**.
	PORTREVISION bumped.

!
! - make fvwm compile w/o Warnings apart from one usage of mkstemp
!   by adding needed #includes, adding return statements to
!   non-void functions and declaring functions returning a int
!   instead of void if they do return an return code.
! - start using one central safemalloc.
! - do not mangle pointers which makes FvwmWinList work on
!   amd64/7-STABLE again.
! - ...
!
How-To-Repeat: 	
	Compile the port and install it on an up-to-date amd64
	freebsd/X machine.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-03-12 09:50:13 UTC
Responsible Changed
From-To: freebsd-ports-bugs->dinoex

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2009-03-14 20:10:39 UTC
dinoex      2009-03-14 20:10:24 UTC

  FreeBSD ports repository

  Modified files:
    x11-wm/fvwm          Makefile 
  Added files:
    x11-wm/fvwm/files    patch-ButtonArray.c patch-FvwmAudio.c 
                         patch-FvwmAuto.c 
                         patch-FvwmBacker-Mallocs.c 
                         patch-FvwmBacker-Mallocs.h 
                         patch-FvwmBacker.c patch-FvwmClean.c 
                         patch-FvwmClean.h patch-FvwmDebug.c 
                         patch-FvwmDebug.h patch-FvwmIconBox.c 
                         patch-FvwmIconBox.h patch-FvwmIdent.c 
                         patch-FvwmIdent.h patch-FvwmPager.c 
                         patch-FvwmPager.h patch-FvwmSave.c 
                         patch-FvwmSave.h patch-FvwmSaveDesk.c 
                         patch-FvwmSaveDesk.h patch-FvwmScroll.c 
                         patch-FvwmScroll.h 
                         patch-FvwmWinList-Mallocs.c 
                         patch-FvwmWinList-Mallocs.h 
                         patch-FvwmWinList.c patch-GoodStuff.c 
                         patch-GoodStuff.h patch-SendInfo.c 
                         patch-SendText.c patch-events.c 
                         patch-fvwm.c patch-fvwmlib.h 
                         patch-hostname.c patch-icons.c 
                         patch-mystrcasecmp.c patch-root_bits.c 
                         patch-safemalloc.c patch-xpmroot.c 
  Log:
  - make fvwm compile w/o Warnings apart from one usage of mkstemp
   by adding needed #includes, adding return statements to
   non-void functions and declaring functions returning a int
   instead of void if they do return an return code.
  - start using one central safemalloc.
  - do not mangle pointers which makes FvwmWinList work on
    amd64/7-STABLE again.
  PR:             132571
  Submitted by:   Bjoern A. Zeeb
  
  Revision  Changes    Path
  1.43      +1 -1      ports/x11-wm/fvwm/Makefile
  1.1       +10 -0     ports/x11-wm/fvwm/files/patch-ButtonArray.c (new)
  1.1       +11 -0     ports/x11-wm/fvwm/files/patch-FvwmAudio.c (new)
  1.1       +19 -0     ports/x11-wm/fvwm/files/patch-FvwmAuto.c (new)
  1.1       +11 -0     ports/x11-wm/fvwm/files/patch-FvwmBacker-Mallocs.c (new)
  1.1       +13 -0     ports/x11-wm/fvwm/files/patch-FvwmBacker-Mallocs.h (new)
  1.1       +19 -0     ports/x11-wm/fvwm/files/patch-FvwmBacker.c (new)
  1.1       +51 -0     ports/x11-wm/fvwm/files/patch-FvwmClean.c (new)
  1.1       +10 -0     ports/x11-wm/fvwm/files/patch-FvwmClean.h (new)
  1.1       +19 -0     ports/x11-wm/fvwm/files/patch-FvwmDebug.c (new)
  1.1       +10 -0     ports/x11-wm/fvwm/files/patch-FvwmDebug.h (new)
  1.1       +19 -0     ports/x11-wm/fvwm/files/patch-FvwmIconBox.c (new)
  1.1       +10 -0     ports/x11-wm/fvwm/files/patch-FvwmIconBox.h (new)
  1.1       +19 -0     ports/x11-wm/fvwm/files/patch-FvwmIdent.c (new)
  1.1       +10 -0     ports/x11-wm/fvwm/files/patch-FvwmIdent.h (new)
  1.1       +19 -0     ports/x11-wm/fvwm/files/patch-FvwmPager.c (new)
  1.1       +16 -0     ports/x11-wm/fvwm/files/patch-FvwmPager.h (new)
  1.1       +19 -0     ports/x11-wm/fvwm/files/patch-FvwmSave.c (new)
  1.1       +10 -0     ports/x11-wm/fvwm/files/patch-FvwmSave.h (new)
  1.1       +19 -0     ports/x11-wm/fvwm/files/patch-FvwmSaveDesk.c (new)
  1.1       +10 -0     ports/x11-wm/fvwm/files/patch-FvwmSaveDesk.h (new)
  1.1       +26 -0     ports/x11-wm/fvwm/files/patch-FvwmScroll.c (new)
  1.1       +8 -0      ports/x11-wm/fvwm/files/patch-FvwmScroll.h (new)
  1.1       +11 -0     ports/x11-wm/fvwm/files/patch-FvwmWinList-Mallocs.c (new)
  1.1       +13 -0     ports/x11-wm/fvwm/files/patch-FvwmWinList-Mallocs.h (new)
  1.1       +19 -0     ports/x11-wm/fvwm/files/patch-FvwmWinList.c (new)
  1.1       +28 -0     ports/x11-wm/fvwm/files/patch-GoodStuff.c (new)
  1.1       +10 -0     ports/x11-wm/fvwm/files/patch-GoodStuff.h (new)
  1.1       +9 -0      ports/x11-wm/fvwm/files/patch-SendInfo.c (new)
  1.1       +10 -0     ports/x11-wm/fvwm/files/patch-SendText.c (new)
  1.1       +11 -0     ports/x11-wm/fvwm/files/patch-events.c (new)
  1.1       +28 -0     ports/x11-wm/fvwm/files/patch-fvwm.c (new)
  1.1       +11 -0     ports/x11-wm/fvwm/files/patch-fvwmlib.h (new)
  1.1       +10 -0     ports/x11-wm/fvwm/files/patch-hostname.c (new)
  1.1       +11 -0     ports/x11-wm/fvwm/files/patch-icons.c (new)
  1.1       +10 -0     ports/x11-wm/fvwm/files/patch-mystrcasecmp.c (new)
  1.1       +10 -0     ports/x11-wm/fvwm/files/patch-root_bits.c (new)
  1.1       +21 -0     ports/x11-wm/fvwm/files/patch-safemalloc.c (new)
  1.1       +10 -0     ports/x11-wm/fvwm/files/patch-xpmroot.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Dirk Meyer freebsd_committer freebsd_triage 2009-03-14 21:04:16 UTC
State Changed
From-To: open->closed

committed, thanks.