Bug 132828 - devel/pth broken due to introduction of pthread_kill prototype in signal.h
Summary: devel/pth broken due to introduction of pthread_kill prototype in signal.h
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Vasil Dimov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-19 22:50 UTC by Rebecca Cran
Modified: 2010-05-01 11:37 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rebecca Cran freebsd_committer freebsd_triage 2009-03-19 22:50:01 UTC
svn rev 189828 of signal.h introduced the prototypes of pthread_kill and pthread_sigmask.  The pthread_kill prototype conflicts with that from pth's pthread.h file and therefore breaks the build:

===>  Building for pth-2.0.7
./libtool --mode=compile --quiet cc -c -I. -O2 -pipe -fno-strict-aliasing -funroll-loops -fstrength-reduce -fomit-frame-pointer -ffast-math pthread.c
In file included from pth_p.h.in:35,
                 from pthread.c:43:
/usr/include/signal.h:75: error: conflicting types for 'pthread_kill'
pthread.h:357: error: previous declaration of 'pthread_kill' was here
*** Error code 1

How-To-Repeat: cd /usr/ports/devel/pth && make
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2009-03-20 00:12:11 UTC
Responsible Changed
From-To: freebsd-bugs->vd

Over to maintainer.
Comment 2 Vasil Dimov freebsd_committer freebsd_triage 2009-03-20 14:06:45 UTC
State Changed
From-To: open->analyzed

This looks like a problem in signal.h, I have emailed the author of the 
change: 

http://lists.freebsd.org/pipermail/svn-src-all/2009-March/006623.html
Comment 3 Vasil Dimov freebsd_committer freebsd_triage 2009-04-12 19:54:39 UTC
State Changed
From-To: analyzed->patched

A patch for this has been committed. Can you confirm that it fixes 
the problem?
Comment 4 dfilter service freebsd_committer freebsd_triage 2009-04-12 20:11:41 UTC
vd          2009-04-12 18:53:44 UTC

  FreeBSD ports repository

  Added files:
    devel/pth/files      patch-pth_p.h.in 
  Log:
  Do not include signal.h because it seems not to be necessary and its
  inclusion breaks the compilation on FreeBSD 8.0. Limit this fix only
  to FreeBSD versions where the breakage occurs to be on the safe side.
  
  Thanks to das@, stas@, Coleman Kane, Peter Schuller and others that
  discussed this issue.
  
  PR:             ports/132828
  
  Revision  Changes    Path
  1.1       +13 -0     ports/devel/pth/files/patch-pth_p.h.in (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Vasil Dimov freebsd_committer freebsd_triage 2009-04-13 08:42:15 UTC
State Changed
From-To: patched->closed

Fixed.
Comment 6 Mark Linimon freebsd_committer freebsd_triage 2009-04-22 11:20:44 UTC
State Changed
From-To: closed->open

apparently still broken on -current.  Per markm, osreldate needs to be 
included before _FreeBSD_version can be used, so the patch is broken 
on -current.
Comment 7 dfilter service freebsd_committer freebsd_triage 2009-04-28 21:15:38 UTC
vd          2009-04-28 20:15:24 UTC

  FreeBSD ports repository

  Modified files:
    devel/pth/files      patch-pth_p.h.in 
  Log:
  Fix the patch for ports/132828 which erroneously checked
  __FreeBSD_version without including osreldate.h.
  
  Not tesed on 8-CURRENT with /usr/include/signal.h after
  Apr 17 (>= r191202). sledge is running r191005 from Apr 13,
  pointyhat from Mar 7 and tb3.droso.net from Feb 22.
  
  If this is still broken after the present patch then I will
  install 8-CURRENT in a qemu...
  
  Reported by:    linimon, markm
  PR:             ports/132828
  
  Revision  Changes    Path
  1.2       +13 -7     ports/devel/pth/files/patch-pth_p.h.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Vasil Dimov freebsd_committer freebsd_triage 2009-04-28 21:15:42 UTC
State Changed
From-To: open->patched

The patch has been adjusted to include osreldate.h, not tested on 
8-CURRENT after Apr 17. Can someone confirm that it works on a recent 
8-CURRENT? 

Thanks!
Comment 9 Bruce Cran freebsd_committer freebsd_triage 2010-05-01 11:37:01 UTC
State Changed
From-To: patched->closed

This issue appears to have been fixed.