Bug 133098 - [patch] mail/up-imapproxy hardcoded to use /etc/imapproxyd.conf, even though it uses autoconf
Summary: [patch] mail/up-imapproxy hardcoded to use /etc/imapproxyd.conf, even though ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Blapp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-26 16:50 UTC by Daniel Bond
Modified: 2010-01-02 22:40 UTC (History)
0 users

See Also:


Attachments
file.diff (1.10 KB, patch)
2009-03-26 16:50 UTC, Daniel Bond
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bond 2009-03-26 16:50:04 UTC
After upgrading up-imapproxyd, the binaries it provides no longer works (in.imapproxy and pimpstat), without manually specifying path to config-file (with -f option). The reason is that the package uses a "define" to hardcode the location of it's configfile, unless it is allready set. The autoconfig ./configure script fails to set it up, resulting in following static location

#ifndef DEFAULT_CONFIG_FILE
#define DEFAULT_CONFIG_FILE     "/etc/imapproxy.conf"
#endif
 
I have tried to notify the software creator, but not sure if my message has been noticed (or active, the website died about a week ago).

Fix: The provided patch adds a definition of DEFAULT_CONFIG_FILE in config.h (based on --sysconfdir=..), overriding the static one. The port Makefile has been modified to run "autoheader" and "autoconf", to generate a updated ./configure -script.



Patch attached with submission follows:
How-To-Repeat: Install or upgrade the ports/mail/up-imapproxyd, and use any part of it.
"/usr/local/etc/rc.d/imapproxyd start" will fail to use correct config file
"/usr/local/sbin/pimpstat" will fail to use correct config file
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2009-03-26 19:06:47 UTC
Responsible Changed
From-To: freebsd-ports-bugs->mbr

Fix synopsis and assign.
Comment 2 dfilter service freebsd_committer freebsd_triage 2010-01-02 22:31:01 UTC
mbr         2010-01-02 22:30:52 UTC

  FreeBSD ports repository

  Modified files:
    mail/up-imapproxy    Makefile 
  Added files:
    mail/up-imapproxy/files patch-configure.in 
  Log:
  Fix hardcoded use of /etc/imapproxyd.conf with autoconf
  Remove unneeded postpatch section
  
  Other PRs just set the default location of the
  default config file:  ports/142247 ports/125655 ports/122422
  
  PR:             ports/133098
  Submitted by:   Daniel Bond <db@danielbond.org>
  
  Revision  Changes    Path
  1.17      +3 -6      ports/mail/up-imapproxy/Makefile
  1.3       +12 -0     ports/mail/up-imapproxy/files/patch-configure.in (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Martin Blapp freebsd_committer freebsd_triage 2010-01-02 22:31:40 UTC
State Changed
From-To: open->closed

Committed, thanks. Sorry that it took so long.