Bug 133555 - fix for lang/tclX
Summary: fix for lang/tclX
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-10 02:40 UTC by mitsuru
Modified: 2009-05-12 12:02 UTC (History)
0 users

See Also:


Attachments
file.diff (1.99 KB, patch)
2009-04-10 02:40 UTC, mitsuru
no flags Details | Diff
tclX-ubreak.diff (10.90 KB, patch)
2009-04-10 03:35 UTC, Mikhail T.
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitsuru 2009-04-10 02:40:06 UTC
	lang/tclX port has been marked as BROKEN. This is a fix.
        Since lang/tcl84 was changed not to install man pages by default,
        you have to check if the man pages exists or not.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-04-10 02:40:14 UTC
Maintainer of lang/tclX,

Please note that PR ports/133555 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/133555

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-04-10 02:40:16 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Mikhail T. 2009-04-10 03:35:48 UTC
I was looking at this problem at a different angle -- if the top-level
Makefile does not see Tcl's man-pages, it will treat the situation as if
NOPORTDOCS were specified. Can you check the attached diff, please? I
think, it is simpler than yours... The diff also includes two new
patches, which quite down some warnings (perhaps, even fix bugs).

Thank you! Yours,

    -mi

P.S. Sadly, simply switching to Tcl 8.5 is not an option -- one of the
self-tests crashes with seg-fault, which is very bad... I wish, somebody
fixed /that/...
Comment 4 mitsuru 2009-04-10 05:30:23 UTC
> I was looking at this problem at a different angle -- if the top-level
> Makefile does not see Tcl's man-pages, it will treat the situation as if
> NOPORTDOCS were specified. Can you check the attached diff, please? I
> think, it is simpler than yours... The diff also includes two new
> patches, which quite down some warnings (perhaps, even fix bugs).
 It works. Thank you!

-mitsuru
Comment 5 dfilter service freebsd_committer freebsd_triage 2009-04-21 08:52:45 UTC
mi          2009-04-21 07:52:36 UTC

  FreeBSD ports repository

  Modified files:
    lang/tclX            Makefile 
  Added files:
    lang/tclX/files      patch-const patch-intptr 
  Log:
  Ubreak by making the port check for availability of Tcl's man-pages.
  Tcl-8.4 does not install those by default any more...
  
  Approved by:    portmgr (erwin)
  PR:     ports/133555
  
  Revision  Changes    Path
  1.61      +9 -7      ports/lang/tclX/Makefile
  1.1       +184 -0    ports/lang/tclX/files/patch-const (new)
  1.1       +124 -0    ports/lang/tclX/files/patch-intptr (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Pav Lucistnik freebsd_committer freebsd_triage 2009-05-12 12:02:03 UTC
State Changed
From-To: feedback->closed

Close forgotten PR