Ncat uses getaddrinfo(3) to resolve hostnames and always passes it a numerical service string. FreeBSD getaddrinfo(3) until recently was broken with numerical service strings (see PR bin/51827). This patch adds a workaround for FreeBSD versions with broken getaddrinfo(3), fixing Ncat where it is currently unable to resolve any hostnames. svn add files/patch-ncat__ncat_core.c How-To-Repeat: ncat -v localhost 80
Responsible Changed From-To: freebsd-ports-bugs->wxs I'll take it.
If I am reading this patch correctly this does not apply to the upcoming 7.2 release. If this is incorrect please let me know so I can get portmgr approval to commit it, otherwise it will wait until after the freeze is over. -- WXS
Wesley Shields <wxs@FreeBSD.org> 2009-04-16: > If I am reading this patch correctly this does not apply to the > upcoming 7.2 release. If this is incorrect please let me know > so I can get portmgr approval to commit it, otherwise it will > wait until after the freeze is over. Correct. RELENG_7_2 has the fixed getaddrinfo(3); the Ncat patch is only required for compatibility with 7.1 and earlier release branches (and 8.0 before the end of March 2009). I should have stated that more clearly. -- Daniel Roethlisberger http://daniel.roe.ch/
On Thu, Apr 16, 2009 at 05:00:36PM +0200, Daniel Roethlisberger wrote: > Wesley Shields <wxs@FreeBSD.org> 2009-04-16: > > If I am reading this patch correctly this does not apply to the > > upcoming 7.2 release. If this is incorrect please let me know > > so I can get portmgr approval to commit it, otherwise it will > > wait until after the freeze is over. > > Correct. RELENG_7_2 has the fixed getaddrinfo(3); the Ncat patch > is only required for compatibility with 7.1 and earlier release > branches (and 8.0 before the end of March 2009). I should have > stated that more clearly. Great, thank you for the clarification. I will queue this up to go into the tree after the freeze has ended. Thank you for your work on this. -- WXS
wxs 2009-04-21 15:36:56 UTC FreeBSD ports repository Modified files: security/nmap Makefile Added files: security/nmap/files patch-ncat__ncat_core.c Log: - Add patch to work around versions of FreeBSD with broken getaddrinfo(3) (7.1 and earlier, and -CURRENT before the end of March 2009). PR: ports/133779 Submitted by: Daniel Roethlisberger <daniel@roe.ch> (maintainer) Revision Changes Path 1.115 +1 -0 ports/security/nmap/Makefile 1.1 +33 -0 ports/security/nmap/files/patch-ncat__ncat_core.c (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!