Previous to the import of mplayer's libdvdread to multimedia/libdvdread the libdvdread depended on multimedia/libdvdcss to read encrypted DVDs, and that dependancy was hard wired in to the port. After the import, the dependancy vanished completely. My assumption was the libdvdread project had somehow internalized the decrypting of DVDs, but it turns out this is not the case. It still needs libdvdcss, and builds against it if it is there. This was exposed by the shared library bump that the new version of libdvdcss underwent. I also went ahead and duped maintainership of multimedia/libdvdread and set it for removal, since it apparently had no more uses. I'll be reversing that, we also need to figure out a way to make this a dependancy again, as well as sort out the shared library bump. I suggest making it an OPTION, but I'm torn on whether it should default to on or off. I'll be sending patches later today. How-To-Repeat: Attempt to read an encrypted DVD using anything that depends on libdvdread without having it built against libdvdcss
Responsible Changed From-To: freebsd-ports-bugs->jpaetzel Submitter has GNATS access (via the GNATS Auto Assign Tool)
Maintainer of multimedia/libdvdread, Please note that PR ports/134016 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/134016 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
--- Makefile.old 2009-04-26 23:09:31.000000000 +0000 +++ Makefile 2009-04-26 23:39:28.000000000 +0000 @@ -7,6 +7,7 @@ PORTNAME= libdvdread PORTVERSION= 4.1.3 +PORTREVISION= 1 CATEGORIES= multimedia MASTER_SITES= http://www1.mplayerhq.hu/MPlayer/releases/dvdnav/ \ http://www2.mplayerhq.hu/MPlayer/releases/dvdnav/ \ @@ -36,6 +37,17 @@ USE_GMAKE= yes USE_LDCONFIG= yes +OPTIONS= LIBDVDCSS "Support for encrypted DVDs" on + +.if !defined(PACKAGE_BUILDING) && defined(WITH_LIBDVDCSS) +LIB_DEPENDS= dvdcss.${DVDCSS_LIBVERSION}:${PORTSDIR}/multimedia/ libdvdcss +.endif + +# ugly hack to have libdvdread directly depend on libdvdcss since +# it already does for practical reasons even though not for compile +# time ones +DVDCSS_LIBVERSION= 3 + post-patch: @${REINPLACE_CMD} -e 's|-ldl ||g' \ ${WRKSRC}/Makefile
On Sun, 26 Apr 2009 13:40:19 -0500, Josh Paetzel wrote Hello Josh, > +OPTIONS= LIBDVDCSS "Support for encrypted DVDs" on > + > +.if !defined(PACKAGE_BUILDING) && defined(WITH_LIBDVDCSS) > +LIB_DEPENDS= dvdcss.${DVDCSS_LIBVERSION}:${PORTSDIR}/multimedia/ > libdvdcss > +.endif Thanks for your patch. Unfortunately, libdvdcss is dlopen'ed by libdvdread, so one cannot avoid using it with this kind of option (if is is present on the system, it will be loaded anyway) and that may lead to confusion. I think we should follow the old behaviour (see the attached patch). Also, thanks for having removed the DEPRECATED flag from libdvdcss ! Ganaël LAPLANCHE ganael.laplanche@martymac.com http://www.martymac.com
jpaetzel 2009-04-27 17:54:33 UTC FreeBSD ports repository Modified files: multimedia/libdvdread Makefile Log: Restore functionaity to read encrypted DVDs. PR: ports/134016 Approved by: linimon (mentor) Revision Changes Path 1.32 +10 -0 ports/multimedia/libdvdread/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, thanks!