Recently, the Broadcom Wireless driver (bwi) was imported into 8.0-CURRENT. This port provides the firmware kernel module required by bwi. Fix: Extract the port from the attached shar archive. Patch attached with submission follows:
Class Changed From-To: sw-bug->change-request Fix category (new ports should be change-requests) (via the GNATS Auto Assign Tool)
State Changed From-To: open->feedback imp just committed net/bwi-firmware-kmod, but it looks different than this one. Can you comment, please?
Responsible Changed From-To: freebsd-ports-bugs->linimon track.
----- Forwarded message from Scot Hetzel <swhetzel@gmail.com> ----- From: Scot Hetzel <swhetzel@gmail.com> To: "linimon@freebsd.org" <linimon@freebsd.org> Cc: freebsd-ports-bugs@freebsd.org Subject: Re: ports/134371: New port - net/bwi-firmware-kmod On 5/12/09, linimon@freebsd.org <linimon@freebsd.org> wrote: > imp just committed net/bwi-firmware-kmod, but it looks different > than this one. Can you comment, please? Both ports install the same firmware kernel module, the only difference is that the port I created used the extracted firmware, and uses kldxref to update the linker.hints file on package install/deinstall. I have attached a new patch against the current port. This patches adds a BUILD_DEPENDS on the sysutils/b43-fwcutter port, and the missing kldxref to pkg-plist. Scot Index: Makefile =================================================================== RCS file: /home/ncvs/ports/net/bwi-firmware-kmod/Makefile,v retrieving revision 1.1 diff -u -r1.1 Makefile --- Makefile 9 May 2009 21:41:50 -0000 1.1 +++ Makefile 13 May 2009 16:24:10 -0000 @@ -9,14 +9,16 @@ PORTVERSION= ${FWVERSION} CATEGORIES= net kld MASTER_SITES= http://downloads.openwrt.org/sources/ \ - http://people.freebsd.org/~thompsa/:fwcutter + http://mirror2.openwrt.org/sources PKGNAMESUFFIX= -kmod -DISTFILES= ${FWFILE} b43-fwcutter-freebsd.tar.bz2:fwcutter -EXTRACT_ONLY= b43-fwcutter-freebsd.tar.bz2 +DISTFILES= ${FWFILE} +EXTRACT_ONLY= MAINTAINER= ports@FreeBSD.org COMMENT= Broadcom AirForce IEEE 802.11 Firmware Kernel Module +BUILD_DEPENDS= b43-fwcutter:${PORTSDIR}/sysutils/b43-fwcutter + FIRMWARES= ucode ucode11 ucode2 ucode4 ucode5 \ a0g0bsinitvals2 a0g0bsinitvals5 a0g0initvals2 \ a0g0initvals5 a0g1bsinitvals5 a0g1initvals5 \ @@ -38,10 +40,7 @@ do-build: cd ${WRKSRC} && \ - ${CC} ${CFLAGS} -DFWCUTTER_VERSION_=008 -c fwcutter.c && \ - ${CC} ${CFLAGS} -DFWCUTTER_VERSION_=008 -c md5.c && \ - ${CC} ${CFLAGS} -o b43-fwcutter fwcutter.o md5.o - ${WRKSRC}/b43-fwcutter -w ${WRKSRC} ${DISTDIR}/${FWFILE} + b43-fwcutter -w ${WRKSRC} ${DISTDIR}/${FWFILE} ${TOUCH} ${WRKSRC}/v3/ucode.fw @${ECHO_CMD} "KMOD= ${KMODNAME}" > ${WRKSRC}/v3/Makefile Index: pkg-plist =================================================================== RCS file: /home/ncvs/ports/net/bwi-firmware-kmod/pkg-plist,v retrieving revision 1.1 diff -u -r1.1 pkg-plist --- pkg-plist 9 May 2009 21:41:50 -0000 1.1 +++ pkg-plist 13 May 2009 16:14:46 -0000 @@ -1,2 +1,4 @@ @cwd %%KMODDIR%% %%KMODNAME%%.ko +@exec kldxref %%KMODDIR%% +@unexec kldxref %%KMODDIR%% _______________________________________________ freebsd-ports-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org" ----- End forwarded message -----
On Wed, May 13, 2009 at 11:47:49AM -0500, Scot Hetzel wrote: > I have attached a new patch against the current port. This patches > adds a BUILD_DEPENDS on the sysutils/b43-fwcutter port, and the > missing kldxref to pkg-plist. OK. Apparently the port was added without a maintainer, which is intended to be a no-no. Would you be interested in maintaining it? mcl
State Changed From-To: feedback->open Feedback received.
On Wed, May 13, 2009 at 11:54 AM, Mark Linimon <linimon@lonesome.com> wrote= : > On Wed, May 13, 2009 at 11:47:49AM -0500, Scot Hetzel wrote: >> I have attached a new patch against the current port. =A0This patches >> adds a BUILD_DEPENDS on the sysutils/b43-fwcutter port, and the >> missing kldxref to pkg-plist. > > OK. =A0Apparently the port was added without a maintainer, which is > intended to be a no-no. =A0Would you be interested in maintaining it? > You can set me to be the maintainer of the port. Scot
Class Changed From-To: change-request->maintainer-update Submitter has agreed to be maintainer of the port that was already committed by the same name, and has included a patch to update it.
Responsible Changed From-To: linimon->freebsd-ports-bugs
Responsible Changed From-To: freebsd-ports-bugs->wxs I'll take it.
State Changed From-To: open->closed Committed. Thanks!
wxs 2009-05-16 00:04:10 UTC FreeBSD ports repository Modified files: net/bwi-firmware-kmod Makefile pkg-plist Log: - Add BUILD_DEPENDS on sysutils/b43-fwcutter. - Add kldxref to plist. PR: ports/134371 Submitted by: "Scot W. Hetzel" <swhetzel@gmail.com> (maintainer) Revision Changes Path 1.3 +6 -7 ports/net/bwi-firmware-kmod/Makefile 1.2 +2 -0 ports/net/bwi-firmware-kmod/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"