Bug 134477 - x11-wm/awesome 3.3-rc1 awesome-client broken (defaults to /bin/bash)
Summary: x11-wm/awesome 3.3-rc1 awesome-client broken (defaults to /bin/bash)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-12 03:10 UTC by Guillermo Antonio Amaral Bastidas
Modified: 2009-05-12 17:50 UTC (History)
0 users

See Also:

Attachments
file.diff (420 bytes, patch)
2009-05-12 03:10 UTC, Guillermo Antonio Amaral Bastidas 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guillermo Antonio Amaral Bastidas 2009-05-12 03:10:01 UTC 
I noticed most of my external apps using awesome-client died on me on the last update to 3.3-rc1, after looking at the script it seems it has been set to look for bash in /bin/bash.

Fix: By replacing /bin/bash with /bin/sh, I see no problems running it with plain sh instead of bash ATM.

You can even see a comment about that in /usr/local/bin/awsetbg:43

Patch attached with submission follows:
How-To-Repeat: Try to run awesome-client.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-05-12 03:10:12 UTC 
Class Changed
From-To: maintainer-update->change-request

Fix category (submitter is not maintainer) (via the GNATS Auto Assign 
Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-05-12 03:10:14 UTC 
Maintainer of x11-wm/awesome,

Please note that PR ports/134477 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/134477

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2009-05-12 03:10:16 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Nikos Ntarmos 2009-05-12 09:46:46 UTC 
Thanks for the report and patch.

This is a known bug that has been fixed upstream along with other
bash-isms and will be in the upcoming -rc3 or 3.3-release (coming out
any time now). I'd suggest waiting for that (won't be more than a couple
of days till the next rc/rel).

Cheers.

\n\n
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2009-05-12 15:10:55 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.
Comment 6 dfilter service freebsd_committer freebsd_triage 2009-05-12 17:42:31 UTC 
amdmi3      2009-05-12 16:42:22 UTC

  FreeBSD ports repository

  Modified files:
    x11-wm/awesome       Makefile 
  Added files:
    x11-wm/awesome/files patch-build-utils-gperf.sh 
                         patch-lib-awful-util.lua.in 
                         patch-utils-awesome-client 
  Log:
  - Fix bashisms and eliminate (implicit) bash requirement
  
  PR:             134477
  Submitted by:   Guillermo Antonio Amaral Bastidas <gamaral at amaral dot com dot mx>
  Fix by:         Nikos Ntarmos <ntarmos at cs dot uoi dot gr> (maintainer)
  
  Revision  Changes    Path
  1.25      +4 -0      ports/x11-wm/awesome/Makefile
  1.1       +54 -0     ports/x11-wm/awesome/files/patch-build-utils-gperf.sh (new)
  1.1       +22 -0     ports/x11-wm/awesome/files/patch-lib-awful-util.lua.in (new)
  1.1       +21 -0     ports/x11-wm/awesome/files/patch-utils-awesome-client (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Dmitry Marakasov freebsd_committer freebsd_triage 2009-05-12 17:42:33 UTC 
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!