The port Makefile defines $(JSH), a list of header files to be installed. In building a 3rd party app I discovered my installed port is missing "jsdate.h". Upon further investigation it seems that the port may be missing several other header files. Fix: Sorry, I am not familiar enough with SpiderMonkey to know the right solution here. Adding jsdate.h to Makefile's $(JSH) solves my issue however Makefile.ref within the SpiderMonkey source defines almost 30 header files, and I wonder if they should all be installed.
Maintainer of lang/spidermonkey, Please note that PR ports/134770 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/134770 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Thanks for catching this. The patch below adds jsdate.h along with the other missing .h files from Makefile.ref: diff --git a/Makefile b/Makefile index 93febaf..d063b3b 100644 --- a/Makefile +++ b/Makefile @@ -32,9 +32,16 @@ ALL_TARGET= ${OPSYS}`${UNAME} -r`_DBG.OBJ/js MAKE_ENV+= CCC="${CXX}" USE_LDCONFIG= yes SRC_DIR= js/src -JSH= jsapi.h jsautocfg.h jsconfig.h jscompat.h jslong.h jsosdep.h \ - jsotypes.h jspubtd.h jstypes.h jsstr.h jshash.h jsprvtd.h \ + +JSH= jsapi.h jsarena.h jsarray.h jsatom.h jsautocfg.h jsbool.h \ + jsclist.h jscntxt.h jscompat.h jsconfig.h jsdate.h jsdhash.h \ + jsdtoa.h jsemit.h jsexn.h jsfun.h jsgc.h jshash.h jsinterp.h \ + jsiter.h jslibmath.h jslock.h jslong.h jsmath.h jsnum.h jsobj.h \ + jsopcode.h jsosdep.h jsotypes.h jsparse.h jsprvtd.h jspubtd.h \ + jsregexp.h jsscan.h jsscope.h jsscript.h jsstr.h jstypes.h \ + jsxdrapi.h jsxml.h \ jsproto.tbl + PLIST_FILES= bin/js lib/libjs.so lib/libjs.so.1 ${JSH:S,^,include/,} WRKSRC= ${WRKDIR}/${SRC_DIR} EXTRACT_AFTER_ARGS=| ${TAR} -xf - \
Sorry I missed your reply as it got caught in my spam filters. This works great. Thanks for the speedy response. :) At 05:34 AM 27/05/2009, Dan Rench wrote: >Thanks for catching this. > >The patch below adds jsdate.h along with the other missing .h files >from Makefile.ref: >[snip] -- (__) Share what you know. Yun Huang Yong `\------(oo) Learn what you don't. gumby@mooh.org || (__) --' goosmurf@yahoo.com \|/ ||w--|| \|/ --
Responsible Changed From-To: freebsd-ports-bugs->pgollucci approved
State Changed From-To: feedback->open Maintainer has approved.
State Changed From-To: open->closed Committed. Thanks!
pgollucci 2009-06-23 19:47:12 UTC FreeBSD ports repository Modified files: lang/spidermonkey Makefile Log: - Fix pkg-plist (install all header files) PR: ports/134770 Submitted by: Dan Rench <citric@cubicone.tmetic.com> Approved by: maintainer Revision Changes Path 1.25 +11 -7 ports/lang/spidermonkey/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"