When compiling VLC with WITHOUT_X11=1, the port will fail to compile due to dependency on libglx. Specifically, the source's configure script will fail. Fix: In Makefile, disable glx if X11 is also disabled. .if defined(WITHOUT_X11) CONFIGURE_ARGS+=--disable-x11 \ --disable-glx .else USE_XORG= xpm CONFIGURE_ARGS+=--enable-x11 \ --enable-glx .endif How-To-Repeat: cd /usr/ports/multimedia/vlc make WITHOUT_LIBNOTIFY=1 WITHOUT_HAL=1 WITHOUT_OPENGL=1 WITHOUT_X11=1 WITHOUT_V4L=1 package
Maintainer of multimedia/vlc, Please note that PR ports/135018 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/135018 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Quick not to acknowledge this. I will not have time to look at this until the weekend (June 4th at earliest). Sorry.
Responsible Changed From-To: freebsd-ports-bugs->pgollucci I'll take it.
I've found that I need to disable quite a bit more (patch attached) to get vlc to compile on a headless system. I've disabled installing content from libdata if WITHOUT_X11 is set, but I don't think this is right. Instead, it should probably depend upon one or more of the options that WITHOUT_X11 also turns off, but I don't have any easy way to ascertain what.
Updated patch against the latest vlc port.
Close. Incorporated into ports/139114 which I am approving.
thierry 2009-11-02 22:51:27 UTC FreeBSD ports repository Modified files: multimedia/vlc Makefile Makefile.inc distinfo multimedia/vlc/files patch-v4l Added files: multimedia/vlc/files patch-configure-dvbpsi Removed files: multimedia/vlc/files patch-modules__access__file.c Log: Upgrade to 1.0.2 and fix a security issue: see <http://www.videolan.org/security/sa0901.html>. Also include fixes from PR ports/135018 to fix build when WITHOUT_X11 is defined. PR: ports/139114 (1) ports/135018 (2) Submitted by: Christopher Key <cjk32 (at) cam.ac.uk> (1) Nick Triantos <nick-freebsd (at) triantos.com> (2) Approved by: Joseph S. Atkinson <jsa.bsd (at) gmail.com> (maintainer) Security: VideoLAN-SA-0901 (CVE Pending) Revision Changes Path 1.197 +18 -14 ports/multimedia/vlc/Makefile 1.24 +6 -2 ports/multimedia/vlc/Makefile.inc 1.32 +3 -3 ports/multimedia/vlc/distinfo 1.1 +20 -0 ports/multimedia/vlc/files/patch-configure-dvbpsi (new) 1.2 +0 -10 ports/multimedia/vlc/files/patch-modules__access__file.c (dead) 1.4 +0 -11 ports/multimedia/vlc/files/patch-v4l _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Approved by maintainer, and tested in my tinderbox. Committed with PR ports/139114: thanks for your patch!
Responsible Changed From-To: pgollucci->thierry Closed on pgollucci's behalf, due to ApacheCon US 2009.