Maintainer of mail/postfix, Please note that PR ports/135051 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/135051 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
A better way to handle this is by appending the files to be installed to ${WRKSRC}/conf/postfix-files thus making postfix aware of them rather than brute forcing the install. Other than the SOHO_README, the other two files are just placeholders and were likely omitted for good reason by the Postfix camp upstream. With my version of the patch the installer even spits out: Note: the following files or directories still exist but are no longer part of Postfix: /usr/local/share/doc/postfix/QMQP_README So I do not know if it is even the correct thing to do installing the QMQP_README and/or CYRUS_README placeholders. -- Yarema
Make package failed. Plaintext readme files are not installed, but are in plist, html files are installed. Broken plist or makefile? FreeBSD 7.2-RELEASE #0: Fri May 1 08:49:13 UTC 2009 root@walker.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 ~/# grep postfix /usr/local/etc/ports.conf mail/postfix: POSTFIX_DEFAULT_MTA=true | WITH_PCRE=true | WITH_SASL2=true | WITH_TLS=true | WITH_BDB=true | WITH_MYSQL=true | WITH_VDA=true | WITH_TEST=true | BATCH=true ~/# cat /var/db/ports/postfix/options # This file is auto-generated by 'make config'. # No user-servicable parts inside! # Options for postfix-2.4.6,1 _OPTIONS_READ=postfix-2.4.6,1 WITH_PCRE=true WITH_SASL2=true WITHOUT_DOVECOT=true WITHOUT_SASLKRB=true WITHOUT_SASLKRB5=true WITHOUT_SASLKMIT=true WITH_TLS=true WITH_BDB=true WITH_MYSQL=true WITHOUT_PGSQL=true WITHOUT_OPENLDAP=true WITHOUT_CDB=true WITHOUT_NIS=true WITH_VDA=true WITH_TEST=true Creating a package for postfix-2.6.1,1 [...] tar: share/doc/postfix/AAAREADME: Cannot stat: No such file or directory tar: share/doc/postfix/ADDRESS_CLASS_README: Cannot stat: No such file or directory tar: share/doc/postfix/ADDRESS_REWRITING_README: Cannot stat: No such file or directory tar: share/doc/postfix/ADDRESS_VERIFICATION_README: Cannot stat: No such file or directory tar: share/doc/postfix/BACKSCATTER_README: Cannot stat: No such file or directory tar: share/doc/postfix/BASIC_CONFIGURATION_README: Cannot stat: No such file or directory tar: share/doc/postfix/BUILTIN_FILTER_README: Cannot stat: No such file or directory tar: share/doc/postfix/CDB_README: Cannot stat: No such file or directory tar: share/doc/postfix/CONNECTION_CACHE_README: Cannot stat: No such file or directory tar: share/doc/postfix/CONTENT_INSPECTION_README: Cannot stat: No such file or directory tar: share/doc/postfix/DATABASE_README: Cannot stat: No such file or directory tar: share/doc/postfix/DB_README: Cannot stat: No such file or directory tar: share/doc/postfix/DEBUG_README: Cannot stat: No such file or directory tar: share/doc/postfix/DSN_README: Cannot stat: No such file or directory tar: share/doc/postfix/ETRN_README: Cannot stat: No such file or directory tar: share/doc/postfix/FILTER_README: Cannot stat: No such file or directory tar: share/doc/postfix/INSTALL: Cannot stat: No such file or directory tar: share/doc/postfix/IPV6_README: Cannot stat: No such file or directory tar: share/doc/postfix/TLS_README: Cannot stat: No such file or directory tar: share/doc/postfix/LDAP_README: Cannot stat: No such file or directory tar: share/doc/postfix/LINUX_README: Cannot stat: No such file or directory tar: share/doc/postfix/LOCAL_RECIPIENT_README: Cannot stat: No such file or directory tar: share/doc/postfix/MAILDROP_README: Cannot stat: No such file or directory tar: share/doc/postfix/MILTER_README: Cannot stat: No such file or directory tar: share/doc/postfix/MULTI_INSTANCE_README: Cannot stat: No such file or directory tar: share/doc/postfix/MYSQL_README: Cannot stat: No such file or directory tar: share/doc/postfix/NFS_README: Cannot stat: No such file or directory tar: share/doc/postfix/OVERVIEW: Cannot stat: No such file or directory tar: share/doc/postfix/PACKAGE_README: Cannot stat: No such file or directory tar: share/doc/postfix/PCRE_README: Cannot stat: No such file or directory tar: share/doc/postfix/PGSQL_README: Cannot stat: No such file or directory tar: share/doc/postfix/QSHAPE_README: Cannot stat: No such file or directory tar: share/doc/postfix/RELEASE_NOTES: Cannot stat: No such file or directory tar: share/doc/postfix/RESTRICTION_CLASS_README: Cannot stat: No such file or directory tar: share/doc/postfix/SASL_README: Cannot stat: No such file or directory tar: share/doc/postfix/SCHEDULER_README: Cannot stat: No such file or directory tar: share/doc/postfix/SMTPD_ACCESS_README: Cannot stat: No such file or directory tar: share/doc/postfix/SMTPD_POLICY_README: Cannot stat: No such file or directory tar: share/doc/postfix/SMTPD_PROXY_README: Cannot stat: No such file or directory tar: share/doc/postfix/STANDARD_CONFIGURATION_README: Cannot stat: No such file or directory tar: share/doc/postfix/STRESS_README: Cannot stat: No such file or directory tar: share/doc/postfix/TLS_LEGACY_README: Cannot stat: No such file or directory tar: share/doc/postfix/TUNING_README: Cannot stat: No such file or directory tar: share/doc/postfix/ULTRIX_README: Cannot stat: No such file or directory tar: share/doc/postfix/UUCP_README: Cannot stat: No such file or directory tar: share/doc/postfix/VDA_README: Cannot stat: No such file or directory tar: share/doc/postfix/VERP_README: Cannot stat: No such file or directory tar: share/doc/postfix/VIRTUAL_README: Cannot stat: No such file or directory tar: share/doc/postfix/XCLIENT_README: Cannot stat: No such file or directory tar: share/doc/postfix/XFORWARD_README: Cannot stat: No such file or directory tar: Error exit delayed from previous errors. pkg_create: make_dist: tar command failed with code 256 ~/# ls -al /usr/local/share/doc/postfix/ total 2644 dr-xr-xr-x 2 root wheel 3584 May 30 11:42 . drwxr-xr-x 51 root wheel 1024 May 30 11:44 .. -r--r--r-- 1 root wheel 13430 May 30 11:42 ADDRESS_CLASS_README.html -r--r--r-- 1 root wheel 51892 May 30 11:42 ADDRESS_REWRITING_README.html -r--r--r-- 1 root wheel 24789 May 30 11:42 ADDRESS_VERIFICATION_README.html -r--r--r-- 1 root wheel 14687 May 30 11:42 BACKSCATTER_README.html -r--r--r-- 1 root wheel 28469 May 30 11:42 BASIC_CONFIGURATION_README.html -r--r--r-- 1 root wheel 16749 May 30 11:42 BUILTIN_FILTER_README.html -r--r--r-- 1 root wheel 3342 May 30 11:42 CDB_README.html -r--r--r-- 1 root wheel 12009 May 30 11:42 CONNECTION_CACHE_README.html -r--r--r-- 1 root wheel 3659 May 30 11:42 CONTENT_INSPECTION_README.html -r--r--r-- 1 root wheel 15669 May 30 11:42 DATABASE_README.html -r--r--r-- 1 root wheel 7872 May 30 11:42 DB_README.html -r--r--r-- 1 root wheel 20978 May 30 11:42 DEBUG_README.html -r--r--r-- 1 root wheel 5265 May 30 11:42 DSN_README.html -r--r--r-- 1 root wheel 14119 May 30 11:42 ETRN_README.html -r--r--r-- 1 root wheel 36706 May 30 11:42 FILTER_README.html -r--r--r-- 1 root wheel 35330 May 30 11:42 INSTALL.html -r--r--r-- 1 root wheel 14517 May 30 11:42 IPV6_README.html -r--r--r-- 1 root wheel 22672 May 30 11:42 LDAP_README.html -r--r--r-- 1 root wheel 1918 May 30 11:42 LINUX_README.html -r--r--r-- 1 root wheel 7894 May 30 11:42 LOCAL_RECIPIENT_README.html -r--r--r-- 1 root wheel 6956 May 30 11:42 MAILDROP_README.html -r--r--r-- 1 root wheel 31412 May 30 11:42 MILTER_README.html -r--r--r-- 1 root wheel 55343 May 30 11:42 MULTI_INSTANCE_README.html -r--r--r-- 1 root wheel 5299 May 30 11:42 MYSQL_README.html -r--r--r-- 1 root wheel 5317 May 30 11:42 NFS_README.html -r--r--r-- 1 root wheel 30754 May 30 11:42 OVERVIEW.html -r--r--r-- 1 root wheel 5225 May 30 11:42 PACKAGE_README.html -r--r--r-- 1 root wheel 3521 May 30 11:42 PCRE_README.html -r--r--r-- 1 root wheel 5236 May 30 11:42 PGSQL_README.html -r--r--r-- 1 root wheel 46956 May 30 11:42 QSHAPE_README.html -r--r--r-- 1 root wheel 8682 May 30 11:42 RESTRICTION_CLASS_README.html -r--r--r-- 1 root wheel 27600 May 30 11:42 SASL_README.html -r--r--r-- 1 root wheel 73311 May 30 11:42 SCHEDULER_README.html -r--r--r-- 1 root wheel 17543 May 30 11:42 SMTPD_ACCESS_README.html -r--r--r-- 1 root wheel 23668 May 30 11:42 SMTPD_POLICY_README.html -r--r--r-- 1 root wheel 14539 May 30 11:42 SMTPD_PROXY_README.html -r--r--r-- 1 root wheel 15265 May 30 11:42 SOHO_README.html -r--r--r-- 1 root wheel 31813 May 30 11:42 STANDARD_CONFIGURATION_README.html -r--r--r-- 1 root wheel 23254 May 30 11:42 STRESS_README.html -r--r--r-- 1 root wheel 66200 May 30 11:42 TLS_LEGACY_README.html -r--r--r-- 1 root wheel 123273 May 30 11:42 TLS_README.html -r--r--r-- 1 root wheel 29406 May 30 11:42 TUNING_README.html -r--r--r-- 1 root wheel 6479 May 30 11:42 UUCP_README.html -r--r--r-- 1 root wheel 8876 May 30 11:42 VERP_README.html -r--r--r-- 1 root wheel 29785 May 30 11:42 VIRTUAL_README.html -r--r--r-- 1 root wheel 8316 May 30 11:42 XCLIENT_README.html -r--r--r-- 1 root wheel 7961 May 30 11:42 XFORWARD_README.html -r--r--r-- 1 root wheel 21057 May 30 11:42 access.5.html -r--r--r-- 1 root wheel 9894 May 30 11:42 aliases.5.html -r--r--r-- 1 root wheel 10197 May 30 11:42 anvil.8.html -r--r--r-- 1 root wheel 86 May 30 11:42 body_checks.5.html -r--r--r-- 1 root wheel 9312 May 30 11:42 bounce.5.html -r--r--r-- 1 root wheel 9217 May 30 11:42 bounce.8.html -r--r--r-- 1 root wheel 14536 May 30 11:42 canonical.5.html -r--r--r-- 1 root wheel 4597 May 30 11:42 cidr_table.5.html -r--r--r-- 1 root wheel 26714 May 30 11:42 cleanup.8.html -r--r--r-- 1 root wheel 9217 May 30 11:42 defer.8.html -r--r--r-- 1 root wheel 6161 May 30 11:42 discard.8.html -r--r--r-- 1 root wheel 6959 May 30 11:42 error.8.html -r--r--r-- 1 root wheel 8744 May 30 11:42 flush.8.html -r--r--r-- 1 root wheel 12022 May 30 11:42 generic.5.html -r--r--r-- 1 root wheel 21849 May 30 11:42 header_checks.5.html -r--r--r-- 1 root wheel 4326 May 30 11:42 index.html -r--r--r-- 1 root wheel 33298 May 30 11:42 ldap_table.5.html -r--r--r-- 1 root wheel 44735 May 30 11:42 lmtp.8.html -r--r--r-- 1 root wheel 37276 May 30 11:42 local.8.html -r--r--r-- 1 root wheel 23659 May 30 11:42 mailq.1.html -r--r--r-- 1 root wheel 13281 May 30 11:42 master.5.html -r--r--r-- 1 root wheel 10278 May 30 11:42 master.8.html -r--r--r-- 1 root wheel 16039 May 30 11:42 mysql_table.5.html -r--r--r-- 1 root wheel 23659 May 30 11:42 newaliases.1.html -r--r--r-- 1 root wheel 3511 May 30 11:42 nisplus_table.5.html -r--r--r-- 1 root wheel 20444 May 30 11:42 oqmgr.8.html -r--r--r-- 1 root wheel 9816 May 30 11:42 pcre_table.5.html -r--r--r-- 1 root wheel 17172 May 30 11:42 pgsql_table.5.html -r--r--r-- 1 root wheel 6033 May 30 11:42 pickup.8.html -r--r--r-- 1 root wheel 24990 May 30 11:42 pipe.8.html -r--r--r-- 1 root wheel 12068 May 30 11:42 postalias.1.html -r--r--r-- 1 root wheel 2995 May 30 11:42 postcat.1.html -r--r--r-- 1 root wheel 13386 May 30 11:42 postconf.1.html -r--r--r-- 1 root wheel 512416 May 30 11:42 postconf.5.html -r--r--r-- 1 root wheel 6029 May 30 11:42 postdrop.1.html -r--r--r-- 1 root wheel 3665 May 30 11:42 postfix-logo.jpg -r--r--r-- 1 root wheel 6793 May 30 11:42 postfix-manuals.html -r--r--r-- 1 root wheel 5389 May 30 11:42 postfix-power.png -r--r--r-- 1 root wheel 16132 May 30 11:42 postfix-wrapper.5.html -r--r--r-- 1 root wheel 20539 May 30 11:42 postfix.1.html -r--r--r-- 1 root wheel 3785 May 30 11:42 postkick.1.html -r--r--r-- 1 root wheel 5014 May 30 11:42 postlock.1.html -r--r--r-- 1 root wheel 3777 May 30 11:42 postlog.1.html -r--r--r-- 1 root wheel 14206 May 30 11:42 postmap.1.html -r--r--r-- 1 root wheel 23750 May 30 11:42 postmulti.1.html -r--r--r-- 1 root wheel 9640 May 30 11:42 postqueue.1.html -r--r--r-- 1 root wheel 13426 May 30 11:42 postsuper.1.html -r--r--r-- 1 root wheel 11415 May 30 11:42 proxymap.8.html -r--r--r-- 1 root wheel 25606 May 30 11:42 qmgr.8.html -r--r--r-- 1 root wheel 2358 May 30 11:42 qmqp-sink.1.html -r--r--r-- 1 root wheel 3995 May 30 11:42 qmqp-source.1.html -r--r--r-- 1 root wheel 8511 May 30 11:42 qmqpd.8.html -r--r--r-- 1 root wheel 7727 May 30 11:42 qshape.1.html -r--r--r-- 1 root wheel 7833 May 30 11:42 regexp_table.5.html -r--r--r-- 1 root wheel 8233 May 30 11:42 relocated.5.html -r--r--r-- 1 root wheel 7743 May 30 11:42 scache.8.html -r--r--r-- 1 root wheel 23659 May 30 11:42 sendmail.1.html -r--r--r-- 1 root wheel 5486 May 30 11:42 showq.8.html -r--r--r-- 1 root wheel 13221 May 30 11:42 smtp-sink.1.html -r--r--r-- 1 root wheel 5789 May 30 11:42 smtp-source.1.html -r--r--r-- 1 root wheel 44735 May 30 11:42 smtp.8.html -r--r--r-- 1 root wheel 73742 May 30 11:42 smtpd.8.html -r--r--r-- 1 root wheel 7427 May 30 11:42 spawn.8.html -r--r--r-- 1 root wheel 4424 May 30 11:42 tcp_table.5.html -r--r--r-- 1 root wheel 10085 May 30 11:42 tlsmgr.8.html -r--r--r-- 1 root wheel 9217 May 30 11:42 trace.8.html -r--r--r-- 1 root wheel 15343 May 30 11:42 transport.5.html -r--r--r-- 1 root wheel 18575 May 30 11:42 trivial-rewrite.8.html -r--r--r-- 1 root wheel 10551 May 30 11:42 verify.8.html -r--r--r-- 1 root wheel 15702 May 30 11:42 virtual.5.html -r--r--r-- 1 root wheel 17018 May 30 11:42 virtual.8.html Miroslav Lachman
I can't approve these patches because they involve installing files that the Postfix developers themselves (as Yarema indicated) do not wish to install. From conf/postfix-files: $readme_directory/QMQP_README:f:root:-:644:o $html_directory/CYRUS_README.html:f:root:-:644:o Notice the "o" flag, which signifies that the file is obsolete, and no longer part of Postfix. Miroslav, I cannot reproduce your problem. With the same OPTIONS (in /var/db/ports/postfix/options), I am able to make package, pkg_add, and pkg_delete, with the html and non-HTML README_FILES being installed and de-installed as appropriate. And I do not use a port management tool like portupgrade so I do not have ports.conf. And FWIW your options correspond to postfix-2.4.6,1. -- Sahil Tandon <sahil@tandon.net>
> tar: share/doc/postfix/AAAREADME: Cannot stat: No such file or directory [... for many more files ...] I was seeing this problem also. There is probably an old "readme_directory = no" directive in the file which causes the readme files to not be installed. You need to remove /usr/local/etc/postfix/main.cf then rebuild and reinstall. You will then need to reapply any customizations you made to this file. This is only a user work around. The build/install/package process is inconsistent with respect to using old data from main.cf and probably needs some work.
Responsible Changed From-To: freebsd-ports-bugs->wxs I'll take it.
The problem derives from the precedence of parameter settings in Postfix's post-install(1) script. If NOPORTDOCS=no AND the readme_directory parameter is not passed to post-install(1) AND an existing main.cf contains readme_directory=no, the installation procedure will respect the main.cf variable and NOT install the README_FILES. However, the port will believe these files were installed, and thus try to delete them at uninstall. To fix this, if NOPORTDOCS=no, this means the documentation (HTML and README_FILES) is desired; in this case, the appropriate readme_directory and html_directory variables are *explicitly* passed to the post-install(1) script so the documentation is definitely installed and the main.cf settings for readme_directory and html_directory are appropriately amended. I will file a PR with the above fix and a few other clean-ups to address another small problem this weekend. Just wanted to send a follow-up so you folks know I'm on it. -- Sahil Tandon <sahil@tandon.net>
On Sat, Jun 06, 2009 at 03:02:17AM -0400, Sahil Tandon wrote: > The problem derives from the precedence of parameter settings in Postfix's > post-install(1) script. If NOPORTDOCS=no AND the readme_directory parameter > is not passed to post-install(1) AND an existing main.cf contains > readme_directory=no, the installation procedure will respect the main.cf > variable and NOT install the README_FILES. However, the port will believe > these files were installed, and thus try to delete them at uninstall. > > To fix this, if NOPORTDOCS=no, this means the documentation (HTML and > README_FILES) is desired; in this case, the appropriate readme_directory and > html_directory variables are *explicitly* passed to the post-install(1) > script so the documentation is definitely installed and the main.cf settings > for readme_directory and html_directory are appropriately amended. > > I will file a PR with the above fix and a few other clean-ups to address > another small problem this weekend. Just wanted to send a follow-up so you > folks know I'm on it. Thank you. You can feel free to send the patch as a follow-up to this PR and I will handle it. Thanks again for looking into this. -- WXS
In the attached patch, we: - bump PORTREVSION - add indentation in a few places for purely cosmetic reasons - explicitly pass readme_directory and html_directory to the Postfix installation process; this may cause modification of existing main.cf - remove 'forced' installation of HTML documentation; instead, the port lets Postfix install these files just as it already does the README_FILES - modify files/pkg-install.in so (main|master).cf, if missing, are installed with default values. this should address the problem in ports/135281 - modify pkg-plist to include SOHO_README, which is now installed at the request of the originator of this PR - still exclude QMQP_README and CYRUS_README despite the request to install them as they are explicitly flagged as 'obsolete' by upstream developer Wesley, you had mentioned running into the same (or at least similar) problem as Miroslav et. al, so please give this a whirl on that same box to test this. I tested on a few boxes with various switched turned on/off, but perhaps there's yet another "situation" in which this will hiccup. Thanks. -- Sahil Tandon <sahil@tandon.net>
With the attachment, my original message appears horribly mangled when viewed in HTML; here is the body once again for posterity. If viewing the raw PR, the patch is viewable with just a few obvious quirks related to the encoding of the email. > In the attached patch, we: > > - bump PORTREVSION > - add indentation in a few places for purely cosmetic reasons > - explicitly pass readme_directory and html_directory to the Postfix > installation process; this may cause modification of existing main.cf > - remove 'forced' installation of HTML documentation; instead, the port lets > Postfix install these files just as it already does the README_FILES > - modify files/pkg-install.in so (main|master).cf, if missing, are installed > with default values. this should address the problem in ports/135281 > - modify pkg-plist to include SOHO_README, which is now installed at the > request of the originator of this PR > - still exclude QMQP_README and CYRUS_README despite the request to install > them as they are explicitly flagged as 'obsolete' by upstream developer > > Wesley, you had mentioned running into the same (or at least similar) problem > as Miroslav et. al, so please give this a whirl on that same box to test > this. I tested on a few boxes with various switched turned on/off, but > perhaps there's yet another "situation" in which this will hiccup. Thanks. -- Sahil Tandon <sahil@tandon.net>
Stuart Barkley $B$5$s$O=q$-$^$7$?(B (2009/06/05 21:11): > I was seeing this problem also. There is probably an old > "readme_directory = no" directive in the file which causes the readme > files to not be installed. Sorry. All processes from writing only of the thing that the treatment of the aliases.db file changes in the ports/UPDATING file to a trifling structural change were able to be understood. The problem was solved. Thank you. :-)
wxs 2009-06-11 01:42:24 UTC FreeBSD ports repository Modified files: mail/postfix Makefile pkg-plist mail/postfix/files pkg-install.in Log: - Cleanup pkg-install script to handle documentation installation correctly. This resulted in a bizarre case where making a backup package after an upgrade would fail (ports/135051). - Don't install obsolete files by adding them to ${WRKSRC}/conf/postfix-files. - Whitespace cleanup. - Define and pass DAEMONDIR to the pkg-install script. PR: ports/135051 Submitted by: Takefu Kenji <takefu@airport.fm>, Yarema <yds@CoolRat.org> Approved by: sahil@tandon.net (maintainer) Revision Changes Path 1.148 +21 -11 ports/mail/postfix/Makefile 1.3 +12 -2 ports/mail/postfix/files/pkg-install.in 1.30 +1 -0 ports/mail/postfix/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed This should be fixed for future upgrades. For now you can just not create a backup package when doing the upgrade.