Bug 135213 - sysutils/smartmontools: fix for AUTOdetect mode
Summary: sysutils/smartmontools: fix for AUTOdetect mode
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wesley Shields
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-03 15:10 UTC by Dmitry Morozovsky
Modified: 2009-06-03 19:20 UTC (History)
0 users

See Also:

Attachments
file.diff (1.20 KB, patch)
2009-06-03 15:10 UTC, Dmitry Morozovsky 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Morozovsky freebsd_committer freebsd_triage 2009-06-03 15:10:01 UTC 
Jeremy Chadwick prodded me about questionable correctness of autodetect
procedure, and give nice idea about using kern.disks sysctl.

Here is the implementation.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-06-03 15:10:13 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->marck

Submitter is maintainer and has GNATS access (via the GNATS Auto Assign 
Tool)
Comment 2 Dmitry Morozovsky freebsd_committer freebsd_triage 2009-06-03 15:20:09 UTC 
Responsible Changed
From-To: marck->freebsd-ports-bugs

Maintainer approval, please commit.
Comment 3 Wesley Shields freebsd_committer freebsd_triage 2009-06-03 15:26:15 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->wxs

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2009-06-03 19:12:41 UTC 
wxs         2009-06-03 18:12:30 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/smartmontools Makefile 
    sysutils/smartmontools/files smart.in 
  Log:
  - Fix questionable correctness of autodetect procedure and switch to using
    kern.disks in place of ls /dev/da*[0-9].
  
  PR:             ports/135213
  Submitted by:   Dmitry Morozovsky <marck@freebsd.org> (maintainer)
  
  Revision  Changes    Path
  1.40      +1 -1      ports/sysutils/smartmontools/Makefile
  1.5       +3 -2      ports/sysutils/smartmontools/files/smart.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Wesley Shields freebsd_committer freebsd_triage 2009-06-03 19:12:54 UTC 
State Changed
From-To: open->closed

Committed. Thanks!