Enable use of SIMD optimizations. Off by default and autodetected otherwise. At least they don't break gimp and gegl. While here, fix mktemp(1) invocation in docs/Makefile.in so it no longer produces confusing usage string during build. gmake[2]: Entering directory `/usr/ports/x11/babl/work/babl-0.0.22/docs' Making all in graphics UTF8: BablFishPath.txt [OK] HTML: index.htmlusage: mktemp [-d] [-q] [-t prefix] [-u] template ... mktemp [-d] [-q] [-u] -t prefix . [OK] HTML: BablFishPath.html [OK] RSS: changelog.rss [OK] gmake[2]: Leaving directory `/usr/ports/x11/babl/work/babl-0.0.22/docs' How-To-Repeat: $ make config (select SIMD) $ make configure [...] checking for some Win32 platform... checking for some Win32 platform... no checking for native Win32... no checking whether cc understands -mmmx... yes checking whether we can compile MMX code... yes checking whether cc understands -msse... yes checking whether we can compile SSE code... yes checking whether cc understands -faltivec... no checking whether cc understands -maltivec -mabi=altivec... no checking whether we can compile AltiVec code... no configure: WARNING: The compiler does not support the AltiVec command set. checking for library containing dlopen... none required [...] Notice that AltiVec is NOT enabled even though --enable-altivec was specified.
Responsible Changed From-To: freebsd-ports-bugs->gnome Over to maintainer (via the GNATS Auto Assign Tool)
marcus 2009-08-02 21:35:01 UTC FreeBSD ports repository Modified files: x11/babl Makefile Added files: x11/babl/files patch-docs-Makefile.in Log: * Add support for SIMDoptimizations (off by default). * Fix the invocation of mktemp to prevent a spurious error. PR: 137114 Submitted by: Anonymous <swell.k@gmail.com> Revision Changes Path 1.6 +11 -1 ports/x11/babl/Makefile 1.1 +11 -0 ports/x11/babl/files/patch-docs-Makefile.in (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
ports/137439 turned out to be more global. The change in this PR regarding SIMD defaults was wrong. configure script detects cpu-specific extensions *without* explicit --enable-*. I'm attaching correct diff. Sorry for inconvenience. --- babl.diff begins here --- Index: x11/babl/Makefile =================================================================== RCS file: /home/csup/ports/x11/babl/Makefile,v retrieving revision 1.6 diff -u -p -r1.6 Makefile --- x11/babl/Makefile 2 Aug 2009 21:35:01 -0000 1.6 +++ x11/babl/Makefile 4 Aug 2009 23:05:55 -0000 @@ -31,10 +31,10 @@ OPTIONS= SIMD "Use cpu-specific optimiza .include <bsd.port.pre.mk> -.if !defined(WITHOUT_SIMD) -CONFIGURE_ARGS+=--enable-mmx \ - --enable-sse \ - --enable-altivec +.if defined(WITHOUT_SIMD) +CONFIGURE_ARGS+=--disable-mmx \ + --disable-sse \ + --disable-altivec .endif .include <bsd.port.post.mk> --- babl.diff ends here ---
State Changed From-To: open->closed Committed, thanks!
marcus 2009-08-08 21:13:31 UTC FreeBSD ports repository Modified files: x11/babl Makefile Log: Correct the logic of the SIMD option so that packages are not built with unwanted optimizations. PR: 137114 Submitted by: Anonymous <swell.k@gmail.com> Revision Changes Path 1.7 +4 -4 ports/x11/babl/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"