Bug 137335 - net/balance rc.d script should not force binding to a single interface
Summary: net/balance rc.d script should not force binding to a single interface
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wesley Shields
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-01 16:50 UTC by Hans Hoppe
Modified: 2009-08-04 15:10 UTC (History)
0 users

See Also:

Attachments
file.diff (1.36 KB, patch)
2009-08-01 16:50 UTC, Hans Hoppe 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Hoppe 2009-08-01 16:50:01 UTC 
The net/balance rc.d script has the -b flag to balance hardcoded. This forces balance to bind to a single interface. Use of balance_*_address and the -b flag should be optional.

Fix: The attached patch for balance.sh.in makes using balance_*_address optional.

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-08-01 16:50:11 UTC 
Maintainer of net/balance,

Please note that PR ports/137335 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/137335

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-08-01 16:50:13 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Wesley Shields freebsd_committer freebsd_triage 2009-08-01 17:06:01 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->wxs

I'll take it.
Comment 4 Joseph Scott 2009-08-03 23:19:56 UTC 
I'm fine with that change.

--
Joseph Scott
joseph@josephscott.org
http://josephscott.org/
Comment 5 Wesley Shields freebsd_committer freebsd_triage 2009-08-04 15:07:22 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2009-08-04 15:07:29 UTC 
wxs         2009-08-04 14:07:13 UTC

  FreeBSD ports repository

  Modified files:
    net/balance          Makefile 
    net/balance/files    balance.sh.in 
  Log:
  - Do not force binding to a single interface in RC script.
  
  PR:             ports/137335
  Submitted by:   Hans Hoppe <hopha@cinis.com>
  Approved by:    Joseph Scott <joseph@randomnetworks.com> (maintainer)
  
  Revision  Changes    Path
  1.25      +1 -0      ports/net/balance/Makefile
  1.4       +19 -4     ports/net/balance/files/balance.sh.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"