Bug 137619 - [PATCH] x11/kdelibs4: Fix FindKdcraw.cmake FindKexiv2.cmake, FindKipi.cmake
Summary: [PATCH] x11/kdelibs4: Fix FindKdcraw.cmake FindKexiv2.cmake, FindKipi.cmake
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-10 08:30 UTC by Jason E. Hale
Modified: 2009-09-24 21:47 UTC (History)
1 user (show)

See Also:


Attachments
2009-08-09-kdelibs4.diff (11.79 KB, patch)
2009-08-10 08:30 UTC, Jason E. Hale
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason E. Hale 2009-08-10 08:30:05 UTC
FindKdcraw.cmake, FindKexiv2.cmake, and FindKipi.cmake installed by x11/kdelibs4
do not work properly.  They use the deprecated PKGCONFIG macro and do not
properly detect their respective libraries when the KDE3 counterparts are
installed.

Currently, all the ports that I know of requiring these libraries use a
patch that I came up with a while ago to detect Kdcraw, Kexiv2, and Kipi.
Namely:
deskutils/kdeplasma-addons
graphics/digikam-kde4
graphics/kipi-plugins-kde4

I have attached a patch that fixes the detection of the KDE4 versions of
Kdcraw, Kexiv2, and Kipi even if KDE3 versions are installed.  This will help
reduce the patches we have and hopefully prevent any future ones.

How-To-Repeat: Use attached diff.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-08-10 08:30:17 UTC
Responsible Changed
From-To: freebsd-ports-bugs->kde

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Max Brazhnikov freebsd_committer freebsd_triage 2009-09-24 08:37:55 UTC
State Changed
From-To: open->patched

Patched in area51, will be committed to ports later.
Comment 3 dfilter service freebsd_committer freebsd_triage 2009-09-24 21:38:35 UTC
makc        2009-09-24 20:38:20 UTC

  FreeBSD ports repository

  Modified files:
    x11/kdelibs4         Makefile 
    x11/kdelibs4/files   patch-cmake_modules_FindKdcraw.cmake 
                         patch-cmake_modules_FindKexiv2.cmake 
                         patch-cmake_modules_FindKipi.cmake 
  Log:
  Fix several cmake modules.
  Bump PORTREVISION.
  
  PR:             ports/137619
  Submitted by:   Jason E. Hale <bsdkaffee at gmail.com>
  Feature safe:   yes
  
  Revision  Changes    Path
  1.242     +1 -1      ports/x11/kdelibs4/Makefile
  1.3       +84 -8     ports/x11/kdelibs4/files/patch-cmake_modules_FindKdcraw.cmake
  1.3       +80 -9     ports/x11/kdelibs4/files/patch-cmake_modules_FindKexiv2.cmake
  1.3       +71 -8     ports/x11/kdelibs4/files/patch-cmake_modules_FindKipi.cmake
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Max Brazhnikov freebsd_committer freebsd_triage 2009-09-24 21:47:13 UTC
State Changed
From-To: patched->closed

Committed. Thanks!