Bug 138055 - net/luasocket namespace clash with www/lighttpd mod_magnet
Summary: net/luasocket namespace clash with www/lighttpd mod_magnet
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Philip M. Gollucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-21 23:00 UTC by Robert Nagy
Modified: 2010-08-26 19:30 UTC (History)
0 users

See Also:


Attachments
file.diff (9.68 KB, patch)
2009-08-21 23:00 UTC, Robert Nagy
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Nagy 2009-08-21 23:00:12 UTC
Basically - luasocket defines buffer_init(); which is common enough to be defined elsewhere and it is defined in mod_magnet,
so you end up with a SIGSEGV. 
The attatched patch solves the issue by renaming the buffer_* funcs to ls_buffer_*. Its a totally safe diff that does not
affect anything else and fixes a problem.

How-To-Repeat: Write a lua script that uses luasocket and try to use it with mod_magnet.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2009-08-21 23:01:28 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pgollucci

Over to maintainer of net/luasocket.
Comment 2 pgollucci 2009-12-10 07:56:02 UTC
Hi,

Please send your change to the luasocket folks instead, this is not a 
type of change we should keep locally in the FreeBSD ports tree.


-- 
------------------------------------------------------------------------
Philip M. Gollucci (pgollucci@ridecharge.com)
p: 703.549.2050x206, did: 703.579.6947
Senior System Admin - RideCharge, Inc.  http://ridecharge.com
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.
Comment 3 Philip M. Gollucci freebsd_committer freebsd_triage 2009-12-10 07:56:17 UTC
State Changed
From-To: open->closed

ask to send upstream
Comment 4 Philip M. Gollucci freebsd_committer freebsd_triage 2010-08-26 18:12:42 UTC
State Changed
From-To: closed->open

re-open per e-mail
Comment 5 Philip M. Gollucci freebsd_committer freebsd_triage 2010-08-26 19:27:23 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2010-08-26 19:27:29 UTC
pgollucci    2010-08-26 18:27:16 UTC

  FreeBSD ports repository

  Modified files:
    net/luasocket        Makefile 
  Added files:
    net/luasocket/files  patch-src_buffer_c 
  Log:
  -  namespace clash with www/lighttpd mod_magnet
     upstream is gone, but the port is still quite useful
  
  PR:             ports/138055
  Submitted by:   Robert Nagy <robert@openbsd.org>
  
  Revision  Changes    Path
  1.14      +1 -0      ports/net/luasocket/Makefile
  1.1       +233 -0    ports/net/luasocket/files/patch-src_buffer_c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"