Bug 138483 - security/pam_pwdfile port doesn't work post update to 0.99
Summary: security/pam_pwdfile port doesn't work post update to 0.99
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Philip M. Gollucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-02 19:00 UTC by Ben Schumacher
Modified: 2010-02-12 02:40 UTC (History)
0 users

See Also:


Attachments
pam_pwdfile-fix.patch (8.43 KB, patch)
2009-09-05 04:20 UTC, Michael Schout
no flags Details | Diff
file.dat (676 bytes, text/plain)
2009-10-08 02:06 UTC, asc.freebsd
no flags Details
pam_pwdfile.patch (8.57 KB, patch)
2009-10-08 02:06 UTC, asc.freebsd
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Schumacher 2009-09-02 19:00:16 UTC
        After upgrade of pam_pwdfile to 0.99 it no longer works.

        Attempting to use it for an authentication mechanism yields the
        following error in /var/log/messages:
                pamtester: in openpam_load_module(): no /usr/local/lib/pam_pwdfile.so found

        My belief is this has to do with pam_pwdfile addition of an md5.h
        and various friends at version 0.97 (from changelog):
                * added md5.h, md5.c, md5_crypt.c and bigcrypt.c from the
                  pam_unix.c module.  This fixes the bug where crypt() would
                  not be able to do md5 crypting if an SSL library was linked
                  into the calling application.  Several users reported this,
                  but the report (and possible patch, which I chose not to use,
                  opting instead to emulate pam_unix) of
                  Yu Guanghui <ygh@dlut.edu.cn> was most useful.

        The custom Makefile.bsd in 'files' doesn't account for these new
        source files.

How-To-Repeat:         Build and install pam_pwdfile.so 0.99. Configure it to be used with
        some PAM-based system (from /usr/local/etc/pam.d/vsftpd):

        # auth
        auth required   pam_nologin.so                no_warn
        auth sufficient /usr/local/lib/pam_pwdfile.so pwdfile /usr/local/etc/vsftpd.passwd
        auth required   pam_unix.so                   no_warn try_first_pass

        Attempt to autenticate using service:

        $ pamtester vsftpd username auth
        pamtester: Initialization failure
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-09-04 22:25:01 UTC
Maintainer of security/pam_pwdfile,

Please note that PR ports/138483 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/138483

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-09-04 22:25:02 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Michael Schout 2009-09-05 04:20:08 UTC
Very sorry about that.

Attached patch against the port fixes all problems.

the md5 files and also bigcrypt needed to get compiled.

In addition, a header is needed, _pam_macros.h, which are not available
on FreeBSD.  I pulled this header from the Linux-PAM package and
included it so that it compiles.

I bumped the portrevision to 1

I ran pamtester against it, and it succeeds now.

Please commit to security/pam_pwdfile in ports tree.
Comment 4 Michael Schout 2009-10-05 03:28:45 UTC
Can a someone with commit access please commit this?  The version in the
ports tree does not work.  This patch fixes it.  I am the maintainer,
but do not have commit access.
Comment 5 asc.freebsd 2009-10-08 02:06:05 UTC
  AmigaOS...........: http://www.yam.ch/
  Unix/MacOS/Windows: http://www.mozilla.com/thunderbird/

General information about MIME can be found at:
http://en.wikipedia.org/wiki/MIME
Comment 6 Michael Schout 2009-10-28 15:43:45 UTC
Wierd.  It works with <_pam_macros.h> on Freebsd 7.2, so guessing you
are running a different version, or have a different version of GCC
installed.

patch-2.diff looks good and compiles for me also.

Someone please commit patch-2.diff to the ports tree.

Thanks
Comment 7 Ben Schumacher 2009-12-06 17:24:00 UTC
patch-2.diff works for me on FreeBSD 8, also. Any movement on getting
this into ports?

On Wed, Oct 28, 2009 at 8:43 AM, Michael Schout <mschout@gkg.net> wrote:
> Wierd. =C2=A0It works with <_pam_macros.h> on Freebsd 7.2, so guessing yo=
u
> are running a different version, or have a different version of GCC
> installed.
>
> patch-2.diff looks good and compiles for me also.
>
> Someone please commit patch-2.diff to the ports tree.
>
> Thanks
>
Comment 8 Michael Schout 2009-12-07 03:33:03 UTC
Ben Schumacher wrote:
> patch-2.diff works for me on FreeBSD 8, also. Any movement on getting
> this into ports?

I don't have commit access.  I'm the maintainer.

I've voiced my approval for patch-2.diff.  Not sure how else to get a
committer to commit this.

Regards,
Michael Schout
Comment 9 Alexander V. Chernikov 2009-12-26 20:32:36 UTC
Thanks for supplying patch, it works for me on several 7.2 servers
Comment 10 Mark Linimon freebsd_committer freebsd_triage 2009-12-27 14:53:58 UTC
State Changed
From-To: feedback->open

maintainer supplied a patch some time ago and it has been confirmed 
to work.
Comment 11 Mark Linimon freebsd_committer freebsd_triage 2009-12-27 14:55:07 UTC
State Changed
From-To: open->analyzed

Perhaps 'analyzed' is a better state for this.
Comment 12 Philip M. Gollucci freebsd_committer freebsd_triage 2010-01-13 04:25:06 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pgollucci

I'll take it.
Comment 13 Philip M. Gollucci freebsd_committer freebsd_triage 2010-01-13 04:25:14 UTC
State Changed
From-To: analyzed->open

Maintainer has approved.
Comment 14 dfilter service freebsd_committer freebsd_triage 2010-02-12 02:31:23 UTC
pgollucci    2010-02-12 02:31:09 UTC

  FreeBSD ports repository

  Modified files:
    security/pam_pwdfile Makefile 
    security/pam_pwdfile/files Makefile.bsd 
  Added files:
    security/pam_pwdfile/files _pam_macros.h patch-bigcrypt.c 
  Log:
  -  Fix runtime to actually work
     update the custom Makefile
     add a required header
     fix bigcrypt
  
  PR:             ports/138483
  Submitted by:   Ben Schumacher <me@benschumacher.com>
  Approved by:    Michael Schout <mschout@gkg.net> (maintainer)
  
  Revision  Changes    Path
  1.7       +3 -0      ports/security/pam_pwdfile/Makefile
  1.3       +19 -1     ports/security/pam_pwdfile/files/Makefile.bsd
  1.1       +196 -0    ports/security/pam_pwdfile/files/_pam_macros.h (new)
  1.1       +11 -0     ports/security/pam_pwdfile/files/patch-bigcrypt.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 15 Philip M. Gollucci freebsd_committer freebsd_triage 2010-02-12 02:32:44 UTC
State Changed
From-To: open->closed

Committed. Thanks!