Bug 138643 - New port: x11-wm/matwm2 A minimalistic, yet functional window manager for x11
Summary: New port: x11-wm/matwm2 A minimalistic, yet functional window manager for x11
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-08 23:30 UTC by Mattis Michel
Modified: 2009-09-14 18:40 UTC (History)
0 users

See Also:


Attachments
file.shar (1.63 KB, text/plain)
2009-09-08 23:30 UTC, Mattis Michel
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mattis Michel 2009-09-08 23:30:04 UTC
matwm2 is a simple window manager for x11
it aims to be small, fast, stable and usable

WWW: http://www.gatorgitter.com/~maties/
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2009-09-09 02:50:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.
Comment 2 Dmitry Marakasov 2009-09-09 03:06:47 UTC
* Mattis Michel (sic_zer0@hotmail.com) wrote:

> XPORTNAME=      matwm2
> XPORTVERSION=   0.0.61
> XCATEGORIES=    x11-wm
> XMASTER_SITES=  http://www.gatorgitter.com/~maties/
> XUSE_XORG=      x11 xext

- USE_XORG should appear after MAINTAINER+COMMENT block.
- Please use tabs for identation.
- As there's only one file installed by the port, please use PLIST_FILES
  instead of pkg-plist.

You may run portlint -A (ports/ports-mgmt/portlint) to get list of
these errors.

Next, the port doesn't respect CC, PREFIX and LOCALBASE, thus fails to
build:

http://people.freebsd.org/~amdmi3/matwm2-0.0.61.log

you should likely patch Makefile like this:

-prefix  = /usr/local
-XROOT   = /usr/X11R6
-CC      = cc
+prefix  = ${PREFIX}
+XROOT   = ${LOCALBASE}

for it to use correct values passed in the environement.

Also, -DDEBUG -ggdb3 line should likely be removed, unless this is
really experimental and buggy software. One can always build debug
version of a port by defining WITH_DEBUG.

Finally, you should also change install invocation in install: target
to ${BSD_INSTALL_PROGRAM} - so it handle perms and stripping
correctly.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2009-09-09 03:06:56 UTC
State Changed
From-To: open->feedback

Awaiting submitters feedback
Comment 4 Mattis Michel 2009-09-09 13:52:44 UTC
This one schould fix all of the mentioned issues.

# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#       matwm2
#       matwm2/Makefile
#       matwm2/files
#       matwm2/files/patch-Makefile
#       matwm2/pkg-descr
#       matwm2/distinfo
#
echo c - matwm2
mkdir -p matwm2 > /dev/null 2>&1
echo x - matwm2/Makefile
sed 's/^X//' >matwm2/Makefile << '36ddfe69e7c18174b15b46fcbe935f3f'
X# New ports collection makefile for:   matwm2
X# Date created:        5 December 1994
X# Whom:                asami
X#
X# $FreeBSD$
X#
X
XPORTNAME=      matwm2
XPORTVERSION=   0.0.62
XCATEGORIES=    x11-wm
XMASTER_SITES=  http://www.gatorgitter.com/~maties/
X
XMAINTAINER=    sic_zer0@hotmail.com
XCOMMENT=       A minimalistic, yet functional window manager for x11
X
XUSE_XORG=      x11 xext
XPLIST_FILES=   bin/matwm2
X
X.include <bsd.port.mk>
36ddfe69e7c18174b15b46fcbe935f3f
echo c - matwm2/files
mkdir -p matwm2/files > /dev/null 2>&1
echo x - matwm2/files/patch-Makefile
sed 's/^X//' >matwm2/files/patch-Makefile << '0b5204de1907b96a1c905889bc9c14e7'
X--- Makefile.orig      2009-09-09 14:31:47.000000000 +0200
X+++ Makefile   2009-09-09 14:32:41.000000000 +0200
X@@ -1,6 +1,5 @@
X-prefix  = /usr/local
X-XROOT   = /usr/X11R6
X-CC      = cc
X+prefix  = ${PREFIX}
X+XROOT   = ${LOCALBASE}
X 
X CFLAGS  += -lXext -lX11 -I$(XROOT)/include -L$(XROOT)/lib
X #CFLAGS  += -DDEBUG -ggdb3 # -DDEBUG_EVENTS -DSYNC
X@@ -17,7 +16,7 @@
X               ./makeheader *.c > all.h
X 
X install:      matwm2
X-              install -s matwm2 $(prefix)/bin
X+              ${BSD_INSTALL_PROGRAM} -s matwm2 $(prefix)/bin
X 
X deinstall:
X               rm -f $(prefix)/bin/matwm2
0b5204de1907b96a1c905889bc9c14e7
echo x - matwm2/pkg-descr
sed 's/^X//' >matwm2/pkg-descr << '99dc3038d471035309ad63f184c34b65'
Xmatwm2 is a simple window manager for x11
Xit aims to be small, fast, stable and usable
X
XWWW: http://www.gatorgitter.com/~maties/
99dc3038d471035309ad63f184c34b65
echo x - matwm2/distinfo
sed 's/^X//' >matwm2/distinfo << 'ca6600083d51fbb3546c8f6de75c7eb6'
XMD5 (matwm2-0.0.62.tar.gz) = 2ea37c44b05f19365cf4935eb81257ba
XSHA256 (matwm2-0.0.62.tar.gz) = e5b7833b292eff8d98a4d20b83611ca9e4f44fb93bb7e3
bd3cc9905125f2150
XSIZE (matwm2-0.0.62.tar.gz) = 837715
ca6600083d51fbb3546c8f6de75c7eb6
exit


_________________________________________________________________
With Windows Live, you can organize, edit, and share your photos.
http://www.windowslive.com/Desktop/PhotoGallery=
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2009-09-14 18:32:13 UTC
State Changed
From-To: feedback->open

Feedback received
Comment 6 Dmitry Marakasov freebsd_committer freebsd_triage 2009-09-14 18:32:52 UTC
State Changed
From-To: open->closed

New port added, with minor changes. Thanks!
Comment 7 dfilter service freebsd_committer freebsd_triage 2009-09-14 18:32:54 UTC
amdmi3      2009-09-14 17:32:41 UTC

  FreeBSD ports repository

  Modified files:
    x11-wm               Makefile 
  Added files:
    x11-wm/matwm2        Makefile distinfo pkg-descr 
    x11-wm/matwm2/files  patch-Makefile 
  Log:
  matwm2 is a simple window manager for x11.
  It aims to be small, fast, stable and usable
  
  WWW: http://www.gatorgitter.com/~maties/
  
  PR:             138643
  Submitted by:   Mattis Michel <sic_zer0@hotmail.com>
  
  Revision  Changes    Path
  1.250     +1 -0      ports/x11-wm/Makefile
  1.1       +19 -0     ports/x11-wm/matwm2/Makefile (new)
  1.1       +3 -0      ports/x11-wm/matwm2/distinfo (new)
  1.1       +20 -0     ports/x11-wm/matwm2/files/patch-Makefile (new)
  1.1       +4 -0      ports/x11-wm/matwm2/pkg-descr (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"