Bug 138801 - [Patch] security/amavisd-new: make install overwrites amavisd.conf
Summary: [Patch] security/amavisd-new: make install overwrites amavisd.conf
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Gabor Kovesdan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-14 06:20 UTC by Herbert J. Skuhra
Modified: 2009-09-17 22:40 UTC (History)
0 users

See Also:


Attachments
file.txt (458 bytes, text/plain)
2009-09-14 06:20 UTC, Herbert J. Skuhra
no flags Details
Makefile.diff (487 bytes, patch)
2009-09-16 00:48 UTC, Herbert J. Skuhra
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Herbert J. Skuhra 2009-09-14 06:20:03 UTC
ports/136151 removes ".include <bsd.port.pre.mk>" and ".include <bsd.port.post.mk>"

So when you upgrade the port your amavisd.conf is overwriten.

install -o root -g vscan -m 640 /usr/ports/security/amavisd-new/work/amavisd-new-2.6.4/amavisd.conf /usr/local/etc

Fix: Re-add ".include <bsd.port.pre.mk>" and ".include <bsd.port.post.mk>"

Patch attached with submission follows:
How-To-Repeat: # cp /usr/local/etc/amavisd.conf /usr/local/etc/amavisd.conf.bak
# cd /usr/ports/security/amavisd-new/
# make deinstall
===>  Deinstalling for security/amavisd-new
===>   Deinstalling amavisd-new-2.6.4_2,1
You should manually remove the "vscan" group.
You should manually remove the "vscan" user.
You should manually remove the "/var/amavis" directory.
You should manually remove the "/var/virusmails" directory.
# ls -la /usr/local/etc/amavisd.conf
-rw-r-----  1 root  vscan  10649 13 sep 23:11 /usr/local/etc/amavisd.conf
# make install clean
 
# ls -la /usr/local/etc/amavisd.conf
-rw-r-----  1 root  vscan  34880 14 sep 07:03 /usr/local/etc/amavisd.conf
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-09-14 06:20:13 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gabor

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Herbert J. Skuhra 2009-09-16 00:48:01 UTC
Hi!

I have sent the wrong file. The correct one is attached.

- Herbert
Comment 3 dfilter service freebsd_committer freebsd_triage 2009-09-17 22:31:25 UTC
gabor       2009-09-17 21:31:11 UTC

  FreeBSD ports repository

  Modified files:
    security/amavisd-new Makefile 
  Log:
  - Don't overwrite edited configuration file
  
  PR:             ports/138801
  Submitted by:   "Herbert J. Skuhra" <h.skuhra@gmail.com>
  Feature safe:   yes
  
  Revision  Changes    Path
  1.74      +3 -1      ports/security/amavisd-new/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Gabor Kovesdan freebsd_committer freebsd_triage 2009-09-17 22:32:05 UTC
State Changed
From-To: open->closed

Fixed, thanks!