Bug 138935 - ports/emulators/virtualbox/Makefile IGNORE= enhancement
Summary: ports/emulators/virtualbox/Makefile IGNORE= enhancement
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Beat Gaetzi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-18 11:20 UTC by jhs
Modified: 2009-09-29 16:20 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jhs 2009-09-18 11:20:06 UTC
	The complaint from Makefile:
		requires 32-bit libraries installed under /usr/lib32
	does not tell the clueless what to do, 
	so give them a clue

Fix: Patch appended:


PS I noticed:
	ldconfig -v  -32 -m -R /usr/lib32
	ldconfig: illegal option -- 3--SfuWpeC7vPEOMNj0s2gwooOzmfsY4UJgjjwWHWd5PamNxBQW
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

*** current/ports/emulators/virtualbox/Makefile	Fri Sep 18 10:30:51 2009
--- new/ports/emulators/virtualbox/Makefile	Fri Sep 18 11:18:08 2009
***************
*** 143,150 ****
  PLIST_SUB+=	I386=""
  .else
  .if !exists(/usr/lib32)
! IGNORE=		requires 32-bit libraries installed under /usr/lib32
  .endif
  KMK_ARCH=	freebsd.${ARCH}
  PLIST_SUB+=	I386="@comment "
--- 143,149 ----
  PLIST_SUB+=	I386=""
  .else
  .if !exists(/usr/lib32)
! #		Requires 32-bit libraries installed under /usr/lib32
! IGNORE=	"Do: cd /usr/src; make build32 install32; ldconfig -v -m -R /usr/lib32"
  .endif
  KMK_ARCH=	freebsd.${ARCH}
  PLIST_SUB+=	I386="@comment "
How-To-Repeat: 	On an amd64 (or mabe a 64bit 686)
	cd  /pri/FreeBSD/branches/amd64/-current/ports/emulators/virtualbox
	make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-09-18 11:20:20 UTC
Responsible Changed
From-To: freebsd-ports-bugs->vbox

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2009-09-29 16:15:11 UTC
beat        2009-09-29 15:15:02 UTC

  FreeBSD ports repository

  Modified files:
    emulators/virtualbox Makefile pkg-plist 
  Added files:
    emulators/virtualbox/files 
                               patch-src-VBox-HostDrivers-VBoxNetFlt-VBoxNetFltInternal.h 
                               patch-src-VBox-HostDrivers-VBoxNetFlt-freebsd-VBoxNetFlt-freebsd.c 
  Log:
  - Improve error message if /usr/lib32 is not installed on amd64. [1]
  - Fix pkg-plist. Additions directory is only created with
    WITH_GUESTADDITIONS option. [2]
  - Add patch to fix panic with vboxnet driver. [3]
  - Bump PORTREVISION.
  
  PR:             ports/138935 [1] (based on)
  Reported by:    scf@ [3]
  Submitted by:   Julian H. Stacey <jhs AT berklix.com> [1],
                  Bernhard Froehlich <decke AT bluelife.at> [2],
                  Fredrik Lindberg <fli AT shapeshifter.se> [3]
  On behalf of:   vbox@ (decke, dhn, itetcu, miwi, nox)
  Feature safe:   yes
  
  Revision  Changes    Path
  1.8       +10 -3     ports/emulators/virtualbox/Makefile
  1.1       +28 -0     ports/emulators/virtualbox/files/patch-src-VBox-HostDrivers-VBoxNetFlt-VBoxNetFltInternal.h (new)
  1.1       +375 -0    ports/emulators/virtualbox/files/patch-src-VBox-HostDrivers-VBoxNetFlt-freebsd-VBoxNetFlt-freebsd.c (new)
  1.7       +1 -1      ports/emulators/virtualbox/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Beat Gaetzi freebsd_committer freebsd_triage 2009-09-29 16:16:09 UTC
Responsible Changed
From-To: vbox->beat

I'll take it.
Comment 4 Beat Gaetzi freebsd_committer freebsd_triage 2009-09-29 16:18:50 UTC
State Changed
From-To: open->closed

I moved the lib32 check to pre-everything. This allows to display the 
old and your message if the directory is missing. Thanks for your 
submission!