Bug 139046 - mail/postgrey doesn't use local pidfile
Summary: mail/postgrey doesn't use local pidfile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Philip M. Gollucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-22 06:50 UTC by James E Risner
Modified: 2010-01-18 00:20 UTC (History)
0 users

See Also:


Attachments
file.diff (449 bytes, patch)
2009-09-22 06:50 UTC, James E Risner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James E Risner 2009-09-22 06:50:01 UTC
	When /usr/local/etc/rc.d/postgrey checks to see if you have a local pid file (postgrey_pidfile), it hasn't loaded
settings from rc.local yet.  Because of this it defaults to /var/run/postgrey.pid file.  This didn't used to be a problem
with older versions of postgrey because it didn't check to see if the pid file exists for a non running program and it couldn't
remove /var/run/postgrey.pid when shutting down.

	The newest postgrey tries to remove postgrey_pidfile and if the file still exists when it restarts it will no
longer start up.

Fix: This patch fixes the problem:
How-To-Repeat: 	Install the newest postgrey in 7.2 and try to start postgrey, then try to restart it.
Comment 1 Philip M. Gollucci freebsd_committer freebsd_triage 2009-12-29 06:06:33 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pgollucci

I'll take it.
Comment 2 Philip M. Gollucci 2009-12-29 06:28:46 UTC
Maintainer of sysutils/syscp,

Please note that PR ports/139046 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/139046

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Philip M. Gollucci freebsd_committer freebsd_triage 2009-12-29 06:29:02 UTC
State Changed
From-To: open->feedback

Ask for maintainer approval.
Comment 4 Philip M. Gollucci freebsd_committer freebsd_triage 2010-01-17 00:28:03 UTC
State Changed
From-To: feedback->open

feedback-timeout (18 days)
Comment 5 dfilter service freebsd_committer freebsd_triage 2010-01-18 00:14:30 UTC
pgollucci    2010-01-18 00:14:21 UTC

  FreeBSD ports repository

  Modified files:
    mail/postgrey        Makefile 
    mail/postgrey/files  postgrey.in 
  Log:
  - Fix the rc.d script
  
  PR:             ports/139046
  Submitted by:   James E Risner <risner@mail.bullard.de>
  Approved by:    maintainer timeout
  
  Revision  Changes    Path
  1.22      +1 -0      ports/mail/postgrey/Makefile
  1.3       +3 -2      ports/mail/postgrey/files/postgrey.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Philip M. Gollucci freebsd_committer freebsd_triage 2010-01-18 00:14:33 UTC
State Changed
From-To: open->closed

Committed. Thanks!